Page MenuHomePhabricator

jonathanmeier (Jonathan Meier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2016, 11:39 AM (195 w, 6 d)

Recent Activity

Fri, Oct 11

jonathanmeier added a comment to D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line.

You may be interested to also look on PR43583 related to readability-redundant-member-init.

Thanks Eugene, I'm having trouble finding that. https://reviews.llvm.org/D43583 seems related to MIPS instructions rather than readability-redundant-member-init. Could you please post a link? Thanks.

Fri, Oct 11, 12:20 AM · Restricted Project, Restricted Project

Mon, Oct 7

jonathanmeier added inline comments to rL373874: Fix behavior of __builtin_bit_cast when the From and To types are the.
Mon, Oct 7, 10:15 AM

Mon, Sep 16

jonathanmeier added a comment to D67247: Added missing unqualified name lookup of operator overloads for fold expressions.

ping @rsmith

Mon, Sep 16, 10:31 AM · Restricted Project

Sep 12 2019

jonathanmeier added a comment to D67460: clang-tidy: modernize-use-using work with multi-argument templates.

Nice! I don't have commit access, so we'll need someone else have another look. @alexfh, since you previously worked on this, would you mind taking a look at this patch?

Sep 12 2019, 2:53 PM · Restricted Project, Restricted Project
jonathanmeier added a comment to D67460: clang-tidy: modernize-use-using work with multi-argument templates.

Thanks, this looks much better now. I think there's no need to track nesting of parenthesis, brackets and braces separately, so we can collapse ParenLevel, BraceLevel and SquareBracketLevel into a single NestingLevel, which simplifies all the conditions quite a bit.

Sep 12 2019, 1:17 PM · Restricted Project, Restricted Project
jonathanmeier added a comment to D67460: clang-tidy: modernize-use-using work with multi-argument templates.

Also note that your enhanced version of my first example actually works with your initial patch, since the two comparison operators cancel each other out in the counting logic.

Sep 12 2019, 5:17 AM · Restricted Project, Restricted Project
jonathanmeier added a comment to D67460: clang-tidy: modernize-use-using work with multi-argument templates.

Unfortunately, only considering parenthesis (l_paren, r_paren) is not sufficient. We need to consider all the nesting tokens, including brackets (l_square, r_square) and braces (l_brace, r_brace), since the Standard says (C++ 17 Draft N4659, Section 17.2/3):

[...] When parsing a template-argument-list, the first non-nested > is taken as the ending delimiter rather than a greater-than operator. [...]

Example with brackets that fails with your updated patch:

template <bool B>
struct S {};
Sep 12 2019, 5:08 AM · Restricted Project, Restricted Project

Sep 11 2019

jonathanmeier added a comment to D67460: clang-tidy: modernize-use-using work with multi-argument templates.

With non-type template parameters we can have expressions inside template arguments, including comparison operators like <, <=, > and >=, which lets us write typedefs like this:

template <bool B>
struct S {};
Sep 11 2019, 4:08 PM · Restricted Project, Restricted Project

Sep 5 2019

jonathanmeier created D67247: Added missing unqualified name lookup of operator overloads for fold expressions.
Sep 5 2019, 5:23 PM · Restricted Project

Jan 13 2016

jonathanmeier added a comment to D16150: Fix project name conflict for MSBuild.

Could you please commit that for me? I don't have write access to the repository.

Jan 13 2016, 1:59 PM
jonathanmeier retitled D16150: Fix project name conflict for MSBuild from to Fix project name conflict for MSBuild.
Jan 13 2016, 12:06 PM