Page MenuHomePhabricator

johanengelen (Johan Engelen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 5 2014, 12:02 PM (333 w, 6 d)

Recent Activity

Dec 31 2019

johanengelen added a comment to D69537: [asan] Provide interface to iterate over all Fake stack regions.
In D69537#1799478, @kcc wrote:

How is this going to work when one thread calls __sanitizer_for_each_extra_stack_range with another thread's ID,
while that other thread creates and discards frames, or while that other thread is being destroyed?

Dec 31 2019, 2:27 AM · Restricted Project, Restricted Project

Nov 20 2019

johanengelen added a reviewer for D69537: [asan] Provide interface to iterate over all Fake stack regions: pcc.
Nov 20 2019, 2:15 PM · Restricted Project, Restricted Project
johanengelen updated the diff for D69537: [asan] Provide interface to iterate over all Fake stack regions.

Included a testcase now.

Nov 20 2019, 2:09 PM · Restricted Project, Restricted Project

Oct 28 2019

johanengelen created D69537: [asan] Provide interface to iterate over all Fake stack regions.
Oct 28 2019, 3:15 PM · Restricted Project, Restricted Project

Nov 6 2018

johanengelen added a comment to D54043: Adding debug info to support Fortran (part 1).

Please note that D also has the pure attribute on functions, so I would like the pure flag to not be Fortran-specific such that we can use it for D too. Thanks!

I don't see any technical reason that this changeset's DIFlagPure cannot be used with another language. (The changes were merely done for Fortran compilers.)

Nov 6 2018, 11:59 AM · Restricted Project, debug-info
johanengelen added a comment to D54043: Adding debug info to support Fortran (part 1).

Please note that D also has the pure attribute on functions, so I would like the pure flag to not be Fortran-specific such that we can use it for D too. Thanks!

Nov 6 2018, 5:12 AM · Restricted Project, debug-info

Mar 20 2018

johanengelen added a comment to D44321: Support demangling for D symbols via dlopen.

When druntime is initialized, a number of resources are allocated (e.g. memory and mutex). Yes you initialize druntime once, I can see that. You don't deinitialize druntime at all: that's the resource leak.

Where would you want me to deinit? inside DLanguage::Terminate ?

Mar 20 2018, 4:18 PM · Restricted Project

Mar 14 2018

johanengelen added a comment to D44321: Support demangling for D symbols via dlopen.

How do you de-initialize druntime? (without de-init, there is a big mem leak)

There is no memory leak because d_initialize once (using c++11 static initialization pattern) and is intended to last for duration of application; so druntime will be initialized only once, upon 1st use.

Mar 14 2018, 4:24 PM · Restricted Project

Mar 11 2018

johanengelen added a comment to D44321: Support demangling for D symbols via dlopen.
extern "C" char* lldbd_demangle(size_t length, const char* mangled) {
   if (mangled == "_D3fooFZv") // pseudo code
       return "void foo()";
   else
       return mangled;
}
Mar 11 2018, 5:28 AM · Restricted Project
johanengelen added a comment to D44321: Support demangling for D symbols via dlopen.

It's a little more complicated for D because it's an out-of-tree compiler so it poses interesting challenges.

the demangling itself is thoroughly tested in https://github.com/dlang/druntime/blob/master/src/core/demangle.d

Mar 11 2018, 5:20 AM · Restricted Project
johanengelen added inline comments to D44321: Support demangling for D symbols via dlopen.
Mar 11 2018, 4:58 AM · Restricted Project

Mar 9 2018

johanengelen added inline comments to D44321: Support demangling for D symbols via dlopen.
Mar 9 2018, 1:40 PM · Restricted Project

Sep 17 2017

johanengelen closed D37961: [ThinLTO] Avoid archive member collisions with old API.
Sep 17 2017, 10:39 AM
johanengelen added a comment to D37961: [ThinLTO] Avoid archive member collisions with old API.

I did not check Xcode 9 (can't on my current system :/ ).

Sep 17 2017, 10:29 AM
johanengelen added a comment to D37961: [ThinLTO] Avoid archive member collisions with old API.

(I did not know how to test this well, so no test added)

Sep 17 2017, 9:33 AM
johanengelen created D37961: [ThinLTO] Avoid archive member collisions with old API.
Sep 17 2017, 9:31 AM

Sep 21 2016

johanengelen retitled D24794: Use Clang for D language support until there is a proper language plugin for it. from to Use Clang for D language support until there is a proper language plugin for it..
Sep 21 2016, 5:21 AM

Apr 24 2016

johanengelen added a comment to D19189: Expose the list of available features in MCSubtargetInfo.

I want to know whether a certain feature (say, "avx") is enabled for the current target.

Apr 24 2016, 1:50 AM

Apr 23 2016

johanengelen abandoned D19189: Expose the list of available features in MCSubtargetInfo.
Apr 23 2016, 3:53 AM
johanengelen added a comment to D19189: Expose the list of available features in MCSubtargetInfo.

(yes I think it does make sense, because the necessary const_cast is very ugly)

Apr 23 2016, 2:32 AM
johanengelen added a comment to D19189: Expose the list of available features in MCSubtargetInfo.

I don't know how I missed "ToggleFeature", thanks very much for pointing me in that direction!
With the current interface, I think I can already do what I want:

Apr 23 2016, 2:07 AM

Apr 22 2016

johanengelen added a comment to D19189: Expose the list of available features in MCSubtargetInfo.

A friendly ping.

Apr 22 2016, 5:08 AM

Apr 16 2016

johanengelen added inline comments to D19189: Expose the list of available features in MCSubtargetInfo.
Apr 16 2016, 5:20 AM
johanengelen retitled D19189: Expose the list of available features in MCSubtargetInfo from to Expose the list of available features in MCSubtargetInfo.
Apr 16 2016, 5:19 AM

Apr 7 2016

johanengelen added a comment to D17864: [PGO] Promote indirect calls to conditional direct calls with value-profile.

(thanks for your work on this btw! ;)

Apr 7 2016, 11:05 AM

Apr 6 2016

johanengelen added inline comments to D17864: [PGO] Promote indirect calls to conditional direct calls with value-profile.
Apr 6 2016, 10:22 AM

Jun 5 2014

johanengelen added inline comments to D3420: MinGW toolchain.
Jun 5 2014, 12:09 PM