Page MenuHomePhabricator

joeywatts (Joey Watts)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 10 2022, 2:44 PM (7 w, 5 d)

Recent Activity

Aug 18 2022

joeywatts added a comment to D131623: [clang-tidy] Improve modernize-use-emplace check.

Thanks for the review @njames93! This is my first contribution so I don't think I have permission to land this myself, is there someone that can do that for me?

Sure, which email would you like me to use for the commit?

Aug 18 2022, 3:55 AM · Restricted Project, Restricted Project

Aug 17 2022

joeywatts added a comment to D131623: [clang-tidy] Improve modernize-use-emplace check.

Thanks for the review @njames93! This is my first contribution so I don't think I have permission to land this myself, is there someone that can do that for me?

Aug 17 2022, 6:28 PM · Restricted Project, Restricted Project

Aug 11 2022

joeywatts updated the diff for D131623: [clang-tidy] Improve modernize-use-emplace check.

Address code review comments

Aug 11 2022, 1:21 PM · Restricted Project, Restricted Project
joeywatts added a comment to D131623: [clang-tidy] Improve modernize-use-emplace check.

Just a general drive by comment here and doesn't affect this patch.
This specifying containers logic is a little verbose, There may be a case to deprecate most of these options and just detect containers with an equivalent emplace* method at runtime.

Aug 11 2022, 8:06 AM · Restricted Project, Restricted Project
joeywatts updated the diff for D131623: [clang-tidy] Improve modernize-use-emplace check.

Update commit title/message

Aug 11 2022, 7:18 AM · Restricted Project, Restricted Project
joeywatts published D131623: [clang-tidy] Improve modernize-use-emplace check for review.
Aug 11 2022, 7:14 AM · Restricted Project, Restricted Project