Page MenuHomePhabricator

jinlin (Jin Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 8 2015, 3:17 PM (241 w, 6 d)

Recent Activity

Apr 6 2020

jinlin committed rG28ecd7f0b086: [clang-format] Don't break multi block parameters on… (authored by ghvg1313).
[clang-format] Don't break multi block parameters on…
Apr 6 2020, 2:44 PM
jinlin closed D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam.
Apr 6 2020, 2:43 PM · Restricted Project, Restricted Project

Mar 18 2020

jinlin committed rG0d896278c81c: Support repeated machine outlining (authored by jinlin).
Support repeated machine outlining
Mar 18 2020, 10:53 AM
jinlin added a comment to D71027: Support repeated machine outlining.

Testing Time: 128.22s

Expected Passes    : 36105
Expected Failures  : 163
Unsupported Tests  : 336
Mar 18 2020, 10:52 AM · Restricted Project
jinlin updated the diff for D71027: Support repeated machine outlining.

I have made minor changes in test case llvm/test/CodeGen/AArch64/machine-outliner-iterative.mir.

Mar 18 2020, 10:20 AM · Restricted Project

Mar 17 2020

jinlin committed rG7b166d518235: Revert "Support repeated machine outlining" (authored by jinlin).
Revert "Support repeated machine outlining"
Mar 17 2020, 6:56 PM
jinlin added a reverting change for rGab2dcff309f9: Support repeated machine outlining: rG7b166d518235: Revert "Support repeated machine outlining".
Mar 17 2020, 6:56 PM
jinlin committed rGab2dcff309f9: Support repeated machine outlining (authored by jinlin).
Support repeated machine outlining
Mar 17 2020, 6:24 PM
jinlin updated the diff for D71027: Support repeated machine outlining.
Mar 17 2020, 2:35 PM · Restricted Project
jinlin committed rGb9f1b8be1cb0: Revert "Support repeated machine outlining" (authored by jinlin).
Revert "Support repeated machine outlining"
Mar 17 2020, 10:11 AM
jinlin added a reverting change for rG1f93b162fc6b: Support repeated machine outlining: rGb9f1b8be1cb0: Revert "Support repeated machine outlining".
Mar 17 2020, 10:11 AM
jinlin committed rG1f93b162fc6b: Support repeated machine outlining (authored by jinlin).
Support repeated machine outlining
Mar 17 2020, 9:39 AM
jinlin closed D71027: Support repeated machine outlining.
Mar 17 2020, 9:39 AM · Restricted Project
jinlin added a comment to D71027: Support repeated machine outlining.

LGTM!

Mar 17 2020, 9:38 AM · Restricted Project

Mar 16 2020

jinlin added inline comments to D71027: Support repeated machine outlining.
Mar 16 2020, 5:31 PM · Restricted Project
jinlin updated the diff for D71027: Support repeated machine outlining.
Mar 16 2020, 5:31 PM · Restricted Project
jinlin added inline comments to D71027: Support repeated machine outlining.
Mar 16 2020, 5:31 PM · Restricted Project

Mar 13 2020

jinlin updated the diff for D71027: Support repeated machine outlining.
Mar 13 2020, 3:07 PM · Restricted Project
jinlin updated the diff for D71027: Support repeated machine outlining.
Mar 13 2020, 3:07 PM · Restricted Project
jinlin added inline comments to D71027: Support repeated machine outlining.
Mar 13 2020, 3:07 PM · Restricted Project

Mar 11 2020

jinlin added inline comments to D71027: Support repeated machine outlining.
Mar 11 2020, 10:33 PM · Restricted Project
jinlin added inline comments to D71027: Support repeated machine outlining.
Mar 11 2020, 10:33 PM · Restricted Project
jinlin updated the diff for D71027: Support repeated machine outlining.
Mar 11 2020, 10:33 PM · Restricted Project
jinlin committed rGa0cacb60549f: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of… (authored by jinlin).
Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of…
Mar 11 2020, 1:36 PM
jinlin closed D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.
Mar 11 2020, 1:36 PM · Restricted Project, Restricted Project
jinlin added inline comments to D71027: Support repeated machine outlining.
Mar 11 2020, 9:37 AM · Restricted Project
jinlin updated the diff for D71027: Support repeated machine outlining.
Mar 11 2020, 9:37 AM · Restricted Project
jinlin updated the diff for D71027: Support repeated machine outlining.
Mar 11 2020, 9:37 AM · Restricted Project
jinlin added inline comments to D71027: Support repeated machine outlining.
Mar 11 2020, 9:04 AM · Restricted Project

Mar 10 2020

jinlin updated the diff for D71027: Support repeated machine outlining.
Mar 10 2020, 10:17 PM · Restricted Project
jinlin added a comment to D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.

Thank you all for your review and suggestions!

Mar 10 2020, 6:37 PM · Restricted Project, Restricted Project
jinlin added inline comments to D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.
Mar 10 2020, 6:24 AM · Restricted Project, Restricted Project
jinlin updated the diff for D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.
Mar 10 2020, 6:24 AM · Restricted Project, Restricted Project

Mar 9 2020

jinlin added inline comments to D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.
Mar 9 2020, 9:55 PM · Restricted Project, Restricted Project
jinlin updated the diff for D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.
Mar 9 2020, 9:55 PM · Restricted Project, Restricted Project
jinlin added a comment to D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.

I have not made changes in swift side since the changes in LLVM have to go in first.

Mar 9 2020, 1:30 PM · Restricted Project, Restricted Project
jinlin updated the diff for D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.
Mar 9 2020, 1:30 PM · Restricted Project, Restricted Project

Mar 6 2020

jinlin committed rGfc6fda90f708: Fix incorrect logic in maintaining the side-effect of compiler generated… (authored by jinlin).
Fix incorrect logic in maintaining the side-effect of compiler generated…
Mar 6 2020, 9:21 AM
jinlin closed D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Mar 6 2020, 9:21 AM · Restricted Project

Mar 5 2020

jinlin committed rGc14f77ebb032: Fix incorrect logic in maintaining the side-effect of compiler generated… (authored by jinlin).
Fix incorrect logic in maintaining the side-effect of compiler generated…
Mar 5 2020, 3:22 PM

Mar 4 2020

jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

All the llvm-lit tests passed without any unexpected fails.

Mar 4 2020, 2:05 PM · Restricted Project
jinlin updated the diff for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Mar 4 2020, 1:30 PM · Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

I have updated the diffs. Now when you compare Diff 248212 with Diff 248301, you will see they are the same.

Mar 4 2020, 1:30 PM · Restricted Project
jinlin updated the diff for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Mar 4 2020, 1:29 PM · Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

Hi, I just tried out this patch locally and I'm seeing failures running the tests:

Failing Tests (3):
     LLVM :: CodeGen/AArch64/machine-outliner-cfi.mir
     LLVM :: CodeGen/AArch64/machine-outliner-noreturn-save-lr.mir
     LLVM :: CodeGen/AArch64/machine-outliner-side-effect.mir
Mar 4 2020, 1:29 PM · Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

Hi, I just tried out this patch locally and I'm seeing failures running the tests:

Failing Tests (3):
     LLVM :: CodeGen/AArch64/machine-outliner-cfi.mir
     LLVM :: CodeGen/AArch64/machine-outliner-noreturn-save-lr.mir
     LLVM :: CodeGen/AArch64/machine-outliner-side-effect.mir
Mar 4 2020, 12:21 PM · Restricted Project
jinlin updated the diff for D71027: Support repeated machine outlining.

Simplified the test case.

Mar 4 2020, 11:15 AM · Restricted Project
jinlin updated the diff for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

rebase master

Mar 4 2020, 10:38 AM · Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

The changes to machine-outliner-noreturn-save-lr.mir look fine to me.

Mar 4 2020, 10:38 AM · Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

Hi Jessica,

Mar 4 2020, 9:32 AM · Restricted Project
jinlin updated the diff for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Mar 4 2020, 9:32 AM · Restricted Project

Mar 3 2020

jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

LGTM!

Mar 3 2020, 3:00 PM · Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

The reason you weren't getting outlined functions is probably because there were attributes missing on the function.

I think that we should be able to simplify it further like this:

# RUN: llc -mtriple=aarch64 -run-pass=machine-outliner -verify-machineinstrs %s -o - | FileCheck %s

# The test checks whether the compiler updates the side effect of function @OUTLINED_FUNCTION_0 by adding the use of register x20.

--- |
  declare void @spam() local_unnamed_addr
  define void @baz() optsize minsize noredzone { ret void }
...
---
name:            baz
tracksRegLiveness: true
body:             |
  bb.0:
    liveins: $x0, $x20

    $x0 = COPY renamable $x20
    BL @spam, csr_aarch64_aapcs, implicit-def dead $lr, implicit $sp, implicit $x0, implicit-def $sp, implicit-def $x0
    renamable $x21 = COPY $x0

    $x0 = COPY renamable $x20
    BL @spam, csr_aarch64_aapcs, implicit-def dead $lr, implicit $sp, implicit $x0, implicit-def $sp, implicit-def $x0
    renamable $x22 = COPY $x0

    $x0 = COPY killed renamable $x20
    BL @spam, csr_aarch64_aapcs, implicit-def dead $lr, implicit $sp, implicit $x0, implicit-def $sp, implicit-def $x0
    renamable $x3 = COPY $x0

    RET_ReallyLR

...

# CHECK: BL @OUTLINED_FUNCTION_0, {{.*}}, implicit $x20, {{.*}}
Mar 3 2020, 1:47 PM · Restricted Project
jinlin updated the diff for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Mar 3 2020, 1:47 PM · Restricted Project

Mar 2 2020

jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

Thank you Jessica for quick feedback. I have updated the test case based on your advice.

Mar 2 2020, 11:09 PM · Restricted Project
jinlin updated the diff for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Mar 2 2020, 11:09 PM · Restricted Project
jinlin added inline comments to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Mar 2 2020, 10:25 PM · Restricted Project

Feb 27 2020

jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

Hi Jessica,

Feb 27 2020, 2:29 PM · Restricted Project

Feb 25 2020

jinlin added a comment to D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.
  1. I will add a llvm-link tests for combining objc and swift bitcode.
  2. What do you mean by "codegen tests for correct value in the object file"? There is no "object file" in the picture. Are you asking for a test that checks the value in the output of llvm-link?

I think the decision was to break apart the current "Objective-C Garbage Collection" metadata. You need codegen test to test that OBJC_IMAGE_INFO is generated correctly after breaking apart the value.

I have question regarding this. Let's assume we have one assembly file from Objective-C and another one from Swift.

Objective-C assembly:
L_OBJC_IMAGE_INFO:

	.long	0
	.long	64

Swift assembly:

L_OBJC_IMAGE_INFO:

	.long	0
	.long	83953472

Let's assume that the llvm-link can link Swift bitcode and Objective-C bit successfully and the llc can generate the assembly for the merged output bitcode.

In the final assembly file, what value do you expect for L_OBJC_IMAGE_INFO?

You can easily test that out with ld64. It depends on the bits in the current garbage collection fields. Most of the fields are useless now (only there for GC which is obsoleted), that is why the module flag uses Override. Some bits in there are taking Max, like OBJC_IMAGE_HAS_CATEGORY_CLASS_PROPERTIES. Swift version should be taking Error since mismatch is a failure, unless it is not set.

Feb 25 2020, 4:17 PM · Restricted Project, Restricted Project
jinlin added a comment to D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.
  1. I will add a llvm-link tests for combining objc and swift bitcode.
  2. What do you mean by "codegen tests for correct value in the object file"? There is no "object file" in the picture. Are you asking for a test that checks the value in the output of llvm-link?

I think the decision was to break apart the current "Objective-C Garbage Collection" metadata. You need codegen test to test that OBJC_IMAGE_INFO is generated correctly after breaking apart the value.

Feb 25 2020, 3:05 PM · Restricted Project, Restricted Project

Feb 24 2020

jinlin added a comment to D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.
  1. I will add a llvm-link tests for combining objc and swift bitcode.
  2. What do you mean by "codegen tests for correct value in the object file"? There is no "object file" in the picture. Are you asking for a test that checks the value in the output of llvm-link?

I think the decision was to break apart the current "Objective-C Garbage Collection" metadata. You need codegen test to test that OBJC_IMAGE_INFO is generated correctly after breaking apart the value.

Feb 24 2020, 4:27 PM · Restricted Project, Restricted Project
jinlin updated the diff for D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.

Update with llvm-link test case.

Feb 24 2020, 4:18 PM · Restricted Project, Restricted Project

Feb 21 2020

jinlin updated the diff for D71027: Support repeated machine outlining.

Update the test from IR file to MIR file.

Feb 21 2020, 4:11 PM · Restricted Project

Feb 20 2020

jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

Updated test case.

Feb 20 2020, 10:08 PM · Restricted Project
jinlin updated the diff for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Feb 20 2020, 9:24 PM · Restricted Project

Feb 14 2020

jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

Also, I guess it would also be good to add a testcase that ensures that a register is not added as implicit when it's undefined in the range.

Feb 14 2020, 10:39 AM · Restricted Project

Feb 13 2020

jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

The outlined function in this test case does not serve the purpose since there are no live in registers. I did check this test case before. If I change the arguments 1, 2, 3, 4 to be incoming registers, the machine outliner won't kick in.

Maybe I'm misunderstanding something here?

(1) Locally, with the patch, adding

liveins: $w0, $w1, $w2, $w3, $w4

does not change the outliner's behaviour.

(2) If I understand correctly, what you are trying to test here is that implicit $xN is added to the outlined call when $xN is not undefined in the outlined range.

Without this patch, this testcase produces

BL @OUTLINED_FUNCTION_0, implicit-def $lr, implicit $sp, implicit-def $lr, implicit-def $w0, implicit-def $w1, implicit-def $w2, implicit-def $w3

With the patch, it adds implicit $wzr, implicit $w4 at the end:

BL @OUTLINED_FUNCTION_0, implicit-def $lr, implicit $sp, implicit-def $w3, implicit-def $w2, implicit-def $w1, implicit-def $w0, implicit-def $lr, implicit-def $w3, implicit-def $w2, implicit-def $w1, implicit-def $w0, implicit $sp, implicit $wzr, implicit $w4

It's kind of weird that the implicit defs are duplicated though. ($lr appears twice in both cases). I'd expect it to be

BL @OUTLINED_FUNCTION_0, implicit-def $lr, implicit-def $w0, implicit-def $w1, implicit-def $w2, implicit-def $w3, implicit $sp, implicit $wzr, implicit $w4

Also, I guess it would also be good to add a testcase that ensures that a register is not added as implicit when it's undefined in the range.

Feb 13 2020, 4:39 PM · Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

The reason that the implicit defs are duplicate is because the compiler traverses the instructions in the reverse order and update the side effect of the new call instruction on the fly.
So the def reg set is introduced to avoid the redundant register.

Feb 13 2020, 4:39 PM · Restricted Project
jinlin updated the diff for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Feb 13 2020, 4:31 PM · Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

I think a MIR testcase would be simpler here. Something like this should work, no?

# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -mtriple=aarch64-apple-darwin -run-pass=machine-outliner -verify-machineinstrs  %s -o - | FileCheck %s
--- |
  define void @foo() noredzone {ret void}
...
---

name:            foo
tracksRegLiveness: true
body:             |
  ; CHECK-LABEL: name: foo
  ; CHECK: bb.0:
  ; CHECK:   successors: %bb.1(0x80000000)
  ; CHECK:   liveins: $w4
  ; CHECK:   BL @OUTLINED_FUNCTION_0, implicit-def $lr, implicit $sp, implicit-def $w3, implicit-def $w2, implicit-def $w1, implicit-def $w0, implicit-def $lr, implicit-def $w3, implicit-def $w2, implicit-def $w1, implicit-def $w0, implicit $sp, implicit $wzr, implicit $w4
  ; CHECK: bb.1:
  ; CHECK:   successors: %bb.2(0x80000000)
  ; CHECK:   liveins: $w4
  ; CHECK:   BL @OUTLINED_FUNCTION_0, implicit-def $lr, implicit $sp, implicit-def $w3, implicit-def $w2, implicit-def $w1, implicit-def $w0, implicit-def $lr, implicit-def $w3, implicit-def $w2, implicit-def $w1, implicit-def $w0, implicit $sp, implicit $wzr, implicit $w4
  ; CHECK: bb.2:
  ; CHECK:   successors: %bb.3(0x80000000)
  ; CHECK:   liveins: $w4
  ; CHECK:   BL @OUTLINED_FUNCTION_0, implicit-def $lr, implicit $sp, implicit-def $w3, implicit-def $w2, implicit-def $w1, implicit-def $w0, implicit-def $lr, implicit-def $w3, implicit-def $w2, implicit-def $w1, implicit-def $w0, implicit $sp, implicit $wzr, implicit $w4
  ; CHECK: bb.3:
  ; CHECK:   liveins: $w4
  ; CHECK:   RET_ReallyLR
  bb.0:
  liveins: $w4
    $w0 = ORRWri $wzr, 1
    $w1 = ORRWri $wzr, 2
    $w2 = ORRWri $wzr, 3
    $w3 = ORRWri $w4, 4
  bb.1:
  liveins: $w4
    $w0 = ORRWri $wzr, 1
    $w1 = ORRWri $wzr, 2
    $w2 = ORRWri $wzr, 3
    $w3 = ORRWri $w4, 4
  bb.2:
    liveins: $w4
    $w0 = ORRWri $wzr, 1
    $w1 = ORRWri $wzr, 2
    $w2 = ORRWri $wzr, 3
    $w3 = ORRWri $w4, 4
  bb.3:
    liveins: $w4
    RET_ReallyLR
Feb 13 2020, 1:38 PM · Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

More minor changes.

Feb 13 2020, 11:56 AM · Restricted Project
jinlin updated the diff for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Feb 13 2020, 11:56 AM · Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

Fix typos in the comments.

Feb 13 2020, 11:56 AM · Restricted Project
jinlin updated the diff for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Feb 13 2020, 11:47 AM · Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

I have updated the code based on reviewers' feedback and added one test case. Thanks.

Feb 13 2020, 11:46 AM · Restricted Project
jinlin added inline comments to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Feb 13 2020, 11:46 AM · Restricted Project
jinlin updated the diff for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Feb 13 2020, 11:46 AM · Restricted Project

Feb 6 2020

jinlin added a comment to D71027: Support repeated machine outlining.

Sure. I have updated the patch. Please note that the repeating machine outliner may not work correctly without fixing the logic at line 1265.

Thanks! I've commented on D69446 to see if the revision is still active. So I suggest giving this some more time.

Feb 6 2020, 11:07 AM · Restricted Project

Dec 19 2019

jinlin added a comment to D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.

Breaking part the meta data sounds like a good idea. You will probably need to combine the value in the backend to generate the field in the object file.

Also, please add test case. If you go down the route of splitting the value, you need:

  • codegen tests for correct value in the object file
  • llvm-link tests for combining objc and swift bitcode
  • auto upgrade test if you want to support the old bitcode
Dec 19 2019, 11:42 AM · Restricted Project, Restricted Project
jinlin added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

As @lebedev.ri already said, is it possible to add a test for this? I know it is probably covered in your test for D71027 but an independent test would be great!

Dec 19 2019, 10:54 AM · Restricted Project

Dec 9 2019

jinlin created D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.
Dec 9 2019, 11:29 AM · Restricted Project, Restricted Project
jinlin updated the diff for D71027: Support repeated machine outlining.
Dec 9 2019, 11:02 AM · Restricted Project
jinlin created D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.
Dec 9 2019, 11:02 AM · Restricted Project
jinlin added reviewers for D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions: paquette, tellenbach.
Dec 9 2019, 11:02 AM · Restricted Project
jinlin added a comment to D71027: Support repeated machine outlining.

Okay, thanks for clarifying.

In D71027, I have also fixed incorrect logic in maintaining the side-effect information for outlined function at line 1295. This bug shows up during repeated machine outliner.

Would it be possible to separate both patches? The fix can then be reviewed independently from repeated outlining itself.

Dec 9 2019, 9:37 AM · Restricted Project
jinlin updated the diff for D71027: Support repeated machine outlining.
Dec 9 2019, 9:37 AM · Restricted Project

Dec 5 2019

jinlin added a comment to D71027: Support repeated machine outlining.

Hi,

D69446 seems to introduce something similar. Are these patches related or is this just coincidence?

Dec 5 2019, 8:52 PM · Restricted Project

Dec 4 2019

jinlin created D71027: Support repeated machine outlining.
Dec 4 2019, 10:30 AM · Restricted Project

Apr 25 2018

jinlin set the repository for D46071: Representing the target device information in the LLVM IR to rOMP OpenMP.
Apr 25 2018, 11:03 AM
jinlin created D46074: Representing the target device information in the LLVM IR ( CLANG changes).
Apr 25 2018, 10:59 AM
jinlin updated the diff for D46071: Representing the target device information in the LLVM IR.
Apr 25 2018, 10:58 AM
jinlin updated the diff for D46071: Representing the target device information in the LLVM IR.
Apr 25 2018, 10:58 AM
jinlin updated the diff for D46071: Representing the target device information in the LLVM IR.
Apr 25 2018, 10:53 AM
jinlin updated the diff for D46071: Representing the target device information in the LLVM IR.
Apr 25 2018, 10:49 AM
jinlin added a reviewer for D46071: Representing the target device information in the LLVM IR: efriedma.
Apr 25 2018, 10:48 AM
jinlin added a reviewer for D46071: Representing the target device information in the LLVM IR: hfinkel.
Apr 25 2018, 10:42 AM
jinlin created D46071: Representing the target device information in the LLVM IR.
Apr 25 2018, 10:39 AM

Apr 19 2018

jinlin committed rL330362: Refine the loop rotation's API.
Refine the loop rotation's API
Apr 19 2018, 1:33 PM
jinlin closed D45582: Refine the loop rotation's API.
Apr 19 2018, 1:32 PM

Apr 17 2018

jinlin added a comment to D45582: Refine the loop rotation's API.

Thanks Eli for your review.

Apr 17 2018, 2:38 PM