Page MenuHomePhabricator

jim22k (Jim Kitchen)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2022, 9:41 AM (17 w, 13 h)

Recent Activity

Today

jim22k updated the diff for D128004: [mlir][sparse] Add a new reduce operation in sparse_tensor dialect.
  • Merge with latest changes (D128000)
  • Update based on feedback
Mon, Jun 27, 3:10 PM · Restricted Project, Restricted Project

Thu, Jun 16

jim22k retitled D128004: [mlir][sparse] Add a new reduce operation in sparse_tensor dialect from Add a new reduce operation in sparse_tensor dialect to [mlir][sparse] Add a new reduce operation in sparse_tensor dialect.
Thu, Jun 16, 1:48 PM · Restricted Project, Restricted Project
jim22k requested review of D128004: [mlir][sparse] Add a new reduce operation in sparse_tensor dialect.
Thu, Jun 16, 1:39 PM · Restricted Project, Restricted Project

Thu, Jun 2

jim22k abandoned D126333: [mlir][sparse] Add optional start_value to sparse_tensor.init.

With the removal of sparse_tensor.init operation, this change no longer makes sense.

Thu, Jun 2, 10:19 AM · Restricted Project, Restricted Project

May 24 2022

jim22k added a comment to D126333: [mlir][sparse] Add optional start_value to sparse_tensor.init.

I plan to add custom reduction using sparse_tensor.binary later. This PR will focus solely on explicit starting values for non-custom reductions.

May 24 2022, 3:08 PM · Restricted Project, Restricted Project
jim22k requested review of D126333: [mlir][sparse] Add optional start_value to sparse_tensor.init.
May 24 2022, 2:58 PM · Restricted Project, Restricted Project

May 3 2022

jim22k committed rG2c3326608460: [mlir][sparse] Add lowering for unary and binary ops (authored by jim22k).
[mlir][sparse] Add lowering for unary and binary ops
May 3 2022, 1:51 PM · Restricted Project, Restricted Project
jim22k closed D123057: [mlir][sparse] Lowering for unary and binary.
May 3 2022, 1:51 PM · Restricted Project, Restricted Project
jim22k added a comment to D123057: [mlir][sparse] Lowering for unary and binary.

@aartbik Thanks for reviewing and helping me converge on a good solution for lowering.
Once the build passes, I will merge it.

May 3 2022, 8:41 AM · Restricted Project, Restricted Project
jim22k updated the diff for D123057: [mlir][sparse] Lowering for unary and binary.

Make helper functions static

May 3 2022, 8:38 AM · Restricted Project, Restricted Project

Apr 28 2022

jim22k updated the diff for D123057: [mlir][sparse] Lowering for unary and binary.

Few more comments

Apr 28 2022, 11:51 AM · Restricted Project, Restricted Project
jim22k added a comment to D123057: [mlir][sparse] Lowering for unary and binary.

Okay, adding more comments.

Apr 28 2022, 11:51 AM · Restricted Project, Restricted Project
jim22k updated the diff for D123057: [mlir][sparse] Lowering for unary and binary.

Updates based on feedback

Apr 28 2022, 9:52 AM · Restricted Project, Restricted Project
jim22k added inline comments to D123057: [mlir][sparse] Lowering for unary and binary.
Apr 28 2022, 9:16 AM · Restricted Project, Restricted Project

Apr 27 2022

jim22k added a comment to D123057: [mlir][sparse] Lowering for unary and binary.

Sorry my comments are out of order with the new PR. They should be read as if they happened before the new PR. I forgot to submit them until now.

Apr 27 2022, 7:30 AM · Restricted Project, Restricted Project
jim22k added inline comments to D123057: [mlir][sparse] Lowering for unary and binary.
Apr 27 2022, 7:28 AM · Restricted Project, Restricted Project

Apr 26 2022

jim22k updated the diff for D123057: [mlir][sparse] Lowering for unary and binary.

Change back to one Operation *

Apr 26 2022, 2:33 PM · Restricted Project, Restricted Project

Apr 22 2022

jim22k updated the diff for D123057: [mlir][sparse] Lowering for unary and binary.

Change how repeat calls to unary and binary are handled

Apr 22 2022, 12:02 PM · Restricted Project, Restricted Project

Apr 21 2022

jim22k added inline comments to D123057: [mlir][sparse] Lowering for unary and binary.
Apr 21 2022, 1:57 PM · Restricted Project, Restricted Project

Apr 19 2022

jim22k added a comment to D123057: [mlir][sparse] Lowering for unary and binary.

@aartbik I think this PR is ready for a full review. It's passing all the tests.

Apr 19 2022, 1:42 PM · Restricted Project, Restricted Project
jim22k updated the diff for D123057: [mlir][sparse] Lowering for unary and binary.

Add test involving linalg.index

Apr 19 2022, 12:45 PM · Restricted Project, Restricted Project
jim22k updated the diff for D123057: [mlir][sparse] Lowering for unary and binary.

Merge latest from main

Apr 19 2022, 7:26 AM · Restricted Project, Restricted Project

Apr 18 2022

jim22k added inline comments to D123057: [mlir][sparse] Lowering for unary and binary.
Apr 18 2022, 1:11 PM · Restricted Project, Restricted Project
jim22k updated the diff for D123057: [mlir][sparse] Lowering for unary and binary.
  • Make the absent region of sparse_tensor.unary work
Apr 18 2022, 1:04 PM · Restricted Project, Restricted Project

Apr 16 2022

jim22k added inline comments to D123057: [mlir][sparse] Lowering for unary and binary.
Apr 16 2022, 8:01 PM · Restricted Project, Restricted Project
jim22k updated the diff for D123057: [mlir][sparse] Lowering for unary and binary.

Updates based on feedback

Apr 16 2022, 7:48 PM · Restricted Project, Restricted Project

Apr 13 2022

jim22k added inline comments to D123057: [mlir][sparse] Lowering for unary and binary.
Apr 13 2022, 5:13 PM · Restricted Project, Restricted Project

Apr 4 2022

jim22k retitled D123057: [mlir][sparse] Lowering for unary and binary from Lowering for unary and binary to [mlir][sparse] WIP -- Lowering for unary and binary.
Apr 4 2022, 11:58 AM · Restricted Project, Restricted Project
jim22k added a comment to D123057: [mlir][sparse] Lowering for unary and binary.

@aartbik Please take a look and let me know your thoughts on my general approach. I also indicated where I am stuck and could use some help, as I don't truly understand the lattice-set theory.

Apr 4 2022, 11:22 AM · Restricted Project, Restricted Project
jim22k requested review of D123057: [mlir][sparse] Lowering for unary and binary.
Apr 4 2022, 11:09 AM · Restricted Project, Restricted Project

Mar 17 2022

jim22k committed rG414ed019acba: [mlir][sparse] Introduce new binary and unary op (authored by jim22k).
[mlir][sparse] Introduce new binary and unary op
Mar 17 2022, 10:31 AM · Restricted Project
jim22k closed D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.
Mar 17 2022, 10:31 AM · Restricted Project, Restricted Project

Mar 16 2022

jim22k added a comment to D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.

@aartbik Unless you find some more updates to the descriptions, I think this is ready. What is the next step? I don't think I have commit rights, so you will need to commit on my behalf.

Mar 16 2022, 9:59 AM · Restricted Project, Restricted Project
jim22k updated the diff for D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.
Minor text updates
Mar 16 2022, 9:57 AM · Restricted Project, Restricted Project

Mar 15 2022

jim22k updated the diff for D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.
Remove SameTypeOperands trait for binary
Mar 15 2022, 12:11 PM · Restricted Project, Restricted Project

Mar 14 2022

jim22k added inline comments to D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.
Mar 14 2022, 3:49 PM · Restricted Project, Restricted Project

Mar 10 2022

jim22k updated the diff for D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.

Change binary and unary signature

Mar 10 2022, 6:59 PM · Restricted Project, Restricted Project
jim22k added inline comments to D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.
Mar 10 2022, 3:06 PM · Restricted Project, Restricted Project
jim22k added inline comments to D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.
Mar 10 2022, 2:38 PM · Restricted Project, Restricted Project
jim22k added inline comments to D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.
Mar 10 2022, 2:15 PM · Restricted Project, Restricted Project
jim22k added a comment to D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.

@aartbik Let me know your thoughts about my response to adding kind to unary. Once we have agreement, I will update the diff.

Mar 10 2022, 7:36 AM · Restricted Project, Restricted Project

Mar 9 2022

jim22k updated the diff for D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.

Incorporate comments into design of binary and unary

Mar 9 2022, 3:59 PM · Restricted Project, Restricted Project

Mar 8 2022

jim22k added inline comments to D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.
Mar 8 2022, 12:51 PM · Restricted Project, Restricted Project

Mar 7 2022

jim22k added inline comments to D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.
Mar 7 2022, 11:14 AM · Restricted Project, Restricted Project

Mar 6 2022

jim22k added inline comments to D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.
Mar 6 2022, 4:15 PM · Restricted Project, Restricted Project

Mar 4 2022

jim22k updated the diff for D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.

Try again with all the changes this time

Mar 4 2022, 6:54 PM · Restricted Project, Restricted Project
jim22k added a comment to D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.

Okay, so my understanding was tainted by how a Github PR works. I'll try to update the differential to include all 3 commits, rather than the latest commit (which is what arc diff defaults to).

Mar 4 2022, 6:53 PM · Restricted Project, Restricted Project
jim22k added a comment to D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.

They are still there in the history. I did 3 git commits locally: the big one, a minor fix, and then a clang-format one.
While I appreciate that you can view all 3 separate, I don't see a way to view all changes at once, which feels like the most important one to view.
Look at Diff 2 for the real changes.

Mar 4 2022, 2:48 PM · Restricted Project, Restricted Project
jim22k updated the diff for D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.

Fix Formatting

Mar 4 2022, 1:20 PM · Restricted Project, Restricted Project
jim22k retitled D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor from Minor changes to Introduce new binary and unary op for sparse_tensor.
Mar 4 2022, 12:19 PM · Restricted Project, Restricted Project
jim22k updated the diff for D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.

Introduce new binary and unary op for sparse_tensor dialect

Mar 4 2022, 12:18 PM · Restricted Project, Restricted Project
jim22k requested review of D121018: [mlir][sparse] Introduce new binary and unary op for sparse_tensor.
Mar 4 2022, 12:06 PM · Restricted Project, Restricted Project