• Merge with latest changes (D128000)
• Update based on feedback

With the removal of sparse_tensor.init operation, this change no longer makes sense.

I plan to add custom reduction using sparse_tensor.binary later. This PR will focus solely on explicit starting values for non-custom reductions.

@aartbik Thanks for reviewing and helping me converge on a good solution for lowering.
Once the build passes, I will merge it.

Make helper functions static

Few more comments

Okay, adding more comments.

Updates based on feedback

Sorry my comments are out of order with the new PR. They should be read as if they happened before the new PR. I forgot to submit them until now.

Change back to one Operation *

Change how repeat calls to unary and binary are handled

@aartbik I think this PR is ready for a full review. It's passing all the tests.

Add test involving linalg.index

Merge latest from main

• Make the absent region of sparse_tensor.unary work

Updates based on feedback

@aartbik Please take a look and let me know your thoughts on my general approach. I also indicated where I am stuck and could use some help, as I don't truly understand the lattice-set theory.

@aartbik Unless you find some more updates to the descriptions, I think this is ready. What is the next step? I don't think I have commit rights, so you will need to commit on my behalf.

Change binary and unary signature

@aartbik Let me know your thoughts about my response to adding kind to unary. Once we have agreement, I will update the diff.

Incorporate comments into design of binary and unary

Try again with all the changes this time

Okay, so my understanding was tainted by how a Github PR works. I'll try to update the differential to include all 3 commits, rather than the latest commit (which is what arc diff defaults to).

They are still there in the history. I did 3 git commits locally: the big one, a minor fix, and then a clang-format one.
While I appreciate that you can view all 3 separate, I don't see a way to view all changes at once, which feels like the most important one to view.
Look at Diff 2 for the real changes.

Fix Formatting

Introduce new binary and unary op for sparse_tensor dialect