User Details
User Details
- User Since
- Jul 12 2019, 2:02 PM (228 w, 3 d)
Jul 22 2019
Jul 22 2019
jguegant updated the diff for D64818: [libc++] Implement missing filesystem::path constructors with locale.
Fixed few remarks mentioned by @Quuxplusone.
jguegant added a comment to D64818: [libc++] Implement missing filesystem::path constructors with locale.
Thanks a lot @Quuxplusone! I am aware that you cannot take any final decision on what gets in but these are really helpful comments here.
I will fix some of you remarks and upload a better diff (with proper context to get a better picture) afterwards.
Jul 17 2019
Jul 17 2019
jguegant updated the diff for D64818: [libc++] Implement missing filesystem::path constructors with locale.
Removed the unnecessary variables __sentinel.
jguegant added inline comments to D64818: [libc++] Implement missing filesystem::path constructors with locale.
Jul 16 2019
Jul 16 2019
jguegant added a comment to D64818: [libc++] Implement missing filesystem::path constructors with locale.
Note: this is my first contribution to libc++. I tried to follow the style used in the rest of files, but I may have missed some hidden coding style rules: some files use four spaces, some two? Which SFINAE pattern (return type, class paramter...) is to be preferred? Free template functions vs template classes with static member functions?
jguegant updated the summary of D64818: [libc++] Implement missing filesystem::path constructors with locale.
GitHub <noreply@github.com> committed
Merge 8d0dfaadee5fb68dd42ba874995185e155d58ff7 into…
Removed usage of iostream.
jguegant committed rGa3f48749cd13: Fixed tests for creating a path from a locale. (authored by jguegant).
Fixed tests for creating a path from a locale.
Fixed issues.
Fixed bad early return.
Added proper string widening.
jguegant committed rG1a22c9c113dc: Fixed the two constructors with locale for path. (authored by jguegant).
Fixed the two constructors with locale for path.