Page MenuHomePhabricator

jguegant (Jean Guegant)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2019, 2:02 PM (10 w, 18 h)

Recent Activity

Jul 22 2019

jguegant updated the diff for D64818: [libcxx] Construct path using a instance of std::locale.

Fixed few remarks mentioned by @Quuxplusone.

Jul 22 2019, 1:24 PM
jguegant added a comment to D64818: [libcxx] Construct path using a instance of std::locale.

Thanks a lot @Quuxplusone! I am aware that you cannot take any final decision on what gets in but these are really helpful comments here.
I will fix some of you remarks and upload a better diff (with proper context to get a better picture) afterwards.

Jul 22 2019, 12:55 PM

Jul 17 2019

jguegant updated the diff for D64818: [libcxx] Construct path using a instance of std::locale.

Removed the unnecessary variables __sentinel.

Jul 17 2019, 11:26 AM
jguegant added inline comments to D64818: [libcxx] Construct path using a instance of std::locale.
Jul 17 2019, 11:19 AM

Jul 16 2019

jguegant added a comment to D64818: [libcxx] Construct path using a instance of std::locale.

Note: this is my first contribution to libc++. I tried to follow the style used in the rest of files, but I may have missed some hidden coding style rules: some files use four spaces, some two? Which SFINAE pattern (return type, class paramter...) is to be preferred? Free template functions vs template classes with static member functions?

Jul 16 2019, 1:48 PM
jguegant updated the summary of D64818: [libcxx] Construct path using a instance of std::locale.
Jul 16 2019, 1:43 PM
jguegant created D64818: [libcxx] Construct path using a instance of std::locale.
Jul 16 2019, 1:43 PM
GitHub <noreply@github.com> committed rG8cda8d00ff5d: Merge 8d0dfaadee5fb68dd42ba874995185e155d58ff7 into… (authored by jguegant).
Merge 8d0dfaadee5fb68dd42ba874995185e155d58ff7 into…
Jul 16 2019, 1:01 PM
jguegant committed rG8d0dfaadee5f: Removed usage of iostream. (authored by jguegant).
Removed usage of iostream.
Jul 16 2019, 1:00 PM
jguegant committed rGa3f48749cd13: Fixed tests for creating a path from a locale. (authored by jguegant).
Fixed tests for creating a path from a locale.
Jul 16 2019, 1:00 PM
jguegant committed rGd8d0d4446a05: Fixed issues. (authored by jguegant).
Fixed issues.
Jul 16 2019, 1:00 PM
jguegant committed rG4773c89fa794: Fixed bad early return. (authored by jguegant).
Fixed bad early return.
Jul 16 2019, 1:00 PM
jguegant committed rGed97fcb1988f: Added proper string widening. (authored by jguegant).
Added proper string widening.
Jul 16 2019, 1:00 PM
jguegant committed rG1a22c9c113dc: Fixed the two constructors with locale for path. (authored by jguegant).
Fixed the two constructors with locale for path.
Jul 16 2019, 1:00 PM