- User Since
- May 2 2017, 5:38 AM (317 w, 6 d)
Feb 17 2022
Hi both, PTAL. I was surprised to find out that both std::variant<int> and std::optional<int> have a sizeof 12 in my environment, this is my attempt to fix it. Please do let me know if there are other places I need to change, or how I would write a test to prevent future regressions.
Oct 14 2020
LGTM, no concerns from my side.
Oct 12 2020
May 20 2020
"Jan Wilken Dörrie <firstname.lastname@example.org>" works for me :)
May 19 2020
Thanks, Louis! I rebased the diff on the latest master. Could you land the patch for me? I believe I lack the required permissions to do this myself.
May 13 2020
May 12 2020
LGTM, but I would still like to know whether we actually need this in addition to _LIBCPP_DEBUG=0. As far as I can tell setting _LIBCPP_DEBUG to 0 makes _LIBCPP_ASSERT(x, m) be equivalent to ((x) ? (void)0 : abort_fun(x, m)), where abort_fun is effectively the following:
Feb 16 2020
Oh interesting! Yes, it looks like you are right.
Nov 15 2019
Nov 4 2019
Nov 3 2019
Addressed Marshall's comments
Oct 31 2019
Thanks Jorg! Given that the status is still "Needs Review", I assume I also still need an LGTM from Marshall, Louis or Eric, right?
Oct 30 2019
Friendly Ping :)
Oct 28 2019
Apr 1 2019
Remove redundant public: access controls
Aug 29 2017
Thanks for applying a fix based on my patch! I could have sworn the added tests failed locally before applying the algorithm patch, though... oh well.
May 10 2017
Ping, please take a look at this.