- User Since
- Dec 17 2015, 8:13 PM (341 w, 2 d)
Oct 29 2019
Jan 17 2018
Jan 21 2016
Yeah, we can close this. Thanks Lang, Rui, and Rafael for taking a look.
Jan 20 2016
Can confirm that r258329 addresses my use case. Thanks again Rafael. I'll file a separate PR for Mach-O; like I said, it's not a showstopper there.
No worries, thanks for the feedback, Rafael. I was following the example of how we handle rewriting relative references to GOT-equivalent globals into GOTPCREL relocations, which also happens in the AsmPrinter. It'd be great if MC could be made smarter about choosing relocations. The issue also impacts Mach-O, though unlike ELF, Mach-O does support generalized subtractor relocations, so it isn't a showstopper there. These subtractor relocations have however been giving me heartache, exposing unused corners of Darwin's ld and MCJIT, so I think it's better to favor PCREL relocation if we can get them on Mach-O too, since those are much better exercised.
Jan 19 2016
Thanks Rui. Rafael, have you had a chance to look over this yet?
Jan 14 2016
Thanks Lang! Rafael and Rui, do you think you'll be able to take a look soon?