Page MenuHomePhabricator

jckarter (Joe Groff)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 17 2015, 8:13 PM (341 w, 2 d)

Recent Activity

Oct 29 2019

jckarter committed rGe226ae71c546: Collect swift_name warnings under a swift-name-attribute warning group. (authored by jckarter).
Collect swift_name warnings under a swift-name-attribute warning group.
Oct 29 2019, 1:19 PM
jckarter committed rG1a1ef7565539: Validate swift_names that come from API notes. (authored by jckarter).
Validate swift_names that come from API notes.
Oct 29 2019, 1:19 PM
jckarter committed rG02cfc2945fc8: Only allow swift_name attributes on prototyped declarations. (authored by jckarter).
Only allow swift_name attributes on prototyped declarations.
Oct 29 2019, 1:19 PM
jckarter committed rG4bace0c25885: Tighten up validation of swift_name for properties and subscripts. (authored by jckarter).
Tighten up validation of swift_name for properties and subscripts.
Oct 29 2019, 1:18 PM
jckarter committed rG2bd6c3c512bf: Accept subtractions involving a weak symbol. (authored by rafael).
Accept subtractions involving a weak symbol.
Oct 29 2019, 12:34 PM

Jan 17 2018

jckarter created D42223: X86MachObjectWriter: Allow subtractors with undefined targets..
Jan 17 2018, 6:36 PM

Jan 21 2016

jckarter abandoned D15635: AsmPrinter: Produce PC-relative cstexprs when possible..

Closing.

Jan 21 2016, 8:11 AM
jckarter added a comment to D15635: AsmPrinter: Produce PC-relative cstexprs when possible..

Yeah, we can close this. Thanks Lang, Rui, and Rafael for taking a look.

Jan 21 2016, 8:11 AM

Jan 20 2016

jckarter added a comment to D15635: AsmPrinter: Produce PC-relative cstexprs when possible..

Can confirm that r258329 addresses my use case. Thanks again Rafael. I'll file a separate PR for Mach-O; like I said, it's not a showstopper there.

Jan 20 2016, 2:39 PM
jckarter added a comment to D15635: AsmPrinter: Produce PC-relative cstexprs when possible..

No worries, thanks for the feedback, Rafael. I was following the example of how we handle rewriting relative references to GOT-equivalent globals into GOTPCREL relocations, which also happens in the AsmPrinter. It'd be great if MC could be made smarter about choosing relocations. The issue also impacts Mach-O, though unlike ELF, Mach-O does support generalized subtractor relocations, so it isn't a showstopper there. These subtractor relocations have however been giving me heartache, exposing unused corners of Darwin's ld and MCJIT, so I think it's better to favor PCREL relocation if we can get them on Mach-O too, since those are much better exercised.

Jan 20 2016, 11:13 AM

Jan 19 2016

jckarter added a comment to D15635: AsmPrinter: Produce PC-relative cstexprs when possible..

Thanks Rui. Rafael, have you had a chance to look over this yet?

Jan 19 2016, 8:11 AM

Jan 14 2016

jckarter added a comment to D15635: AsmPrinter: Produce PC-relative cstexprs when possible..

Thanks Lang! Rafael and Rui, do you think you'll be able to take a look soon?

Jan 14 2016, 9:33 PM

Dec 17 2015

jckarter retitled D15635: AsmPrinter: Produce PC-relative cstexprs when possible. from to AsmPrinter: Produce PC-relative cstexprs when possible..
Dec 17 2015, 8:18 PM