Page MenuHomePhabricator

janosimas (Jano Simas)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 26 2018, 9:02 AM (170 w, 3 h)

Recent Activity

Sep 7 2021

janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

ping

Sep 7 2021, 11:14 PM · Restricted Project, Restricted Project

Jul 5 2021

janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

That makes sense.
Should I add it somewhere? Or do I need to talk to someone?

Jul 5 2021, 1:44 AM · Restricted Project, Restricted Project

May 25 2021

janosimas updated the diff for D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

Fix test issue.

May 25 2021, 3:39 AM · Restricted Project, Restricted Project

May 24 2021

janosimas updated the diff for D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

Fix a mistake in my last patch.
I added a -- in a command that should not have it.

May 24 2021, 1:39 PM · Restricted Project, Restricted Project
janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

Hmm, I'm not certain what's going on there. When I try to upload a patch for the review, Phab lets me upload it (but I didn't try to submit the changes). At what stage are you getting the failure? Is it when uploading the patch itself, or at some other point?

May 24 2021, 11:26 AM · Restricted Project, Restricted Project
janosimas updated the diff for D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

I manage to upload it, copy-pasting the content to the text box. I have no idea why it is not working with the upload.

May 24 2021, 11:24 AM · Restricted Project, Restricted Project
janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

I found the issue with my diff and I was able to get the expected file.

May 24 2021, 8:17 AM · Restricted Project, Restricted Project
janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

Hi, sorry for taking so long for such a small change.
I did the changes and generated a diff with the requested context.
It's a huge file with a lot more diff than my changes, is that right?

May 24 2021, 1:16 AM · Restricted Project, Restricted Project

Oct 18 2020

janosimas updated the diff for D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

Here a diff with the rebased code

Oct 18 2020, 2:41 AM · Restricted Project, Restricted Project

Dec 16 2019

janosimas updated the diff for D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

I reviewed the code over the discussion with the -- option,
I also changed the -p optin to -strip to avoid confusion with the clang-tidy option.

Dec 16 2019, 2:21 AM · Restricted Project, Restricted Project
janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

I also noticed there is a clang-format-diff that also has the -p option, it would be nice to update it for consistency.

Dec 16 2019, 2:21 AM · Restricted Project, Restricted Project

Oct 3 2018

janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

I like a lot of this syntax you proposed, makes a lot more sense to me.

Oct 3 2018, 4:48 AM · Restricted Project, Restricted Project

Oct 1 2018

janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

I was thinking about the usage of -- and -extra-arg, don't they do the same thing?
To be honest, for me, the current behavior of -- doesn't make much sense. If there is a use case for -extra-arg-before and -extra-arg, they are much more clearer in intent.
For me, -- usual behavior would be pass by options for the first next program, clang-tidy in this case.

Oct 1 2018, 6:37 AM · Restricted Project, Restricted Project

Sep 26 2018

janosimas added inline comments to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Sep 26 2018, 10:45 AM · Restricted Project, Restricted Project
janosimas requested review of D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Sep 26 2018, 10:44 AM · Restricted Project, Restricted Project

Sep 18 2018

janosimas requested review of D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Sep 18 2018, 9:04 AM · Restricted Project, Restricted Project
janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

To use in a git pre-commit I wanted to use the flags:
-warnings-as-errors=*
-header-filter=.*

Sep 18 2018, 9:04 AM · Restricted Project, Restricted Project

Jul 26 2018

janosimas added a reviewer for D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--): alexfh.
Jul 26 2018, 10:00 AM · Restricted Project, Restricted Project
janosimas created D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Jul 26 2018, 9:57 AM · Restricted Project, Restricted Project