- User Since
- Jul 26 2018, 9:02 AM (170 w, 3 h)
Sep 7 2021
Jul 5 2021
That makes sense.
Should I add it somewhere? Or do I need to talk to someone?
May 25 2021
Fix test issue.
May 24 2021
Fix a mistake in my last patch.
I added a -- in a command that should not have it.
Hmm, I'm not certain what's going on there. When I try to upload a patch for the review, Phab lets me upload it (but I didn't try to submit the changes). At what stage are you getting the failure? Is it when uploading the patch itself, or at some other point?
I manage to upload it, copy-pasting the content to the text box. I have no idea why it is not working with the upload.
I found the issue with my diff and I was able to get the expected file.
Hi, sorry for taking so long for such a small change.
I did the changes and generated a diff with the requested context.
It's a huge file with a lot more diff than my changes, is that right?
Oct 18 2020
Here a diff with the rebased code
Dec 16 2019
I reviewed the code over the discussion with the -- option,
I also changed the -p optin to -strip to avoid confusion with the clang-tidy option.
I also noticed there is a clang-format-diff that also has the -p option, it would be nice to update it for consistency.
Oct 3 2018
I like a lot of this syntax you proposed, makes a lot more sense to me.
Oct 1 2018
I was thinking about the usage of -- and -extra-arg, don't they do the same thing?
To be honest, for me, the current behavior of -- doesn't make much sense. If there is a use case for -extra-arg-before and -extra-arg, they are much more clearer in intent.
For me, -- usual behavior would be pass by options for the first next program, clang-tidy in this case.
Sep 26 2018
Sep 18 2018
To use in a git pre-commit I wanted to use the flags: