Page MenuHomePhabricator

janosimas (Jano Simas)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 26 2018, 9:02 AM (117 w, 11 h)

Recent Activity

Sun, Oct 18

janosimas updated the diff for D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

Here a diff with the rebased code

Sun, Oct 18, 2:41 AM · Restricted Project, Restricted Project

Dec 16 2019

janosimas updated the diff for D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

I reviewed the code over the discussion with the -- option,
I also changed the -p optin to -strip to avoid confusion with the clang-tidy option.

Dec 16 2019, 2:21 AM · Restricted Project, Restricted Project
janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

I also noticed there is a clang-format-diff that also has the -p option, it would be nice to update it for consistency.

Dec 16 2019, 2:21 AM · Restricted Project, Restricted Project

Oct 3 2018

janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

I like a lot of this syntax you proposed, makes a lot more sense to me.

Oct 3 2018, 4:48 AM · Restricted Project, Restricted Project

Oct 1 2018

janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

I was thinking about the usage of -- and -extra-arg, don't they do the same thing?
To be honest, for me, the current behavior of -- doesn't make much sense. If there is a use case for -extra-arg-before and -extra-arg, they are much more clearer in intent.
For me, -- usual behavior would be pass by options for the first next program, clang-tidy in this case.

Oct 1 2018, 6:37 AM · Restricted Project, Restricted Project

Sep 26 2018

janosimas added inline comments to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Sep 26 2018, 10:45 AM · Restricted Project, Restricted Project
janosimas requested review of D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Sep 26 2018, 10:44 AM · Restricted Project, Restricted Project

Sep 18 2018

janosimas requested review of D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Sep 18 2018, 9:04 AM · Restricted Project, Restricted Project
janosimas added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

To use in a git pre-commit I wanted to use the flags:
-warnings-as-errors=*
-header-filter=.*

Sep 18 2018, 9:04 AM · Restricted Project, Restricted Project

Jul 26 2018

janosimas added a reviewer for D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--): alexfh.
Jul 26 2018, 10:00 AM · Restricted Project, Restricted Project
janosimas created D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Jul 26 2018, 9:57 AM · Restricted Project, Restricted Project