Page MenuHomePhabricator

jannau (Janne Grunau)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 19 2014, 12:18 AM (356 w, 5 d)

Recent Activity

Aug 6 2015

jannau added a comment to D11215: Adding altmacro support in integrated assembler. continue of D10591 .

gnu as seems to evaluate '%' expressions in macro parameters before it instantiate the macro. small example which doesn't work (even segfaults with diff 30357 for me) currently below:

Aug 6 2015, 1:05 PM

Aug 14 2014

jannau closed D4597: MC: AsmLexer: handle multi-character CommentStrings correctly.

Committed in r215615

Aug 14 2014, 1:50 AM

Aug 13 2014

jannau added a comment to D4882: [aarch64] Fix the problem of using a "//" as comment start..

duplicates http://reviews.llvm.org/D4597

Aug 13 2014, 1:44 PM

Aug 5 2014

jannau updated the diff for D4597: MC: AsmLexer: handle multi-character CommentStrings correctly.

whitespace fixes

Aug 5 2014, 8:21 AM
jannau added a comment to D3507: Darwin vararg parameters support in assembler macros.

A different patch got committed with revision 214799.

Aug 5 2014, 7:40 AM

Aug 4 2014

jannau updated the diff for D4597: MC: AsmLexer: handle multi-character CommentStrings correctly.

added explicit tests with single '#' comments for x86 darwin. A couple of existing tests will catch incorrect parsing of single '#' comments too though.

Aug 4 2014, 12:57 PM

Jul 28 2014

jannau updated the diff for D4597: MC: AsmLexer: handle multi-character CommentStrings correctly.

I've removed the old isAtStartOfComment(const char) and optimized the replacement for the single char comment string case.

Jul 28 2014, 9:26 AM

Jul 25 2014

jannau added a comment to D3507: Darwin vararg parameters support in assembler macros.

Hi Stepan,

Jul 25 2014, 1:17 AM

Jul 24 2014

jannau added a comment to D4597: MC: AsmLexer: handle multi-character CommentStrings correctly.

ping

Jul 24 2014, 6:12 AM
jannau added a comment to D3507: Darwin vararg parameters support in assembler macros.

I would like to see this get merged.

Jul 24 2014, 6:09 AM

Jul 20 2014

jannau updated D4597: MC: AsmLexer: handle multi-character CommentStrings correctly.
Jul 20 2014, 1:39 AM
jannau updated the diff for D4597: MC: AsmLexer: handle multi-character CommentStrings correctly.

adds isAtStartOfComment(const char *Ptr) and uses it to handle multi-character CommentStrings.

Jul 20 2014, 1:35 AM

Jul 19 2014

jannau added inline comments to D4597: MC: AsmLexer: handle multi-character CommentStrings correctly.
Jul 19 2014, 3:19 PM
jannau retitled D4597: MC: AsmLexer: handle multi-character CommentStrings correctly from to MC: handle '//' correctly in AsmLexer::isAtStartOfComment().
Jul 19 2014, 2:19 PM

Jul 17 2014

jannau updated the diff for D4279: MC: support different sized constants in constant pools.

new patch with added since someone needs to commit it for me

Jul 17 2014, 3:50 PM · deleted
jannau updated the diff for D4279: MC: support different sized constants in constant pools.

updated patch adding the \param comment

Jul 17 2014, 1:07 PM · deleted

Jul 15 2014

jannau updated the diff for D4279: MC: support different sized constants in constant pools.

all review comments addressed.

Jul 15 2014, 2:34 AM · deleted

Jul 14 2014

jannau updated D4279: MC: support different sized constants in constant pools.
Jul 14 2014, 1:03 AM · deleted
jannau updated the diff for D4279: MC: support different sized constants in constant pools.

adds error when a constant expression is too large for an 32-bit register

Jul 14 2014, 12:58 AM · deleted

Jul 12 2014

jannau abandoned D4278: AArch64: use 32bit registers in ldr-pseudo.s tests.

I will change and squash this patch into http://reviews.llvm.org/D4279

Jul 12 2014, 11:10 AM · deleted

Jun 24 2014

jannau retitled D4279: MC: support different sized constants in constant pools from to MC: support different sized constants in constant pools.
Jun 24 2014, 2:44 PM · deleted
jannau retitled D4278: AArch64: use 32bit registers in ldr-pseudo.s tests from to AArch64: use 32bit registers in ldr-pseudo.s tests.
Jun 24 2014, 2:42 PM · deleted
jannau updated the diff for D4206: aarch64: support target-specific .req assembler directive.

removed tabs used for indent crept in due editor misconfiguration

Jun 24 2014, 2:38 PM
jannau updated the diff for D4206: aarch64: support target-specific .req assembler directive.

rebased on top of r211605 - "Implement pseudo LDR <reg>, =<literal/label> for AArch64"

Jun 24 2014, 11:27 AM
jannau updated the diff for D4206: aarch64: support target-specific .req assembler directive.

addressed all review comments

Jun 24 2014, 3:23 AM

Jun 20 2014

jannau updated the diff for D4206: aarch64: support target-specific .req assembler directive.

All review comments not individually commented on should be addressed

Jun 20 2014, 2:39 AM

Jun 19 2014

jannau retitled D4206: aarch64: support target-specific .req assembler directive from to aarch64: support target-specific .req assembler directive.
Jun 19 2014, 12:28 AM