Page MenuHomePhabricator

jamesduley (James Duley)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 7 2017, 4:22 AM (136 w, 6 d)

Recent Activity

Jul 14 2017

jamesduley added inline comments to D31220: [builtins][ARM] Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA.
Jul 14 2017, 1:46 AM

Jul 10 2017

jamesduley added a comment to D31220: [builtins][ARM] Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA.

@weimingz, what's the current status of this patch? Currently, AFAIK, there is one place where incorrect code is generated without these fixes because it depends on the size of the code generated, that is BLOCK_SIZE in udivsi3.S when compiled with -march=armv6 -marm (see https://github.com/rust-lang-nursery/compiler-builtins/issues/173).

Jul 10 2017, 1:25 AM

Jun 20 2017

jamesduley closed D34401: [SelectionDAG] Fix UMULO fallback.

Closed by rL305800

Jun 20 2017, 9:14 AM
jamesduley added a comment to D34401: [SelectionDAG] Fix UMULO fallback.

Looks good to me.

Jun 20 2017, 7:49 AM
jamesduley added reviewers for D34401: [SelectionDAG] Fix UMULO fallback: rengolin, john.brawn, ab.
Jun 20 2017, 6:40 AM
jamesduley created D34401: [SelectionDAG] Fix UMULO fallback.
Jun 20 2017, 6:35 AM

Apr 26 2017

jamesduley added a comment to D31807: Fix signed multiplication with overflow fallback..
In D31807#738030, @rs wrote:

Looks fine, I think it's ready to land. Do you have commit access ? If not do you want me to commit on your behalf ?

Apr 26 2017, 6:42 AM

Apr 13 2017

jamesduley added a comment to D31807: Fix signed multiplication with overflow fallback..

Looks like this should already be exercised by test/CodeGen/ARM/umulo-32.ll; I'd say remove that file entirely.

Apr 13 2017, 10:19 AM
jamesduley updated the diff for D31807: Fix signed multiplication with overflow fallback..

removed unnamed_addr

Apr 13 2017, 10:16 AM

Apr 7 2017

jamesduley created D31807: Fix signed multiplication with overflow fallback..
Apr 7 2017, 6:04 AM