Page MenuHomePhabricator

jacksonfellows (Jackson Fellows)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 17 2021, 11:49 AM (5 w, 6 d)

Recent Activity

Jan 21 2021

jacksonfellows updated the diff for D95105: Implement constant folding for PowFOp.

Add BF16 to allowed FP types

Jan 21 2021, 11:31 AM · Restricted Project
jacksonfellows updated the diff for D95105: Implement constant folding for PowFOp.

Add lit tests for powf constant folding.

Jan 21 2021, 10:43 AM · Restricted Project
jacksonfellows updated the diff for D95105: Implement constant folding for PowFOp.

Add check to only fold the pow of halfs, floats, and doubles.

Jan 21 2021, 10:19 AM · Restricted Project

Jan 20 2021

jacksonfellows added a comment to D95105: Implement constant folding for PowFOp.

Since MLIR is also handling tensors and vectors, I'm not entirely sure how this check would be implemented (i.e. the operands can't always be cast to FloatAttr). The function constFoldBinaryOp currently handles these cases, so we'd have to re-implement some of that logic. Does someone with more experience with the existing folders have any good ideas about this?

Jan 20 2021, 5:17 PM · Restricted Project
jacksonfellows added a comment to D95105: Implement constant folding for PowFOp.

As far as I can tell they would lose precision on the conversion. It seems like LLVM avoids this by only folding halfs, floats, and doubles. We could do the same by checking the operand types first, which is probably the right solution.

Jan 20 2021, 5:09 PM · Restricted Project
jacksonfellows added a comment to D95105: Implement constant folding for PowFOp.

Can you add a lit test for this?

Jan 20 2021, 4:36 PM · Restricted Project
jacksonfellows requested review of D95105: Implement constant folding for PowFOp.
Jan 20 2021, 4:22 PM · Restricted Project

Jan 19 2021

jacksonfellows added a comment to D94939: Implement constant folding for DivFOp.

I do not have commit access (first-time contributor). Would a reviewer be able to commit this change?

Jan 19 2021, 11:55 AM · Restricted Project

Jan 18 2021

jacksonfellows requested review of D94939: Implement constant folding for DivFOp.
Jan 18 2021, 7:11 PM · Restricted Project