Page MenuHomePhabricator

ivafanas (Afanasyev Ivan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2019, 10:59 PM (89 w, 2 d)

Recent Activity

Jul 27 2020

ivafanas added a comment to D83851: [Docs] remove unused arguments in documentation examples on vectorization passes.

Thank you!

Jul 27 2020, 3:30 AM · Restricted Project

Jul 26 2020

ivafanas added a comment to D83851: [Docs] remove unused arguments in documentation examples on vectorization passes.

Could please anybody commit this changeset?
I'm not allowed to commit to llvm repo.

Jul 26 2020, 8:55 PM · Restricted Project

Jul 16 2020

ivafanas added a comment to D83851: [Docs] remove unused arguments in documentation examples on vectorization passes.

Could you please help to commit this changeset?
I'm not authorized to commit to llvm repo.

Jul 16 2020, 9:58 PM · Restricted Project

Jul 14 2020

Herald added a project to D83851: [Docs] remove unused arguments in documentation examples on vectorization passes: Restricted Project.
Jul 14 2020, 10:58 PM · Restricted Project

Mar 5 2020

ivafanas added inline comments to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.
Mar 5 2020, 8:13 AM · Restricted Project
ivafanas added inline comments to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.
Mar 5 2020, 7:40 AM · Restricted Project

Mar 4 2020

ivafanas added inline comments to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.
Mar 4 2020, 11:15 AM · Restricted Project

Jul 13 2019

ivafanas added a comment to D64515: [libcxx] fix cxx-benchmarks target compilation.

make cxx-benchmarks work for me, can you please explain what compiler you're using and exactly how you get the error?

Jul 13 2019, 3:20 AM

Jul 10 2019

ivafanas created D64515: [libcxx] fix cxx-benchmarks target compilation.
Jul 10 2019, 10:23 AM

Jul 8 2019

ivafanas added a comment to D64341: [libcxx] speedup to_string for floating point numbers.

I would like to hold this for a while; because in a few weeks, we should have an implementation of to_chars for floating point - which we may be able to use in to_string (like we did for the integral types).

Jul 8 2019, 9:27 PM
ivafanas added reviewers for D64341: [libcxx] speedup to_string for floating point numbers: mclow.lists, ed.
Jul 8 2019, 7:53 AM
ivafanas created D64341: [libcxx] speedup to_string for floating point numbers.
Jul 8 2019, 7:49 AM

Jun 9 2019

ivafanas added inline comments to D63047: [libc++] Fix leading zeros in std::to_chars.
Jun 9 2019, 12:22 AM · Restricted Project
ivafanas updated the diff for D63047: [libc++] Fix leading zeros in std::to_chars.

Code review issues are adressed

Jun 9 2019, 12:18 AM · Restricted Project

Jun 8 2019

ivafanas added a comment to D63047: [libc++] Fix leading zeros in std::to_chars.

The example in the bug doesn't work: std::to_chars(buf, buf + 100, (unsigned long)0xffffffff).

Edit: it outputs 0004294967295.

Jun 8 2019, 11:22 AM · Restricted Project
ivafanas created D63047: [libc++] Fix leading zeros in std::to_chars.
Jun 8 2019, 7:20 AM · Restricted Project

Jun 6 2019

ivafanas added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Vlad, yes, you are right, std::to_chars produce unexpected result for the specific range of values.

Jun 6 2019, 8:43 AM · Restricted Project
ivafanas added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Understood, I will have a look on that.
Thanks.

Jun 6 2019, 12:58 AM · Restricted Project

Jun 5 2019

ivafanas added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Thank you!!

Jun 5 2019, 9:42 PM · Restricted Project

Jun 4 2019

ivafanas added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Can I help with testing / integration?
It seems like a forgotten review.

Jun 4 2019, 10:20 AM · Restricted Project

May 1 2019

ivafanas added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

This is looking much better to me. I'll run some tests later today and confirm.

May 1 2019, 2:00 AM · Restricted Project

Apr 21 2019

ivafanas added a reviewer for D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO: ldionne.

Could anyone please review this diff?

Apr 21 2019, 8:57 PM · Restricted Project

Apr 2 2019

ivafanas added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Hi Marshall,

Apr 2 2019, 8:17 AM · Restricted Project

Apr 1 2019

ivafanas updated the diff for D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Removed struct initial_string template arguments for integers, they are not needed anymore

Apr 1 2019, 4:04 AM · Restricted Project

Mar 28 2019

ivafanas updated the diff for D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Simplified version is uploaded.
Yes, it is significantly shorter and cleaner.
Thank you!

Mar 28 2019, 9:45 AM · Restricted Project

Mar 23 2019

ivafanas updated the diff for D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

return back memcpy, it is faster for long integers in about 10%

Mar 23 2019, 7:47 PM · Restricted Project
ivafanas updated the diff for D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Diff from the corrected clang version is uploaded

Mar 23 2019, 11:26 AM · Restricted Project
ivafanas updated the diff for D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

to_string via to_chars implementation is ready.

Mar 23 2019, 11:20 AM · Restricted Project

Mar 21 2019

ivafanas added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Now that revision 356585 has landed, we can use std::to_chars to implement to_string

I would suggest something like (untested code):

template <class T>
string __to_chars(T t)
{
char buf[numeric_limits<T>::digits10() + 3]; // +1 for '-' +1 for nul, and +1 for extra
to_chars_result res(buf, buf + sizeof(buf), t, 10);
return string(buf, res.ptr);
}

and then call *that* from the various to_string implementations.

Mar 21 2019, 8:44 AM · Restricted Project

Mar 20 2019

ivafanas added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Now that revision 356585 has landed, we can use std::to_chars to implement to_string

I would suggest something like (untested code):

template <class T>
string __to_chars(T t)
{
char buf[numeric_limits<T>::digits10() + 3]; // +1 for '-' +1 for nul, and +1 for extra
to_chars_result res(buf, buf + sizeof(buf), t, 10);
return string(buf, res.ptr);
}

and then call *that* from the various to_string implementations.

Mar 20 2019, 11:58 AM · Restricted Project
ivafanas accepted D59598: Make the `<charconv>` header usable with C++11.
Mar 20 2019, 10:16 AM
ivafanas added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Could you please help me to complete this pull request.

Mar 20 2019, 2:38 AM · Restricted Project

Mar 17 2019

ivafanas added inline comments to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.
Mar 17 2019, 10:19 AM · Restricted Project
ivafanas updated the diff for D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Updated to_string implementation for integer types. Naive algorithm is used.

Mar 17 2019, 10:05 AM · Restricted Project

Mar 13 2019

ivafanas added inline comments to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.
Mar 13 2019, 10:22 AM · Restricted Project

Mar 11 2019

ivafanas added inline comments to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.
Mar 11 2019, 1:19 AM · Restricted Project

Mar 9 2019

ivafanas added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Code correctness was checked via

Mar 9 2019, 11:27 AM · Restricted Project
ivafanas created D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.
Mar 9 2019, 11:20 AM · Restricted Project