User Details
User Details
- User Since
- Apr 28 2016, 10:02 PM (361 w, 18 h)
Oct 26 2022
Oct 26 2022
ishitatsuyuki updated the diff for D133658: [Support] Use find() for faster StringRef::count..
Restore behavior when Str == "" and add TODO
ishitatsuyuki added inline comments to D133658: [Support] Use find() for faster StringRef::count..
ishitatsuyuki updated the diff for D133658: [Support] Use find() for faster StringRef::count..
Restore check for zero N
Oct 21 2022
Oct 21 2022
ishitatsuyuki added a comment to D133658: [Support] Use find() for faster StringRef::count..
Looks like this still hasn't been committed. Can anyone help me commit this (as I don't have commiter rights)?
Oct 1 2022
Oct 1 2022
ishitatsuyuki added a comment to D133660: [Support] Add fast path for StringRef::find with needle of length 2..
Ping, can anyone commit this?
Sep 21 2022
Sep 21 2022
ishitatsuyuki added a comment to D133660: [Support] Add fast path for StringRef::find with needle of length 2..
I don’t have commit rights, so can anyone commit this and https://reviews.llvm.org/D133658?
Sep 18 2022
Sep 18 2022
ishitatsuyuki added inline comments to D133660: [Support] Add fast path for StringRef::find with needle of length 2..
ishitatsuyuki updated the diff for D133660: [Support] Add fast path for StringRef::find with needle of length 2..
Use a simplified implementation for clarity.
Sep 11 2022
Sep 11 2022
ishitatsuyuki added a comment to D133658: [Support] Use find() for faster StringRef::count..
The split is done; the second revision is D133660.
ishitatsuyuki added a comment to D133660: [Support] Add fast path for StringRef::find with needle of length 2..
(Carried over from D133658)
ishitatsuyuki retitled D133658: [Support] Use find() for faster StringRef::count. from [Support] Optimize StringRef::count,find. to [Support] Use find() for faster StringRef::count..
ishitatsuyuki added a reviewer for D133660: [Support] Add fast path for StringRef::find with needle of length 2.: chandlerc.
ishitatsuyuki updated the diff for D133658: [Support] Use find() for faster StringRef::count..
Split revision; this becomes the first revision (StringRef::count).
ishitatsuyuki added a comment to D133658: [Support] Use find() for faster StringRef::count..
A note that the N=2 search code is mostly mirrored from glibc; I believe it's short enough to not cause copyright issues but please let me know if I should be more defensive here.
ishitatsuyuki retitled D133658: [Support] Use find() for faster StringRef::count. from [Support] Use find() for faster StringRef::count. to [Support] Optimize StringRef::count,find..
ishitatsuyuki requested review of D133658: [Support] Use find() for faster StringRef::count..