Page MenuHomePhabricator
People ishaangandhi

ishaangandhi (Ishaan Gandhi)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 22 2022, 7:32 AM (10 w, 1 d)

Recent Activity
View All

Yesterday

ishaangandhi added a comment to D128402: [clang-tidy] Don't treat invalid branches as identical.

Ishaan Gandhi
ishaangandhi AT gmail DOT com

Fri, Jul 1, 5:30 PM · Restricted Project, Restricted Project

Thu, Jun 30

ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.
Thu, Jun 30, 1:50 PM · Restricted Project, Restricted Project

Wed, Jun 29

ishaangandhi added a comment to D128402: [clang-tidy] Don't treat invalid branches as identical.

I remember now, @njames93 :

Wed, Jun 29, 7:25 PM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.

Remove -fix-errors

Wed, Jun 29, 3:57 PM · Restricted Project, Restricted Project

Tue, Jun 28

ishaangandhi added a comment to D128402: [clang-tidy] Don't treat invalid branches as identical.

Does anybody on this thread have land permissions? If not, would anyone know who to tag?

Tue, Jun 28, 1:59 PM · Restricted Project, Restricted Project

Mon, Jun 27

ishaangandhi added a comment to D128402: [clang-tidy] Don't treat invalid branches as identical.

@LegalizeAdulthood Thanks! I don't have commit rights to the repository, can you commit it on my behalf?

Mon, Jun 27, 11:43 AM · Restricted Project, Restricted Project

Sun, Jun 26

ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.
Sun, Jun 26, 8:41 AM · Restricted Project, Restricted Project

Thu, Jun 23

ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.

Alphabetize some more

Thu, Jun 23, 7:26 PM · Restricted Project, Restricted Project
ishaangandhi added inline comments to D128402: [clang-tidy] Don't treat invalid branches as identical.
Thu, Jun 23, 1:20 PM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.

Change doc path

Thu, Jun 23, 12:35 PM · Restricted Project, Restricted Project
ishaangandhi added inline comments to D128402: [clang-tidy] Don't treat invalid branches as identical.
Thu, Jun 23, 11:54 AM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.

Alphabetize release notes

Thu, Jun 23, 11:53 AM · Restricted Project, Restricted Project
ishaangandhi added inline comments to D128402: [clang-tidy] Don't treat invalid branches as identical.
Thu, Jun 23, 8:58 AM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.

Use auto instead of Expr and llvm::cast instead of llvm::dyn_cast.

Thu, Jun 23, 6:08 AM · Restricted Project, Restricted Project
ishaangandhi added inline comments to D128402: [clang-tidy] Don't treat invalid branches as identical.
Thu, Jun 23, 6:05 AM · Restricted Project, Restricted Project
ishaangandhi added inline comments to D128402: [clang-tidy] Don't treat invalid branches as identical.
Thu, Jun 23, 6:03 AM · Restricted Project, Restricted Project

Wed, Jun 22

ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.
Wed, Jun 22, 7:30 PM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.

Include error: in error line

Wed, Jun 22, 7:21 PM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.

Check for error messages in test case

Wed, Jun 22, 6:13 PM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.

Move test to new file with -fix-errors flag

Wed, Jun 22, 5:58 PM · Restricted Project, Restricted Project
ishaangandhi added reviewers for D128402: [clang-tidy] Don't treat invalid branches as identical: hokein, aaron.ballman.
Wed, Jun 22, 5:30 PM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.

Rebased

Wed, Jun 22, 5:27 PM · Restricted Project, Restricted Project
ishaangandhi requested review of D128402: [clang-tidy] Don't treat invalid branches as identical.
Wed, Jun 22, 5:16 PM · Restricted Project, Restricted Project

Apr 25 2022

ishaangandhi added a comment to D124262: compile commands header to source heuristic lower-cases filenames before inferring file types.
In D124262#3472079, @sammccall wrote:

Thanks!
I can land this for you if you don't have commit access - can you provide the name/email to use for the commit?

Apr 25 2022, 9:40 AM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D124262: compile commands header to source heuristic lower-cases filenames before inferring file types.

Made test case reflect that proxies for ".H" files are ".C" files, and not ".c files".

Apr 25 2022, 8:02 AM · Restricted Project, Restricted Project
ishaangandhi added inline comments to D124262: compile commands header to source heuristic lower-cases filenames before inferring file types.
Apr 25 2022, 7:59 AM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D124262: compile commands header to source heuristic lower-cases filenames before inferring file types.
Apr 25 2022, 7:49 AM · Restricted Project, Restricted Project
ishaangandhi added a comment to D124262: compile commands header to source heuristic lower-cases filenames before inferring file types.

Test case added, re-diffed with -U9999, and removed redundant constructor. Thanks for the quick feedback, @sammccall!

Apr 25 2022, 7:45 AM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D124262: compile commands header to source heuristic lower-cases filenames before inferring file types.
  • Added a test case
  • Removed redundant "StringRef" constructor
Apr 25 2022, 7:42 AM · Restricted Project, Restricted Project

Apr 22 2022

ishaangandhi changed the visibility for D124262: compile commands header to source heuristic lower-cases filenames before inferring file types.
Apr 22 2022, 8:58 AM · Restricted Project, Restricted Project
ishaangandhi changed the visibility for D124262: compile commands header to source heuristic lower-cases filenames before inferring file types.
Apr 22 2022, 7:37 AM · Restricted Project, Restricted Project
ishaangandhi requested review of D124262: compile commands header to source heuristic lower-cases filenames before inferring file types.
Apr 22 2022, 7:36 AM · Restricted Project, Restricted Project