Page MenuHomePhabricator

inho9606 (Inho Seo)
UserEmail Not Verified

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2021, 11:11 PM (8 w, 6 d)

Recent Activity

Thu, Apr 29

inho9606 added a comment to D101026: Update static bound checker for Linalg to cover decreasing cases.

Uh, I think I found a case that this solution can't check, which does not have its maximum and minimum indices with the start and end indices. For example, if the affine_map is <(d0, d1) -> (d1 - d0)> and the ranges of d0 and d1 are 0 and 1, then this expression has
0 when d0 is 0 and d1 is 0,
1 when d0 is 0 and d1 is 1,
-1 when d0 is 1 and d1 is 0,
0 when d0 is 1 and d1 is 1.
I wanted to share this case.. And I think we should substitude
the maximum values for negative dims, and the minimum values for positive dims in order to get the real minimum indices. For the maximum indices, we need the minimum values for negative dims, and the maximum values for positive dims..

I never see this kind of statement before, and I highly suspect that this will be the case. For now, let's treat it as invalid. We can revert it if this is really the case in the future.

Thu, Apr 29, 12:42 AM · Restricted Project

Wed, Apr 28

inho9606 added a comment to D101026: Update static bound checker for Linalg to cover decreasing cases.

There are conflicts, could you rebase and fix it?

Ah, I can't see the conflicts in my repository.. Rebase was successfully done. Could you tell me what files have conflicts?
Thanks

I can not patch this, and the bot can not do it either. If you rebase successfully, you can update the patch. arc will ask you to provide some description and update the patch I think.

Wed, Apr 28, 6:36 PM · Restricted Project
inho9606 updated the diff for D101026: Update static bound checker for Linalg to cover decreasing cases.
  1. Updating D101026: Update static bound checker for Linalg to cover decreasing cases #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Rebased for merge?

Wed, Apr 28, 6:34 PM · Restricted Project

Tue, Apr 27

inho9606 added a comment to D101026: Update static bound checker for Linalg to cover decreasing cases.

There are conflicts, could you rebase and fix it?

Tue, Apr 27, 7:56 PM · Restricted Project

Mon, Apr 26

inho9606 updated the diff for D101026: Update static bound checker for Linalg to cover decreasing cases.
  1. Updating D101026: Update static bound checker for Linalg to cover decreasing cases #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Moved declaring a variable and updated the error message

Mon, Apr 26, 7:50 PM · Restricted Project
inho9606 added a comment to D101026: Update static bound checker for Linalg to cover decreasing cases.

Uh, I think I found a case that this solution can't check, which does not have its maximum and minimum indices with the start and end indices. For example, if the affine_map is <(d0, d1) -> (d1 - d0)> and the ranges of d0 and d1 are 0 and 1, then this expression has
0 when d0 is 0 and d1 is 0,
1 when d0 is 0 and d1 is 1,
-1 when d0 is 1 and d1 is 0,
0 when d0 is 1 and d1 is 1.
I wanted to share this case, and wonder if this expression is invalid or it can be possible..?

Mon, Apr 26, 7:48 PM · Restricted Project

Sun, Apr 25

inho9606 updated the diff for D101026: Update static bound checker for Linalg to cover decreasing cases.
  1. Updating D101026: Update static bound checker for Linalg to cover decreasing cases #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Renamed variables, fixed the logic for dimsize 0, and fixed an invalid testcase.

Sun, Apr 25, 7:34 PM · Restricted Project

Fri, Apr 23

inho9606 added inline comments to D101026: Update static bound checker for Linalg to cover decreasing cases.
Fri, Apr 23, 2:56 AM · Restricted Project

Thu, Apr 22

inho9606 updated the diff for D101026: Update static bound checker for Linalg to cover decreasing cases.
  1. Updating D101026: Update static bound checker for Linalg to cover decreasing cases #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Reflected the comments and added invalid test cases.

Thu, Apr 22, 11:33 PM · Restricted Project
inho9606 added inline comments to D101026: Update static bound checker for Linalg to cover decreasing cases.
Thu, Apr 22, 11:30 PM · Restricted Project
inho9606 requested review of D101026: Update static bound checker for Linalg to cover decreasing cases.
Thu, Apr 22, 12:49 AM · Restricted Project

Mar 25 2021

inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

I think this version is more reasonable comparing to other cases

Mar 25 2021, 6:11 PM · Restricted Project
inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Rebased the patch to the top of tree, and fixed one test in tile-and-fuse-tensors

Mar 25 2021, 5:59 PM · Restricted Project
inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Fixed clang-format issue

Mar 25 2021, 4:01 AM · Restricted Project
inho9606 added inline comments to D98390: Added static verification for Linalg Ops..
Mar 25 2021, 3:53 AM · Restricted Project
inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Fixed wierd comment.. and fixed minor style

Mar 25 2021, 3:48 AM · Restricted Project

Mar 23 2021

inho9606 added inline comments to D98390: Added static verification for Linalg Ops..
Mar 23 2021, 8:50 PM · Restricted Project
inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Updated code style and comments..
Added an invalid testcase.

Mar 23 2021, 8:49 PM · Restricted Project
inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Check complicated cases; pass if indices are in-of-bound of shapes.

Mar 23 2021, 3:13 AM · Restricted Project

Mar 19 2021

inho9606 added inline comments to D98390: Added static verification for Linalg Ops..
Mar 19 2021, 2:08 AM · Restricted Project
inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Applied LLVM style and fixed comments

Mar 19 2021, 2:03 AM · Restricted Project

Mar 18 2021

inho9606 added inline comments to D98390: Added static verification for Linalg Ops..
Mar 18 2021, 9:14 PM · Restricted Project
inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Updated some comments and code styles

Mar 18 2021, 9:06 PM · Restricted Project
inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Applied rebase to top

Mar 18 2021, 5:30 AM · Restricted Project
inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Applied clang-format to LinalgInterfaces.cpp

Mar 18 2021, 12:53 AM · Restricted Project
inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Added ignoring case that has zero as it's laast inferred accessing index.

Mar 18 2021, 12:35 AM · Restricted Project

Mar 15 2021

inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Removed comments and changed variable names

Mar 15 2021, 3:04 AM · Restricted Project
inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Updated verification condition, and fixed some more testcases

Mar 15 2021, 2:53 AM · Restricted Project

Mar 14 2021

inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Added invalid op in invalid.mlir

Mar 14 2021, 8:18 PM · Restricted Project

Mar 12 2021

inho9606 added inline comments to D98390: Added static verification for Linalg Ops..
Mar 12 2021, 7:57 AM · Restricted Project
inho9606 added inline comments to D98390: Added static verification for Linalg Ops..
Mar 12 2021, 7:45 AM · Restricted Project
inho9606 added inline comments to D98390: Added static verification for Linalg Ops..
Mar 12 2021, 12:57 AM · Restricted Project

Mar 11 2021

inho9606 updated the diff for D98390: Added static verification for Linalg Ops..
  1. Updating D98390: Added static verification for Linalg Ops. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Reflected small code styles

Mar 11 2021, 6:36 PM · Restricted Project
inho9606 added inline comments to D98390: Added static verification for Linalg Ops..
Mar 11 2021, 6:29 PM · Restricted Project

Mar 10 2021

inho9606 requested review of D98390: Added static verification for Linalg Ops..
Mar 10 2021, 9:00 PM · Restricted Project
inho9606 updated the diff for D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
  1. Updating D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Reverted the test file

Mar 10 2021, 2:27 AM · Restricted Project
inho9606 updated the diff for D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
  1. Updating D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

reformating

Mar 10 2021, 2:12 AM · Restricted Project

Mar 9 2021

inho9606 updated the diff for D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
  1. Updating D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment

Changed -1 to ShapedType::kDynamicSize in comment

Mar 9 2021, 4:39 PM · Restricted Project
inho9606 added inline comments to D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 9 2021, 2:01 AM · Restricted Project
inho9606 updated the diff for D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
  1. Updating D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Reflected request changes

Mar 9 2021, 1:51 AM · Restricted Project

Mar 8 2021

inho9606 added inline comments to D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 8 2021, 6:49 PM · Restricted Project
inho9606 updated subscribers of D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.

Uh,, Sorry I removed @ftynse from subscribers,, but don't know why it happened..

Mar 8 2021, 6:19 PM · Restricted Project
inho9606 updated subscribers of D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.

Please provide a rationale for making this change in the commit description. Why is it necessary? Is there any op that will customize the behavior and why can't it do so by overloading the functions instead?

Mar 8 2021, 6:11 PM · Restricted Project
inho9606 retitled D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification from #Enter a commit message. # Moved fectored getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 8 2021, 6:08 PM · Restricted Project
inho9606 updated the diff for D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
  1. Updating D98163: #Enter a commit message. # Moved fectored getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

Moved getStaticShape and getStaticLoopRanges method to Linalg Generlization Hooks part.n LinalgInterfaces.td
This is to use these methods in LinalgInterfaces.cpp for additional static shape verification to match the shapes and loops. If I used existing methods, circular dependency issue happened. Now we can use the methods with linalgOp.getStaticLoopRanges().

Mar 8 2021, 5:58 PM · Restricted Project

Mar 7 2021

inho9606 requested review of D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 7 2021, 11:56 PM · Restricted Project