Page MenuHomePhabricator

ijan1 (Ivan Zhechev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 28 2021, 6:56 AM (69 w, 6 d)

Recent Activity

Oct 4 2021

ijan1 requested review of D111042: [flang][flang-omp-report] Add flang-omp-report summarising script.
Oct 4 2021, 1:54 AM · Restricted Project, Restricted Project

Sep 29 2021

ijan1 accepted D110682: [Flang] Fix failing plugin tests.

LGTM. Thanks for the fix.

Sep 29 2021, 1:26 AM · Restricted Project, Restricted Project

Sep 28 2021

ijan1 committed rG38c42d42eb3f: Flang OpenMP Report Plugin (authored by stuartellis).
Flang OpenMP Report Plugin
Sep 28 2021, 2:57 PM
ijan1 closed D109890: Flang OpenMP Report Plugin.
Sep 28 2021, 2:57 PM · Restricted Project, Restricted Project

Sep 24 2021

ijan1 updated the diff for D109890: Flang OpenMP Report Plugin.

Thanks a lot for the feedback, it's easy to miss such silly mistakes.

Sep 24 2021, 5:38 AM · Restricted Project, Restricted Project
ijan1 updated the summary of D109890: Flang OpenMP Report Plugin.
Sep 24 2021, 5:35 AM · Restricted Project, Restricted Project

Sep 23 2021

ijan1 updated the summary of D109890: Flang OpenMP Report Plugin.
Sep 23 2021, 6:18 AM · Restricted Project, Restricted Project
ijan1 added inline comments to D109890: Flang OpenMP Report Plugin.
Sep 23 2021, 3:05 AM · Restricted Project, Restricted Project
ijan1 updated the diff for D109890: Flang OpenMP Report Plugin.

Thanks a lot for the feedback! I've changed accordingly to use -o now. Hopefully I got the header guards right this time.

Sep 23 2021, 2:45 AM · Restricted Project, Restricted Project

Sep 22 2021

ijan1 added inline comments to D109890: Flang OpenMP Report Plugin.
Sep 22 2021, 4:53 AM · Restricted Project, Restricted Project
ijan1 updated the summary of D109890: Flang OpenMP Report Plugin.
Sep 22 2021, 4:51 AM · Restricted Project, Restricted Project
ijan1 updated the diff for D109890: Flang OpenMP Report Plugin.

Thanks for the feedback. Updated accordingly.

Sep 22 2021, 4:40 AM · Restricted Project, Restricted Project

Sep 21 2021

ijan1 changed the visibility for D109890: Flang OpenMP Report Plugin.
Sep 21 2021, 7:08 AM · Restricted Project, Restricted Project
ijan1 updated the diff for D109890: Flang OpenMP Report Plugin.

Thanks for the feedback! I am still working on some of the things you've pointed out, however I have managed to add tests.
Unfortunately, since the plugin outputs a file with the same name every time, this causes some of the tests to fail because they're ran in parallel.
I will have a patch which adds the source file's name to the one generated by the plugin so that there\' a unique file each time.

Sep 21 2021, 3:39 AM · Restricted Project, Restricted Project

Sep 16 2021

ijan1 changed the visibility for D109890: Flang OpenMP Report Plugin.
Sep 16 2021, 11:24 AM · Restricted Project, Restricted Project
ijan1 changed the visibility for D109890: Flang OpenMP Report Plugin.
Sep 16 2021, 8:23 AM · Restricted Project, Restricted Project
ijan1 requested review of D109890: Flang OpenMP Report Plugin.
Sep 16 2021, 8:23 AM · Restricted Project, Restricted Project

Sep 6 2021

ijan1 committed rGdc453dcf760e: [Flang] Port test_modfile.sh to Python (authored by ijan1).
[Flang] Port test_modfile.sh to Python
Sep 6 2021, 6:58 AM
ijan1 closed D107956: [Flang] Port test_modfile.sh to Python.
Sep 6 2021, 6:57 AM · Restricted Project
ijan1 retitled D107956: [Flang] Port test_modfile.sh to Python from [Flang] Ported test_modfile.sh to Python to [Flang] Port test_modfile.sh to Python.
Sep 6 2021, 6:56 AM · Restricted Project
ijan1 committed rG93c3e765ac99: [Flang] Port test_folding.sh to Python (authored by ijan1).
[Flang] Port test_folding.sh to Python
Sep 6 2021, 6:55 AM
ijan1 closed D108217: [Flang] Port test_folding.sh to Python.
Sep 6 2021, 6:55 AM · Restricted Project
ijan1 updated the summary of D108217: [Flang] Port test_folding.sh to Python.
Sep 6 2021, 6:54 AM · Restricted Project
ijan1 added a comment to D107956: [Flang] Port test_modfile.sh to Python.

@Meinersbur is this one ready to be merged also?

Sep 6 2021, 1:21 AM · Restricted Project
ijan1 added a comment to D108217: [Flang] Port test_folding.sh to Python.

@Meinersbur is this one ready to be merged?

Sep 6 2021, 1:21 AM · Restricted Project
ijan1 committed rG6c1ac141d3c9: [Flang] Ported test_errors.sh to Python (authored by ijan1).
[Flang] Ported test_errors.sh to Python
Sep 6 2021, 1:20 AM
ijan1 closed D107575: [Flang] Ported test_errors.sh to Python.
Sep 6 2021, 1:20 AM · Restricted Project

Sep 3 2021

ijan1 updated the summary of D107575: [Flang] Ported test_errors.sh to Python.
Sep 3 2021, 6:25 AM · Restricted Project
ijan1 updated the diff for D108217: [Flang] Port test_folding.sh to Python.

Rebase to mollify buildbots.

Sep 3 2021, 6:25 AM · Restricted Project
ijan1 updated the diff for D107956: [Flang] Port test_modfile.sh to Python.

Rebased to mollify buildbots.

Sep 3 2021, 6:23 AM · Restricted Project
ijan1 updated the diff for D107575: [Flang] Ported test_errors.sh to Python.

Rebased to stop a Clang test failure from some other change in main.

Sep 3 2021, 6:19 AM · Restricted Project
ijan1 updated the diff for D108217: [Flang] Port test_folding.sh to Python.

Re-enabling some tests.

Sep 3 2021, 3:24 AM · Restricted Project
ijan1 updated the diff for D107956: [Flang] Port test_modfile.sh to Python.

Re-enabling tests on Windows.

Sep 3 2021, 2:53 AM · Restricted Project
ijan1 updated the diff for D107575: [Flang] Ported test_errors.sh to Python.

Rebased to add support for new tests and also see if "resolve67.f90" passes the test.

Sep 3 2021, 2:22 AM · Restricted Project

Sep 2 2021

ijan1 added a comment to D108623: [flang] Fix non-deterministic line output function.

Commenting so that my inline comment shows.

Sep 2 2021, 12:36 PM · Restricted Project
ijan1 accepted D109108: [flang] Use CMake to determine endianness..

This fixed the issue, I checked and none of the tests fail now. Thanks a ton.
LGTM.

Sep 2 2021, 12:25 PM · Restricted Project, Restricted Project
ijan1 committed rGe962718dd5fc: [flang] Fix non-deterministic line output function (authored by ijan1).
[flang] Fix non-deterministic line output function
Sep 2 2021, 8:14 AM
ijan1 closed D108623: [flang] Fix non-deterministic line output function.
Sep 2 2021, 8:14 AM · Restricted Project

Sep 1 2021

ijan1 committed rG5a3a12661829: [Flang] test_symbols.py module file fix (authored by ijan1).
[Flang] test_symbols.py module file fix
Sep 1 2021, 7:03 AM
ijan1 closed D107953: [Flang] test_symbols.py module file fix.
Sep 1 2021, 7:03 AM · Restricted Project
ijan1 updated the summary of D107956: [Flang] Port test_modfile.sh to Python.
Sep 1 2021, 2:56 AM · Restricted Project
ijan1 updated the summary of D108217: [Flang] Port test_folding.sh to Python.
Sep 1 2021, 2:44 AM · Restricted Project
ijan1 updated the diff for D108217: [Flang] Port test_folding.sh to Python.

Rebased to include newly added tests.

Sep 1 2021, 2:44 AM · Restricted Project
ijan1 updated the diff for D108623: [flang] Fix non-deterministic line output function.

Using braced initialisation for the lambda.

Sep 1 2021, 1:01 AM · Restricted Project

Aug 25 2021

ijan1 updated the diff for D108623: [flang] Fix non-deterministic line output function.

Updating to use braced initialisation, removed parentheses in the return statement and converted the captures into lambda parameters.

Aug 25 2021, 7:11 AM · Restricted Project
ijan1 added a comment to D108217: [Flang] Port test_folding.sh to Python.

@Meinersbur would it be fine to also disable these failings tests on Windows? I have filed a bug report on bugzilla[1] for D107956. I could include them there or file a new one.

Aug 25 2021, 3:27 AM · Restricted Project
ijan1 updated the diff for D107956: [Flang] Port test_modfile.sh to Python.

Updated to disable the 2 failing tests on Windows and also filed a bug report in bugzilla.

Aug 25 2021, 3:25 AM · Restricted Project

Aug 24 2021

ijan1 requested review of D108623: [flang] Fix non-deterministic line output function.
Aug 24 2021, 4:53 AM · Restricted Project

Aug 19 2021

ijan1 updated the diff for D108217: [Flang] Port test_folding.sh to Python.

Specified encoding to fix a failing test on Windows.

Aug 19 2021, 8:09 AM · Restricted Project
ijan1 added a comment to D107041: [Flang] Ported test_symbols to Python.

Thanks, that fixes the weird diff formatting. But why are all of the spaces removed?

Aug 19 2021, 2:11 AM · Restricted Project, Restricted Project
ijan1 added a comment to D107954: Make test_symbols.py compare files line-by-line.

@Meinersbur is this ready to be merged?

Aug 19 2021, 1:15 AM · Restricted Project

Aug 18 2021

ijan1 updated the diff for D107575: [Flang] Ported test_errors.sh to Python.

Rebased and added support for 3 new tests.

Aug 18 2021, 8:19 AM · Restricted Project
ijan1 updated the diff for D108217: [Flang] Port test_folding.sh to Python.

Hopefully fixes the few failing tests due to a regex issue.

Aug 18 2021, 8:18 AM · Restricted Project
ijan1 added a comment to D107956: [Flang] Port test_modfile.sh to Python.

Would it be fine for me to disable to failing tests for now and have them re-enabled with the fix?

Aug 18 2021, 7:06 AM · Restricted Project

Aug 17 2021

ijan1 added a comment to D108217: [Flang] Port test_folding.sh to Python.

"folding21.f90" was added a few days ago and fails in all cases. It's not been set as "XFAIL" so I am unsure if that's something on my end.

Aug 17 2021, 10:12 AM · Restricted Project
ijan1 requested review of D108217: [Flang] Port test_folding.sh to Python.
Aug 17 2021, 10:11 AM · Restricted Project
ijan1 updated the diff for D107953: [Flang] test_symbols.py module file fix.

Updated to use tempfile.TemporaryDirectory. Addressed comments by Andrzej.

Aug 17 2021, 8:00 AM · Restricted Project
ijan1 added a comment to D107954: Make test_symbols.py compare files line-by-line.

Makes a lot of sense, but I would rephrase the summary a bit. Basically, you are making sure here that you are comparing the files line by line rather than the whole thing at a time. By making sure that the comparison is done line-by-line, you also make the output much nicer. Perhaps:

Aug 17 2021, 2:40 AM · Restricted Project
ijan1 retitled D107954: Make test_symbols.py compare files line-by-line from [Flang] test_symbols.py formatting fix to Make test_symbols.py compare files line-by-line.
Aug 17 2021, 2:39 AM · Restricted Project
ijan1 added a comment to D107575: [Flang] Ported test_errors.sh to Python.

The evaluation order is indeed undefined for operators except || and &&. I suggest to store the results in a variables. Them being part of a if-else will require some restructuring.

Aug 17 2021, 1:57 AM · Restricted Project
ijan1 added a comment to D107956: [Flang] Port test_modfile.sh to Python.

Would you like me to look at why "modfile18.f90" and "modfile20.f90" are failing?

Aug 17 2021, 1:56 AM · Restricted Project
ijan1 updated the diff for D107954: Make test_symbols.py compare files line-by-line.

Updated to use join with unified_diff.

Aug 17 2021, 1:53 AM · Restricted Project

Aug 16 2021

ijan1 updated the diff for D107956: [Flang] Port test_modfile.sh to Python.

Fixed modfile09.f90 failing. Updated to use the tempfile library. Using Python-style docstrings now.

Aug 16 2021, 4:30 AM · Restricted Project

Aug 12 2021

ijan1 updated the summary of D107956: [Flang] Port test_modfile.sh to Python.
Aug 12 2021, 7:52 AM · Restricted Project
ijan1 added a comment to D107953: [Flang] test_symbols.py module file fix.

Is there a reason to use lit's suggestion for a temporary directory instead using tempfile.TemporaryDirectory or tempfile.mkdtemp?

Aug 12 2021, 7:50 AM · Restricted Project
ijan1 added a comment to D107956: [Flang] Port test_modfile.sh to Python.

Is the failure of modfile09.f90 related to D107953?

Aug 12 2021, 7:15 AM · Restricted Project
ijan1 updated the diff for D107575: [Flang] Ported test_errors.sh to Python.

"resolve12.f90" and "resolve26.f90" have been fixed. Addressed feedback from Andrzej.

Aug 12 2021, 5:01 AM · Restricted Project
ijan1 requested review of D107956: [Flang] Port test_modfile.sh to Python.
Aug 12 2021, 4:59 AM · Restricted Project
ijan1 updated the summary of D107954: Make test_symbols.py compare files line-by-line.
Aug 12 2021, 1:55 AM · Restricted Project
ijan1 updated the summary of D107954: Make test_symbols.py compare files line-by-line.
Aug 12 2021, 1:55 AM · Restricted Project
ijan1 requested review of D107954: Make test_symbols.py compare files line-by-line.
Aug 12 2021, 1:54 AM · Restricted Project
ijan1 requested review of D107953: [Flang] test_symbols.py module file fix.
Aug 12 2021, 1:51 AM · Restricted Project

Aug 10 2021

ijan1 updated the diff for D107654: [Flang] Fix error messages on Windows..

Changed to be less intrusive.

Aug 10 2021, 8:28 AM · Restricted Project

Aug 6 2021

ijan1 updated the diff for D107041: [Flang] Ported test_symbols to Python.

Fixed a bug in a test file. And also updated the scripts to use docstrings instead of normal comments.

Aug 6 2021, 9:48 AM · Restricted Project, Restricted Project
ijan1 updated the summary of D107575: [Flang] Ported test_errors.sh to Python.
Aug 6 2021, 8:48 AM · Restricted Project
ijan1 updated the summary of D107654: [Flang] Fix error messages on Windows..
Aug 6 2021, 8:47 AM · Restricted Project
ijan1 requested review of D107654: [Flang] Fix error messages on Windows..
Aug 6 2021, 8:45 AM · Restricted Project

Aug 5 2021

ijan1 added a comment to D107575: [Flang] Ported test_errors.sh to Python.

There seems to be a problem in how import common not finding common.py in a sibling directory.

Aug 5 2021, 11:55 AM · Restricted Project
ijan1 retitled D107575: [Flang] Ported test_errors.sh to Python from Ported test_errors.sh to Python to [Flang] Ported test_errors.sh to Python.
Aug 5 2021, 11:53 AM · Restricted Project
ijan1 updated the summary of D107575: [Flang] Ported test_errors.sh to Python.
Aug 5 2021, 8:39 AM · Restricted Project
ijan1 updated the summary of D107575: [Flang] Ported test_errors.sh to Python.
Aug 5 2021, 8:38 AM · Restricted Project
ijan1 updated the summary of D107575: [Flang] Ported test_errors.sh to Python.
Aug 5 2021, 8:31 AM · Restricted Project
ijan1 requested review of D107575: [Flang] Ported test_errors.sh to Python.
Aug 5 2021, 8:22 AM · Restricted Project
ijan1 updated the diff for D107041: [Flang] Ported test_symbols to Python.

Incorporating feedback from Kiran and Andrzej.

Aug 5 2021, 8:08 AM · Restricted Project, Restricted Project

Aug 2 2021

ijan1 updated the diff for D107041: [Flang] Ported test_symbols to Python.

Changes for more idiomatic python.

Aug 2 2021, 2:43 AM · Restricted Project, Restricted Project

Jul 30 2021

ijan1 updated the diff for D107041: [Flang] Ported test_symbols to Python.

Incorporated Michael's feedback into a small patch.

Jul 30 2021, 9:34 AM · Restricted Project, Restricted Project

Jul 29 2021

ijan1 retitled D107041: [Flang] Ported test_symbols to Python from Ported test_symbols to Python to [Flang] Ported test_symbols to Python.
Jul 29 2021, 12:56 AM · Restricted Project, Restricted Project
ijan1 updated the summary of D107041: [Flang] Ported test_symbols to Python.
Jul 29 2021, 12:52 AM · Restricted Project, Restricted Project
ijan1 removed reviewers for D107041: [Flang] Ported test_symbols to Python: sscalpone, clementval, jdoerfert.
Jul 29 2021, 12:42 AM · Restricted Project, Restricted Project
ijan1 requested review of D107041: [Flang] Ported test_symbols to Python.
Jul 29 2021, 12:41 AM · Restricted Project, Restricted Project