Page MenuHomePhabricator

idlecode (Paweł Żukowski)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2016, 10:15 AM (248 w, 1 d)

Recent Activity

Aug 7 2017

idlecode added a comment to D30748: [Lexer] Finding beginning of token with escaped new line.

I don't have commit rights yet so I would be grateful for help in this matter :)

Aug 7 2017, 10:57 AM
idlecode updated the diff for D30748: [Lexer] Finding beginning of token with escaped new line.

Redability fix in findBeginningOfLine

Aug 7 2017, 10:57 AM

Aug 4 2017

idlecode updated the diff for D30748: [Lexer] Finding beginning of token with escaped new line.

Applied clang-format

Aug 4 2017, 8:35 AM
idlecode updated the diff for D30748: [Lexer] Finding beginning of token with escaped new line.
Aug 4 2017, 8:08 AM
idlecode added inline comments to D30748: [Lexer] Finding beginning of token with escaped new line.
Aug 4 2017, 8:07 AM

Jun 10 2017

idlecode updated the diff for D30748: [Lexer] Finding beginning of token with escaped new line.

Added tests for isNewLineEscaped - this fixed some corner cases

Jun 10 2017, 5:41 AM

May 9 2017

idlecode added a comment to D30748: [Lexer] Finding beginning of token with escaped new line.

Oh, sorry about this - I forgot. I will send patch during this weekend

May 9 2017, 11:54 PM

Mar 20 2017

idlecode planned changes to D30748: [Lexer] Finding beginning of token with escaped new line.
Mar 20 2017, 1:42 AM

Mar 11 2017

idlecode updated the diff for D30748: [Lexer] Finding beginning of token with escaped new line.

Addressed Alexander's comments

Mar 11 2017, 3:37 AM
idlecode added inline comments to D30748: [Lexer] Finding beginning of token with escaped new line.
Mar 11 2017, 3:36 AM

Mar 8 2017

idlecode created D30748: [Lexer] Finding beginning of token with escaped new line.
Mar 8 2017, 10:29 AM

Feb 16 2017

idlecode closed D29724: [Driver] Report available language standards on user error.

Committed as r295113

Feb 16 2017, 6:17 AM

Feb 15 2017

idlecode created D30002: [clang-tidy] Fix handling of methods with try-statement as a body in modernize-use-override.
Feb 15 2017, 11:20 AM · Restricted Project

Feb 11 2017

idlecode added a comment to D29724: [Driver] Report available language standards on user error.

Yes, please.
Thanks for you time :)

Feb 11 2017, 9:28 PM
idlecode updated the diff for D29724: [Driver] Report available language standards on user error.

Addressed Richard's inline comment.

Feb 11 2017, 12:54 PM
idlecode updated the diff for D29724: [Driver] Report available language standards on user error.

Displayed standards will now match processed file kind

Feb 11 2017, 11:23 AM

Feb 10 2017

idlecode added a comment to D29724: [Driver] Report available language standards on user error.

Indeed, thanks :)
I ran make check-all and had no errors so I thought there are no tests.

Feb 10 2017, 11:42 AM
idlecode updated the diff for D29724: [Driver] Report available language standards on user error.

Added test, changed printout style a bit (but this still needs to be checked)

Feb 10 2017, 11:42 AM

Feb 8 2017

idlecode created D29724: [Driver] Report available language standards on user error.
Feb 8 2017, 11:21 AM

Feb 6 2017

idlecode accepted D29267: [clang-tidy] safety-no-assembler.

Sure, but I don't have commit rights so someone else have to push it :)

Feb 6 2017, 12:08 PM · Restricted Project
idlecode added a comment to D29267: [clang-tidy] safety-no-assembler.

LGTM. HIC++ Standard seems worth implementing.

Feb 6 2017, 3:55 AM · Restricted Project

Feb 4 2017

idlecode requested changes to D28235: [clang-format cleanup] merge continuous deleted lines into one deletion..

Few other tests (ChangeNamespaceTest from extra repository) require update too.

Feb 4 2017, 10:09 AM
idlecode added inline comments to D28235: [clang-format cleanup] merge continuous deleted lines into one deletion..
Feb 4 2017, 8:20 AM
idlecode added inline comments to D29267: [clang-tidy] safety-no-assembler.
Feb 4 2017, 2:17 AM · Restricted Project
idlecode added inline comments to D29393: [clang-tidy] Don't warn about call to unresolved operator*.
Feb 4 2017, 12:37 AM

Feb 3 2017

idlecode added a comment to D29267: [clang-tidy] safety-no-assembler.

Standard you linked mentions portability as the reason inline assembler should be avoided. Should it really be named 'safety'?

Feb 3 2017, 11:16 AM · Restricted Project
idlecode added inline comments to D29393: [clang-tidy] Don't warn about call to unresolved operator*.
Feb 3 2017, 10:16 AM

Nov 6 2016

idlecode added inline comments to D26332: Add a user-defined literal for StringRef.
Nov 6 2016, 4:46 AM

Nov 3 2016

idlecode added a comment to D25439: Fixed column shift when formatting line containing bit shift operators.

No, not yet - I was about to ask someone to commit this for me :)

Nov 3 2016, 9:26 AM

Nov 1 2016

idlecode updated the diff for D26125: [clang-tidy] Fixed readability-else-after-return for cascade statements.

I have reverted matcher to the state before https://reviews.llvm.org/D23265 (tests are passing with compoundStmt instead of stmt and this way is better than mine).

Nov 1 2016, 11:29 AM
idlecode added inline comments to rL278257: [clang-tidy] enhance readability-else-after-return.
Nov 1 2016, 10:51 AM

Oct 30 2016

idlecode added a comment to D26125: [clang-tidy] Fixed readability-else-after-return for cascade statements.

@mgehre: Yes it does - in your case AST looks like ifStmt(b) - CompoundStmt - ifStmt(c), so ifStmt's don't have direct parent-child relations.
But there is another problem:

while(a)
  if (b)
    return 1;
  else
    doSomething(2);

In such case, generated fix (with and without this fix) will change semantics of program.
As @djasper suggested, I need to take a look at this check history and update patch accordingly.

Oct 30 2016, 1:01 PM
idlecode planned changes to D26125: [clang-tidy] Fixed readability-else-after-return for cascade statements.
Oct 30 2016, 10:37 AM
idlecode added inline comments to D26125: [clang-tidy] Fixed readability-else-after-return for cascade statements.
Oct 30 2016, 9:38 AM
idlecode added inline comments to D26125: [clang-tidy] Fixed readability-else-after-return for cascade statements.
Oct 30 2016, 8:31 AM
idlecode retitled D26125: [clang-tidy] Fixed readability-else-after-return for cascade statements from to [clang-tidy] Fixed else-after-return warning in cascade if statement.
Oct 30 2016, 1:30 AM

Oct 24 2016

idlecode updated the diff for D25439: Fixed column shift when formatting line containing bit shift operators.
Oct 24 2016, 1:08 PM
idlecode added a comment to D25439: Fixed column shift when formatting line containing bit shift operators.

Thanks for pointing it out, just a minute ago I found a proper document mentioning it (I have no idea how I could miss it).
I hope to be more use in future :)

Oct 24 2016, 1:06 PM

Oct 12 2016

idlecode updated the diff for D25439: Fixed column shift when formatting line containing bit shift operators.
Oct 12 2016, 11:57 AM

Oct 11 2016

idlecode added a comment to D25439: Fixed column shift when formatting line containing bit shift operators.

Sure, I will upload diff as soon as I test it

Oct 11 2016, 10:40 AM

Oct 10 2016

idlecode updated D25439: Fixed column shift when formatting line containing bit shift operators.
Oct 10 2016, 10:16 AM
idlecode added a reviewer for D25439: Fixed column shift when formatting line containing bit shift operators: mprobst.
Oct 10 2016, 10:03 AM
idlecode retitled D25439: Fixed column shift when formatting line containing bit shift operators from to Fixed column shift when formatting line containing bit shift operators.
Oct 10 2016, 10:02 AM