- User Since
- May 24 2016, 10:15 AM (248 w, 1 d)
Aug 7 2017
I don't have commit rights yet so I would be grateful for help in this matter :)
Redability fix in findBeginningOfLine
Aug 4 2017
Jun 10 2017
Added tests for isNewLineEscaped - this fixed some corner cases
May 9 2017
Oh, sorry about this - I forgot. I will send patch during this weekend
Mar 20 2017
Mar 11 2017
Addressed Alexander's comments
Mar 8 2017
Feb 16 2017
Committed as r295113
Feb 15 2017
Feb 11 2017
Thanks for you time :)
Addressed Richard's inline comment.
Displayed standards will now match processed file kind
Feb 10 2017
Indeed, thanks :)
I ran make check-all and had no errors so I thought there are no tests.
Added test, changed printout style a bit (but this still needs to be checked)
Feb 8 2017
Feb 6 2017
Sure, but I don't have commit rights so someone else have to push it :)
LGTM. HIC++ Standard seems worth implementing.
Feb 4 2017
Few other tests (ChangeNamespaceTest from extra repository) require update too.
Feb 3 2017
Standard you linked mentions portability as the reason inline assembler should be avoided. Should it really be named 'safety'?
Nov 6 2016
Nov 3 2016
No, not yet - I was about to ask someone to commit this for me :)
Nov 1 2016
I have reverted matcher to the state before https://reviews.llvm.org/D23265 (tests are passing with compoundStmt instead of stmt and this way is better than mine).
Oct 30 2016
@mgehre: Yes it does - in your case AST looks like ifStmt(b) - CompoundStmt - ifStmt(c), so ifStmt's don't have direct parent-child relations.
But there is another problem:
while(a) if (b) return 1; else doSomething(2);
In such case, generated fix (with and without this fix) will change semantics of program.
As @djasper suggested, I need to take a look at this check history and update patch accordingly.
Oct 24 2016
Thanks for pointing it out, just a minute ago I found a proper document mentioning it (I have no idea how I could miss it).
I hope to be more use in future :)
Oct 12 2016
Oct 11 2016
Sure, I will upload diff as soon as I test it