Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

iamlouk (Lou)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 26 2022, 6:30 AM (39 w, 6 d)

Recent Activity

Fri, Sep 29

iamlouk updated the diff for D157371: [VPlan] Support interleaving for outer-loop vectorization.

Rebase and update

Fri, Sep 29, 1:58 PM · Restricted Project, Restricted Project
iamlouk updated the diff for D157484: [VPlan] Support scalable vectors in outer-loop vectorization.

Rebase and add comment on VF selection.

Fri, Sep 29, 1:25 PM · Restricted Project, Restricted Project

Fri, Sep 8

iamlouk added a comment to D157484: [VPlan] Support scalable vectors in outer-loop vectorization.

That sounds like a good first step, can you share a patch for that?

Fri, Sep 8, 1:34 AM · Restricted Project, Restricted Project

Aug 31 2023

iamlouk requested review of D159288: [WIP] Improved VPlan-native Path.
Aug 31 2023, 8:02 AM · Restricted Project, Restricted Project
iamlouk added a comment to D157484: [VPlan] Support scalable vectors in outer-loop vectorization.

Looks reasonable overall, my only concern is that this adds another codepath to the native path which is already lacking test coverage in general. Do you have any idea/suggestion on how to improve end-to-end test coverage, e.g. in llvm-test-suite (could be adding some SingleSource tests with loop nests and #pragma clang loop vectorize_width(4)?

Aug 31 2023, 2:21 AM · Restricted Project, Restricted Project
iamlouk updated the diff for D157484: [VPlan] Support scalable vectors in outer-loop vectorization.

Add check for optimization remarks and rejection of scalable VFs on targets without scalable vectors.

Aug 31 2023, 2:09 AM · Restricted Project, Restricted Project

Aug 28 2023

iamlouk updated the diff for D157484: [VPlan] Support scalable vectors in outer-loop vectorization.

Fix clang-format

Aug 28 2023, 10:00 PM · Restricted Project, Restricted Project
iamlouk updated the diff for D157484: [VPlan] Support scalable vectors in outer-loop vectorization.

Rebase

Aug 28 2023, 5:45 AM · Restricted Project, Restricted Project
iamlouk updated the diff for D157484: [VPlan] Support scalable vectors in outer-loop vectorization.

Rebase and add call to reportVectorizationFailure()

Aug 28 2023, 4:15 AM · Restricted Project, Restricted Project

Aug 16 2023

iamlouk added a comment to D157371: [VPlan] Support interleaving for outer-loop vectorization.

Please let me know if there is anything I can improve.

Aug 16 2023, 11:44 PM · Restricted Project, Restricted Project
iamlouk added a comment to D157368: [VPlan] Consider scalar VF in masked VPReductionRecipe.

Please let me know if there is anything else I can improve.

Aug 16 2023, 11:44 PM · Restricted Project, Restricted Project

Aug 9 2023

iamlouk added a comment to D149479: [LV] Enable scalable outer loop vectorization.

iamlouk this patch addressed 3 different problems: outerloop vectorization for scalable vectors; vec-report for outerloop and stability fix for outerloop; As fhahn suggested, I split last 2 into their own review: D150696 and D150700.
I assume your approach to enable outerloop vectorization for scalable vectors is more generic than mine adhoc approach here, so can you please post your patch instead ?

Aug 9 2023, 2:33 AM · Restricted Project, Restricted Project
iamlouk requested review of D157484: [VPlan] Support scalable vectors in outer-loop vectorization.
Aug 9 2023, 2:25 AM · Restricted Project, Restricted Project
iamlouk added inline comments to D157368: [VPlan] Consider scalar VF in masked VPReductionRecipe.
Aug 9 2023, 1:18 AM · Restricted Project, Restricted Project
iamlouk updated the diff for D157368: [VPlan] Consider scalar VF in masked VPReductionRecipe.

Address code review comments: use mtriple and check full IR

Aug 9 2023, 1:05 AM · Restricted Project, Restricted Project

Aug 8 2023

iamlouk added reviewers for D157368: [VPlan] Consider scalar VF in masked VPReductionRecipe: fhahn, Ayal, ABataev, nikolaypanchenko.
Aug 8 2023, 7:33 AM · Restricted Project, Restricted Project
iamlouk removed reviewers for D157368: [VPlan] Consider scalar VF in masked VPReductionRecipe: fhahn, Ayal, ABataev, nikolaypanchenko.
Aug 8 2023, 7:31 AM · Restricted Project, Restricted Project
iamlouk updated the diff for D157368: [VPlan] Consider scalar VF in masked VPReductionRecipe.

Remove unnecessary attributes in test.

Aug 8 2023, 7:29 AM · Restricted Project, Restricted Project
iamlouk updated the diff for D157368: [VPlan] Consider scalar VF in masked VPReductionRecipe.

Fix clang-format issue.

Aug 8 2023, 2:11 AM · Restricted Project, Restricted Project
iamlouk added a comment to D149479: [LV] Enable scalable outer loop vectorization.

@nikolaypanchenko, thank you for this patch! Sorry to bother you, but will you update the revision (to support scalable vectorization factors)? I have written a patch myself with the same intention (although it works slightly differently, I also modified determineVPlanVF), not knowing that this revision already exists, so if you do not have the resources for this at the moment, I could present an alternative one, but only if you are ok with that of course.

Aug 8 2023, 1:08 AM · Restricted Project, Restricted Project
iamlouk added reviewers for D157371: [VPlan] Support interleaving for outer-loop vectorization: fhahn, Ayal, ABataev.
Aug 8 2023, 1:06 AM · Restricted Project, Restricted Project
iamlouk requested review of D157371: [VPlan] Support interleaving for outer-loop vectorization.
Aug 8 2023, 1:02 AM · Restricted Project, Restricted Project
iamlouk retitled D157368: [VPlan] Consider scalar VF in masked VPReductionRecipe from Consider scalar VF in masked VPReductionRecipe to [VPlan] Consider scalar VF in masked VPReductionRecipe.
Aug 8 2023, 12:49 AM · Restricted Project, Restricted Project
iamlouk requested review of D157368: [VPlan] Consider scalar VF in masked VPReductionRecipe.
Aug 8 2023, 12:46 AM · Restricted Project, Restricted Project

Jul 5 2023

iamlouk abandoned D149848: [AArch64, compiler-rt] Implement trampoline intrinsics.

Thank you for your feedback compnerd. Changing the implementation to mimic GCC's way of handling it's equivalent of this intrinsic requires a completely new approach though, so I am abandoning this revision.

Jul 5 2023, 11:34 AM · Restricted Project, Restricted Project, Restricted Project

Jun 28 2023

iamlouk added inline comments to D149848: [AArch64, compiler-rt] Implement trampoline intrinsics.
Jun 28 2023, 2:15 AM · Restricted Project, Restricted Project, Restricted Project

May 15 2023

iamlouk updated the diff for D149848: [AArch64, compiler-rt] Implement trampoline intrinsics.

Rebase and Windows on AArch64 treatment

May 15 2023, 12:53 AM · Restricted Project, Restricted Project, Restricted Project

May 7 2023

iamlouk added inline comments to D149848: [AArch64, compiler-rt] Implement trampoline intrinsics.
May 7 2023, 11:37 PM · Restricted Project, Restricted Project, Restricted Project

May 4 2023

iamlouk added reviewers for D149848: [AArch64, compiler-rt] Implement trampoline intrinsics: compnerd, t.p.northover.
May 4 2023, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
iamlouk requested review of D149848: [AArch64, compiler-rt] Implement trampoline intrinsics.
May 4 2023, 6:52 AM · Restricted Project, Restricted Project, Restricted Project