- User Since
- May 6 2020, 2:40 AM (37 w, 6 d)
Sep 2 2020
@ldionne Thanks! Could you commit it for me (hyd-dev <email@example.com>)?
Update the test to use #if defineds and #error.
Aug 31 2020
Add a test (libcxx/test/libcxx/libcpp_freestanding.sh.cpp).
Aug 17 2020
Jun 18 2020
I don't have commit access. @njames93 Could you please commit it for me (hyd-dev <firstname.lastname@example.org>)? Thanks!
Jun 10 2020
Address the comment: remove PathSize from BuiltinBitCastExpr's constructor and assert() it == 0.
If this is OK, please commit it with --author "hyd-dev <email@example.com>". Thanks.
Jun 8 2020
May 21 2020
Fix typos in the summary.
May 20 2020
Format builtin-bit-cast.cpp and make it simpler.
May 19 2020
May 10 2020
The standard output is always piped to FileCheck's standard input. It will never become "a terminal that supports color".
Standard error is not redirected explicitly, but it is not used to detect color support.
Would a test case be needed?
clang::tidy::clangTidyMain() shows that clang-tidy reports all diagnostics by clang::tidy::handleErrors(), which constructs a clang::tidy::(anonymous namespace)::ErrorReporter, no matter where they come from, so I think a test case is not required.
Not a fan of this test case as it only demonstrates the color behaviour of the process running the check not the actual option itself
What does "option itself" mean?
Fair point, will this option also control the color of the diagnostics emitted by clang or just clang tidy specific diagnostics?
This option sets DiagOpts->ShowColors to true. As I known, it controls all diagnostics reported by the clang-tidy program (by clang::tidy::(anonymous namespace)::ErrorReporter), including clang-diagnostic-* and other clang-tidy checks.
May 8 2020
None of the clang-tidy command line options are prefixed with -f.
This command line option used to be --color-diagnostics, but I've followed @hokein's advice to change it to --use-color.
If you mean to use the -fcolor-diagnostics option from compile_commands.json, clang-tidy and clang are two separate tools. The users may not want them to share the same setting, because they may invoke them in different environments.
Change incorrect detect to detected in the comment of UseColor option.
May 7 2020
Say the --use-color command line option overrides the UseColor option in .clang-tidy file in its help text.
May 6 2020
Rename clang-tools-extra/test/clang-tidy/infrastructure/color-diagnostics.cpp to use-color.cpp.
Address the comments above.
I also removed the incorrect DefaultOptions.ColorDiagnostics = ColorDiagnostics in ClangTidyMain.cpp. That produces incorrect UseColor: false with -dump-config.