Page MenuHomePhabricator

hyd-dev
User

Projects

User does not belong to any projects.

User Details

User Since
May 6 2020, 2:40 AM (37 w, 6 d)

Recent Activity

Sep 2 2020

hyd-dev added a comment to D86055: [libc++] Fix the wrong usage of __STDC_HOSTED__.

@ldionne Thanks! Could you commit it for me (hyd-dev <yd-huang@outlook.com>)?

Sep 2 2020, 9:19 AM · Restricted Project
hyd-dev updated the diff for D86055: [libc++] Fix the wrong usage of __STDC_HOSTED__.

Update the test to use #if defineds and #error.

Sep 2 2020, 1:37 AM · Restricted Project
hyd-dev added inline comments to D86055: [libc++] Fix the wrong usage of __STDC_HOSTED__.
Sep 2 2020, 1:00 AM · Restricted Project

Aug 31 2020

hyd-dev updated the diff for D86055: [libc++] Fix the wrong usage of __STDC_HOSTED__.

Add a test (libcxx/test/libcxx/libcpp_freestanding.sh.cpp).

Aug 31 2020, 4:31 AM · Restricted Project

Aug 17 2020

hyd-dev requested review of D86055: [libc++] Fix the wrong usage of __STDC_HOSTED__.
Aug 17 2020, 4:05 AM · Restricted Project

Jun 18 2020

hyd-dev added a comment to D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

I don't have commit access. @njames93 Could you please commit it for me (hyd-dev <yd-huang@outlook.com>)? Thanks!

Jun 18 2020, 7:34 AM · Restricted Project, Restricted Project
hyd-dev added a comment to D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

Ping?

Jun 18 2020, 6:29 AM · Restricted Project, Restricted Project

Jun 10 2020

hyd-dev updated the diff for D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.

Address the comment: remove PathSize from BuiltinBitCastExpr's constructor and assert() it == 0.

Jun 10 2020, 2:41 AM · Restricted Project
hyd-dev added a comment to D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.

If this is OK, please commit it with --author "hyd-dev <yd-huang@outlook.com>". Thanks.

Jun 10 2020, 2:41 AM · Restricted Project

Jun 8 2020

hyd-dev added a comment to D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.

Ping?

Jun 8 2020, 9:56 AM · Restricted Project
hyd-dev added a comment to D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

Ping?

Jun 8 2020, 9:56 AM · Restricted Project, Restricted Project

May 21 2020

hyd-dev updated the summary of D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.
May 21 2020, 9:08 AM · Restricted Project, Restricted Project
hyd-dev added a comment to D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

Fix typos in the summary.

May 21 2020, 9:08 AM · Restricted Project, Restricted Project
hyd-dev updated the summary of D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.
May 21 2020, 9:08 AM · Restricted Project, Restricted Project
hyd-dev updated the summary of D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.
May 21 2020, 12:31 AM · Restricted Project

May 20 2020

hyd-dev updated the diff for D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.

Format builtin-bit-cast.cpp and make it simpler.

May 20 2020, 11:58 PM · Restricted Project
hyd-dev created D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.
May 20 2020, 11:06 PM · Restricted Project
hyd-dev updated the summary of D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.
May 20 2020, 11:06 PM · Restricted Project
hyd-dev updated the summary of D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.
May 20 2020, 11:06 PM · Restricted Project

May 19 2020

hyd-dev added a comment to D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

Any reply?

May 19 2020, 1:03 AM · Restricted Project, Restricted Project

May 10 2020

hyd-dev added a comment to D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

What I mean to say is, if the behaviour of the testing environment changes to pipe the result to a terminal that supports color, it could cause this test case to also fail.

The standard output is always piped to FileCheck's standard input. It will never become "a terminal that supports color".
Standard error is not redirected explicitly, but it is not used to detect color support.

May 10 2020, 9:17 PM · Restricted Project, Restricted Project
hyd-dev added a comment to D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

Would a test case be needed?

clang::tidy::clangTidyMain() shows that clang-tidy reports all diagnostics by clang::tidy::handleErrors(), which constructs a clang::tidy::(anonymous namespace)::ErrorReporter, no matter where they come from, so I think a test case is not required.

Not a fan of this test case as it only demonstrates the color behaviour of the process running the check not the actual option itself

What does "option itself" mean?

May 10 2020, 8:30 AM · Restricted Project, Restricted Project
hyd-dev added a comment to D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

Fair point, will this option also control the color of the diagnostics emitted by clang or just clang tidy specific diagnostics?

This option sets DiagOpts->ShowColors to true. As I known, it controls all diagnostics reported by the clang-tidy program (by clang::tidy::(anonymous namespace)::ErrorReporter), including clang-diagnostic-* and other clang-tidy checks.

May 10 2020, 6:55 AM · Restricted Project, Restricted Project

May 8 2020

hyd-dev added a comment to D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

None of the clang-tidy command line options are prefixed with -f.
This command line option used to be --color-diagnostics, but I've followed @hokein's advice to change it to --use-color.
If you mean to use the -fcolor-diagnostics option from compile_commands.json, clang-tidy and clang are two separate tools. The users may not want them to share the same setting, because they may invoke them in different environments.

May 8 2020, 10:00 PM · Restricted Project, Restricted Project
hyd-dev updated the diff for D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

Change incorrect detect to detected in the comment of UseColor option.

May 8 2020, 9:37 AM · Restricted Project, Restricted Project

May 7 2020

hyd-dev added inline comments to D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.
May 7 2020, 11:57 PM · Restricted Project, Restricted Project
hyd-dev updated the diff for D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

Say the --use-color command line option overrides the UseColor option in .clang-tidy file in its help text.

May 7 2020, 11:57 PM · Restricted Project, Restricted Project

May 6 2020

hyd-dev updated the diff for D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

Rename clang-tools-extra/test/clang-tidy/infrastructure/color-diagnostics.cpp to use-color.cpp.

May 6 2020, 9:35 PM · Restricted Project, Restricted Project
hyd-dev updated the diff for D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.

Address the comments above.
I also removed the incorrect DefaultOptions.ColorDiagnostics = ColorDiagnostics in ClangTidyMain.cpp. That produces incorrect UseColor: false with -dump-config.

May 6 2020, 9:01 PM · Restricted Project, Restricted Project
hyd-dev updated the summary of D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.
May 6 2020, 4:48 AM · Restricted Project, Restricted Project
hyd-dev retitled D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics from [clang-tidy] Add --color-diagnostics option to control colors in diagnostics to [clang-tidy] Add --color-diagnostics command line option and ColorDiagnostics option to control colors in diagnostics.
May 6 2020, 4:48 AM · Restricted Project, Restricted Project
hyd-dev removed a project from D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics: Restricted Project.
May 6 2020, 4:16 AM · Restricted Project, Restricted Project
hyd-dev edited projects for D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics, added: Restricted Project; removed Restricted Project.
May 6 2020, 4:16 AM · Restricted Project, Restricted Project
hyd-dev created D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics.
May 6 2020, 4:16 AM · Restricted Project, Restricted Project