Page MenuHomePhabricator

hxy9243 (Kevin Hu)
A happy little geek

Projects

User does not belong to any projects.

User Details

User Since
Dec 10 2015, 8:55 PM (200 w, 5 d)

Recent Activity

Jan 16 2017

hxy9243 committed rL292184: [Test patch] Inline hot functions in libcxx shared_ptr.
[Test patch] Inline hot functions in libcxx shared_ptr
Jan 16 2017, 6:57 PM
hxy9243 closed D24991: Inline hot functions in libcxx shared_ptr implementation. by committing rL292184: [Test patch] Inline hot functions in libcxx shared_ptr.
Jan 16 2017, 6:57 PM
hxy9243 updated the diff for D24991: Inline hot functions in libcxx shared_ptr implementation..

Addresses comments from @mclow.lists.

Jan 16 2017, 9:03 AM
hxy9243 updated the diff for D24991: Inline hot functions in libcxx shared_ptr implementation..

Addresses comments from @EricWF.

Jan 16 2017, 8:16 AM

Jan 11 2017

hxy9243 updated the diff for D24991: Inline hot functions in libcxx shared_ptr implementation..

Adresses comments from @kubabrecka: minor changes on function names. Rename __libcpp_atomic_* to __libcpp_atomic_refcount_*.

Jan 11 2017, 11:32 AM

Jan 10 2017

hxy9243 added a comment to D24991: Inline hot functions in libcxx shared_ptr implementation..

Addressed previous issues in the comments. The patch still shows consistent perf uplift in proprietary benchmark on shared_ptr.

Jan 10 2017, 2:40 PM

Jan 3 2017

hxy9243 updated the diff for D24991: Inline hot functions in libcxx shared_ptr implementation..

Minor fix, remove redundant inlines.

Jan 3 2017, 3:04 PM
hxy9243 updated the diff for D24991: Inline hot functions in libcxx shared_ptr implementation..

Move the header back in its place, and only copy over necessary parts. Now call __atomic_add_fetch from inside the functions.

Jan 3 2017, 2:59 PM
hxy9243 commandeered D24991: Inline hot functions in libcxx shared_ptr implementation..
Jan 3 2017, 2:54 PM

Nov 15 2016

hxy9243 added a comment to D24991: Inline hot functions in libcxx shared_ptr implementation..

Ping. @mclow.lists, @EricWF, any ideas on this patch?
Thanks very much!

Nov 15 2016, 8:32 AM

Nov 7 2016

hxy9243 added a comment to D24991: Inline hot functions in libcxx shared_ptr implementation..
In D24991#586248, @kubabrecka wrote:

I just ran ninja check-all with and without this patch and there are no regressions in compiler-rt on an x86_64-linux machine.

The TSan interceptors (and testcases) are Darwin-only at this point. I'll run the tests on my machine.

Nov 7 2016, 3:00 PM

Oct 31 2016

hxy9243 accepted D24991: Inline hot functions in libcxx shared_ptr implementation..

Looks good to me.
Notice that the performance gain can only be observed when compiled with the updated C++ header files.

Oct 31 2016, 12:35 PM

Oct 12 2016

hxy9243 added a comment to D24991: Inline hot functions in libcxx shared_ptr implementation..

Thanks for pointing out. It's true that it may cause ABI breakage. It would be nice to keep compatibility while getting the performance benefits from inlining.

Oct 12 2016, 3:17 PM

Oct 3 2016

hxy9243 updated the diff for D24991: Inline hot functions in libcxx shared_ptr implementation..

Addresses comments from @halyavin, rename "atomic_support.h" to "__atomic_support" to avoid collisions with application headers.

Oct 3 2016, 9:28 AM

Sep 27 2016

hxy9243 retitled D24991: Inline hot functions in libcxx shared_ptr implementation. from to Inline hot functions in libcxx shared_ptr implementation..
Sep 27 2016, 3:51 PM
hxy9243 added a comment to D24033: Convert clamp into fmaxnum/fminnum pairs..

Ping agian. Thanks in advance for the reviews.

Sep 27 2016, 3:36 PM

Sep 19 2016

hxy9243 added a comment to D24033: Convert clamp into fmaxnum/fminnum pairs..

Ping. Are there any updates on this? Thanks very much.

Sep 19 2016, 4:09 PM

Sep 12 2016

hxy9243 added inline comments to D24033: Convert clamp into fmaxnum/fminnum pairs..
Sep 12 2016, 12:49 PM
hxy9243 updated the diff for D24033: Convert clamp into fmaxnum/fminnum pairs..

Address comments from @arsenm.

Sep 12 2016, 12:46 PM

Sep 9 2016

hxy9243 added a comment to D24033: Convert clamp into fmaxnum/fminnum pairs..

Ping. Are there any updates or thoughts on this patch? Thanks.

Sep 9 2016, 1:18 PM

Aug 30 2016

hxy9243 retitled D24033: Convert clamp into fmaxnum/fminnum pairs. from to Convert clamp into fmaxnum/fminnum pairs..
Aug 30 2016, 8:49 AM

Aug 8 2016

hxy9243 updated subscribers of D17386: Loop Fusion Pass.
Aug 8 2016, 2:13 PM

Apr 20 2016

hxy9243 updated subscribers of D19338: New code hoisting pass based on GVN (optimistic approach).
Apr 20 2016, 12:50 PM

Apr 5 2016

hxy9243 updated subscribers of D18798: New code hoisting pass based on GVN.
Apr 5 2016, 11:03 AM

Apr 1 2016

hxy9243 updated subscribers of D18710: code hoisting using GVN.
Apr 1 2016, 2:19 PM