Page MenuHomePhabricator

hjelmn (Nathan Hjelm)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 11 2021, 8:16 AM (8 w, 3 d)

Recent Activity

Mar 19 2021

hjelmn added a comment to D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon.

This is something I have been doing for over 20 years now. Not sure when I initially picked it up but I find a space before the ;'s in a C for loop improves readability. It more clearly differentiates the different parts. I beleive the space before the colon in C++ range-based loops is based on the same readability improvement.

Mar 19 2021, 6:47 PM · Restricted Project, Restricted Project

Mar 16 2021

hjelmn added inline comments to D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon.
Mar 16 2021, 8:28 AM · Restricted Project, Restricted Project

Mar 15 2021

hjelmn updated the summary of D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon.
Mar 15 2021, 7:47 PM · Restricted Project, Restricted Project
hjelmn updated the diff for D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon.

One more issue with the test. Made a mistake with whether there is a space before the colon.

Mar 15 2021, 7:45 PM · Restricted Project, Restricted Project
hjelmn updated the diff for D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon.

Fixed a typo

Mar 15 2021, 4:09 PM · Restricted Project, Restricted Project
hjelmn updated the diff for D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon.

Updated change log and added a test to cover range based for with initializer.

Mar 15 2021, 1:59 PM · Restricted Project, Restricted Project

Mar 14 2021

hjelmn added a project to D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon: Restricted Project.
Mar 14 2021, 7:55 PM · Restricted Project, Restricted Project

Mar 11 2021

hjelmn requested review of D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon.
Mar 11 2021, 8:23 AM · Restricted Project, Restricted Project