Page MenuHomePhabricator

hhellyer (Howard Hellyer)
User

Projects

User does not belong to any projects.

User Details

User Since
May 23 2016, 2:07 AM (259 w, 10 h)

Recent Activity

Feb 23 2017

hhellyer committed rL295947: Ensure lldb-server waits for child debug servers to start up when passing them….
Ensure lldb-server waits for child debug servers to start up when passing them…
Feb 23 2017, 1:01 AM
hhellyer closed D30255: Ensure lldb-server waits for child debug servers to start up when passing them a port number to listen on..
Feb 23 2017, 1:01 AM

Feb 22 2017

hhellyer added a reviewer for D30255: Ensure lldb-server waits for child debug servers to start up when passing them a port number to listen on.: clayborg.
Feb 22 2017, 7:22 AM
hhellyer created D30255: Ensure lldb-server waits for child debug servers to start up when passing them a port number to listen on..
Feb 22 2017, 7:18 AM

Jan 3 2017

hhellyer committed rL290874: Simplify reading of Linux notes to correctly handle endianess..
Simplify reading of Linux notes to correctly handle endianess.
Jan 3 2017, 3:14 AM
hhellyer closed D27571: Simplify reading of Linux notes to correctly handle endianess..
Jan 3 2017, 3:13 AM

Dec 15 2016

hhellyer added inline comments to D27571: Simplify reading of Linux notes to correctly handle endianess..
Dec 15 2016, 1:47 AM

Dec 8 2016

hhellyer added reviewers for D27571: Simplify reading of Linux notes to correctly handle endianess.: uweigand, clayborg.

I spotted this when looking at why https://reviews.llvm.org/D26676 didn't quite fix reading the z/Linux core dump. Do I need to raise a bug to track this as well or is this sufficient?

Dec 8 2016, 5:15 AM
hhellyer retitled D27571: Simplify reading of Linux notes to correctly handle endianess. from to Simplify reading of Linux notes to correctly handle endianess..
Dec 8 2016, 5:12 AM

Nov 24 2016

hhellyer added a comment to D26676: Patch for lldb bug 26322 “core load hangs”.

@labath - Yes sorry about that. To be safe I did the "honest" thing of using arc to pull down the patch from phabriactor and then arc commit to land it to make sure I committed exactly what was reviewed. Somewhere in that it lost the contents of the core files and just created empty files for them. :-(

Nov 24 2016, 3:01 AM
hhellyer committed rL287861: Patch for lldb bug 26322 “core load hangs”.
Patch for lldb bug 26322 “core load hangs”
Nov 24 2016, 2:04 AM
hhellyer committed rL287858: Patch for lldb bug 26322 “core load hangs”.
Patch for lldb bug 26322 “core load hangs”
Nov 24 2016, 1:06 AM
hhellyer closed D26676: Patch for lldb bug 26322 “core load hangs”.
Nov 24 2016, 1:06 AM

Nov 23 2016

hhellyer added a comment to D26676: Patch for lldb bug 26322 “core load hangs”.

I'll land these changes tomorrow morning (UK time) so I can watch the builds and check there's no problems with the tests.

Nov 23 2016, 8:43 AM
hhellyer updated the diff for D26676: Patch for lldb bug 26322 “core load hangs”.

Updating patch to remove executables and create empty targets in the test cases.

Nov 23 2016, 5:59 AM
hhellyer added a comment to D26676: Patch for lldb bug 26322 “core load hangs”.

@labath If you are happy with the tests and the size of their supporting files I'll land this, otherwise let me know if anything needs changing.

Nov 23 2016, 3:38 AM
hhellyer updated the diff for D26676: Patch for lldb bug 26322 “core load hangs”.

Updated to add the test executables and core files.

Nov 23 2016, 3:36 AM

Nov 18 2016

hhellyer updated the diff for D26676: Patch for lldb bug 26322 “core load hangs”.

Updating the patch to include the test cases and scripts to produce the core dumps.
I haven't included the core dumps and when I do I'll need to update the pid and
tid values in the test scripts. That can wait until we've decided what to do about
the core dumps though.

Nov 18 2016, 7:23 AM

Nov 17 2016

hhellyer added a comment to D26676: Patch for lldb bug 26322 “core load hangs”.

I'd assumed that gcore would ignore the coredump_filter setting but it turns out it doesn't so I should be able to use that. lldb seems happy enough opening the core files produced with a filter of 0 so it's probably the simplest solution.

Nov 17 2016, 8:42 AM
hhellyer added a comment to D26676: Patch for lldb bug 26322 “core load hangs”.

I haven't solved that yet! ;-)

Nov 17 2016, 6:19 AM
hhellyer added a comment to D26676: Patch for lldb bug 26322 “core load hangs”.

This is marked ready to land and I can land it now but I'm still working on the testcases.
I can either:

Nov 17 2016, 1:13 AM

Nov 16 2016

hhellyer updated the diff for D26676: Patch for lldb bug 26322 “core load hangs”.

Update patch due to two missing changes.

Nov 16 2016, 5:14 AM
hhellyer updated the diff for D26676: Patch for lldb bug 26322 “core load hangs”.

Update with fixes from review comments.
I've run clang-format, fixed the use of iterators and added const qualifiers.
I removed the use of the SIGSTOP constant and use GetUnixSignals instead.
I've also moved that block down a few lines until after SetUnixSignals has been called.

Nov 16 2016, 3:49 AM

Nov 15 2016

hhellyer added reviewers for D26676: Patch for lldb bug 26322 “core load hangs”: jingham, clayborg.
Nov 15 2016, 8:40 AM
hhellyer retitled D26676: Patch for lldb bug 26322 “core load hangs” from to Patch for lldb bug 26322 “core load hangs”.
Nov 15 2016, 8:38 AM

Oct 5 2016

hhellyer added a comment to D25179: [lldb] Improve identification of Linux core dumps. Fix for bug #30485..

The change seems unlikely to pick up many false positives and core dumps from the type of system described in the bug are only going to get more common.

Oct 5 2016, 2:49 AM

Aug 30 2016

hhellyer accepted D23948: Remove unused variable.

Looks good, thanks.

Aug 30 2016, 5:28 AM

Jul 18 2016

hhellyer committed rL275778: Implement GetMemoryRegions() for Windows Minidumps and live processes..
Implement GetMemoryRegions() for Windows Minidumps and live processes.
Jul 18 2016, 1:33 AM
hhellyer closed D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes..
Jul 18 2016, 1:33 AM

Jul 15 2016

hhellyer added inline comments to D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes..
Jul 15 2016, 1:11 AM

Jul 14 2016

hhellyer added inline comments to D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes..
Jul 14 2016, 8:10 AM
hhellyer updated the diff for D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes..

.arcconfig has been updated.

Jul 14 2016, 7:59 AM
hhellyer added a comment to D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes..

Arcanist won't upload the patch without the change to .arcconfig yet because of http://lists.llvm.org/pipermail/llvm-dev/2016-July/102305.html but I think this will be patched officially shortly! It should disappear if I update the revision for any reason once that's happened.

Jul 14 2016, 6:50 AM
hhellyer retitled D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes. from to Implement GetMemoryRegions() for Windows Minidumps and live processes..
Jul 14 2016, 6:43 AM

Jul 7 2016

hhellyer committed rL274741: Implement GetMemoryRegions() for Linux and Mac OSX core files..
Implement GetMemoryRegions() for Linux and Mac OSX core files.
Jul 7 2016, 1:28 AM
hhellyer closed D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files..
Jul 7 2016, 1:28 AM

Jul 6 2016

hhellyer updated the diff for D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files..

Updated patch to export IsMapped in the C++ and Python APIs.
Updated the test case to verify all the regions returned in the list are mapped.

Jul 6 2016, 3:16 AM

Jul 4 2016

hhellyer updated the diff for D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files..

I’ve added a test in TestLinuxCore.py. It found a bug which the change in RangeMap.h resolves.

Jul 4 2016, 6:31 AM

Jun 29 2016

hhellyer added a comment to D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files..

We should document the Process::GetMemoryRegionInfo() and what we expect of it so that all plug-ins implement it correctly.

Jun 29 2016, 8:31 AM

Jun 28 2016

hhellyer added a comment to D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files..

Since there’s a list of memory regions already created in the Process implementations for the core fles I thought it made sense just to use that directly, at least when reading from a core file. It meant there was no requirement to change those GetMemoryRegionInfo implementations if they didn’t behave quite the same. That said it is roughly what I planned to do for the live connections as the behaviour of the qMemoryRegionInfo query is more tightly specified and moving to that model would just push that implementation one layer higher.

Jun 28 2016, 3:56 AM

Jun 27 2016

hhellyer updated the diff for D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files..

Squashing local commits.

Jun 27 2016, 6:50 AM
hhellyer retitled D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files. from to Implement GetMemoryRegions() for Linux and Mac OSX core files..
Jun 27 2016, 6:45 AM

Jun 23 2016

hhellyer committed rL273547: Add MemoryRegionInfo to SB API.
Add MemoryRegionInfo to SB API
Jun 23 2016, 1:42 AM
hhellyer closed D20565: Add MemoryRegionInfo to SB API.
Jun 23 2016, 1:42 AM
hhellyer closed D20565: Add MemoryRegionInfo to SB API by committing rL273547: Add MemoryRegionInfo to SB API.
Jun 23 2016, 1:42 AM
hhellyer committed rL273546: Test commit to verify access, fix typo..
Test commit to verify access, fix typo.
Jun 23 2016, 1:38 AM

Jun 20 2016

hhellyer added a comment to D20565: Add MemoryRegionInfo to SB API.

I re-updated the patch via arc diff (rather than a manual patch upload). Phabricator now seems to know which revision my changes are based off and has added the "Next Step: arc commit" status. Do I need to request an svn password to run arc commit or can you (or someone) else land this for me?

Jun 20 2016, 8:28 AM
hhellyer updated the diff for D20565: Add MemoryRegionInfo to SB API.

Updating to ensure I have the latest changes.

Jun 20 2016, 7:59 AM
hhellyer added a comment to D20565: Add MemoryRegionInfo to SB API.
Jun 20 2016, 7:24 AM

Jun 14 2016

hhellyer added a comment to D20565: Add MemoryRegionInfo to SB API.

Should I be able to deliver these changes now? When I try following the
instructions here: http://llvm.org/docs/Phabricator.html the patch
downloads and applies correctly but whether I use arc via the git or svn
commit methods I'm ultimately prompted for a password for subversion. I'm
not sure if I should have a password or if that means the patch doesn't
match what's expected in some way. I don't know how clever phabricator's
svn commit hooks are and whether they check against the patch before
prompting for authentication.

Jun 14 2016, 6:15 AM

Jun 13 2016

hhellyer updated the diff for D20565: Add MemoryRegionInfo to SB API.

Updated to rebase on the latest changes to MemoryRegionInfo.h

Jun 13 2016, 7:08 AM

Jun 3 2016

hhellyer updated the diff for D20565: Add MemoryRegionInfo to SB API.

Fix the latest code review comments to remove unnecessary tests for a valid pointer that will always be initialised.

Jun 3 2016, 3:32 AM

Jun 2 2016

hhellyer updated the diff for D20565: Add MemoryRegionInfo to SB API.

Made sure an object was always constructed for the std::unique_ptr in SBMemoryRegionInfo.cpp.
Removed unused constructor from SBMemoryRegionInfo.h.

Jun 2 2016, 2:38 AM

Jun 1 2016

hhellyer added a comment to D20565: Add MemoryRegionInfo to SB API.

My main reason for making sure we use std::unique_ptr is for API compatibility in the future. The size of std::unique_ptr and std::shared_ptr differs and if anyone wrote an IDE or tool that links against the LLDB public API, then we can't switch the layout of a class without breaking our ABI. So it is safest to go with a std::unique_ptr since the backing class is so simple and isn't expensive to copy.

Jun 1 2016, 5:35 AM
hhellyer updated the diff for D20565: Add MemoryRegionInfo to SB API.

I've switch to a unique_ptr from a shared_ptr in SBMemoryRegionInfo.

Jun 1 2016, 5:29 AM

May 31 2016

hhellyer added a comment to D20565: Add MemoryRegionInfo to SB API.

This looks good as long as SBMemoryRegionInfo and SBMemoryRegionInfoList are ready only and will never have any setter functions. If we plan to ever have the SBMemoryRegionInfo or SBMemoryRegionInfoList be modifiable, then we should make each contain a std::unique_ptr instead of a std::shared_ptr.

May 31 2016, 5:20 AM

May 27 2016

hhellyer updated the diff for D20565: Add MemoryRegionInfo to SB API.

Removed std::enable_shared_from_this from MemoryRegionInfo.h (which removes the only change from that file)
Renamed region_info to region_info_sp in SBProcess::GetMemoryRegionInfo in SBProcess.cpp
I also corrected the position of the opening { on the functions in that file to match the standard.

May 27 2016, 5:21 AM

May 24 2016

hhellyer retitled D20565: Add MemoryRegionInfo to SB API from to Add MemoryRegionInfo to SB API.
May 24 2016, 5:57 AM