User Details
- User Since
- Jan 20 2021, 1:24 PM (114 w, 12 h)
Fri, Mar 24
Fix naming of function
Updated unit test to be more concise
Updates based on Thomas' comments
Feb 13 2023
Looks good overall! Thanks for getting this to work with warps!
Feb 3 2023
Looks good! Thanks!
Feb 8 2022
Thank you! :)
Updated based on Thomas' comments
Sounds good. I will change the condition to vectorType.getRank() <=1
Feb 7 2022
Added unit test
Jan 28 2022
Updated based on second round of comments
Jan 27 2022
Updated based on Thomas' comments
@aartbik - based on discussions with @ThomasRaoux , we felt it made more sense to do a vector to vector conversion instead of going directly to llvm. I have added the patch here along with some tests. Please take a look and let me know what you think. Thanks!
Jan 26 2022
Added lowering to arith ops, tests and integration tests.
Jan 24 2022
Updated patch based on Thomas' comments.
Jan 20 2022
Jan 14 2022
Hi Aart,
Jan 12 2022
Aug 13 2021
Added explicit type annotations as per comments.
Aug 6 2021
Jun 28 2021
Thanks and feel free to merge because I don't have merge priveleges.
Address comments and linting errors
@ThomasRaoux - yes I just uploaded it.
Fixed as per comments
Thanks @ThomasRaoux , @asaadaldien , @nicolasvasilache for the comments. @nicolasvasilache I have modified the patch as per your changes but kept the current patch to just handle moving reductions to the inner most dimensions. I will put up another patch to handle moving reductions to the outermost dimensions and based on the performance of inner vs outer, we can decide which path we want to take.
Jun 24 2021
Fixed lint changes
May 26 2021
Add support for fpext, fptrunc and trunci
Updated commit message
Added support for more casting ops
Jan 27 2021
Apologies I was just attempting to cherry pick someone else's change and am new to arcanist.