Page MenuHomePhabricator

harsh (Harsh Menon)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2021, 1:24 PM (114 w, 12 h)

Recent Activity

Fri, Mar 24

harsh committed rG6d0de19ed37c: [mlir][vector] Hoist redundant singleton vector transfer reads (authored by harsh).
[mlir][vector] Hoist redundant singleton vector transfer reads
Fri, Mar 24, 3:22 PM · Restricted Project, Restricted Project
harsh closed D146828: [mlir][vector] Hoist redundant singleton vector transfer reads.
Fri, Mar 24, 3:22 PM · Restricted Project, Restricted Project
harsh updated the diff for D146828: [mlir][vector] Hoist redundant singleton vector transfer reads.

Fix naming of function

Fri, Mar 24, 3:15 PM · Restricted Project, Restricted Project
harsh updated the diff for D146828: [mlir][vector] Hoist redundant singleton vector transfer reads.

Updated unit test to be more concise

Fri, Mar 24, 3:13 PM · Restricted Project, Restricted Project
harsh added inline comments to D146828: [mlir][vector] Hoist redundant singleton vector transfer reads.
Fri, Mar 24, 3:01 PM · Restricted Project, Restricted Project
harsh updated the diff for D146828: [mlir][vector] Hoist redundant singleton vector transfer reads.

Updates based on Thomas' comments

Fri, Mar 24, 3:00 PM · Restricted Project, Restricted Project
harsh requested review of D146828: [mlir][vector] Hoist redundant singleton vector transfer reads.
Fri, Mar 24, 10:39 AM · Restricted Project, Restricted Project

Feb 13 2023

harsh accepted D143950: [mlir][gpu] NFC change to pass threadID ops to rewriteOneForeachThreadToGpuThreads.

Looks good overall! Thanks for getting this to work with warps!

Feb 13 2023, 5:09 PM · Restricted Project, Restricted Project

Feb 3 2023

harsh accepted D143298: [mlir][gpu] Allow distributing to different level of IDs without failing.
Feb 3 2023, 3:24 PM · Restricted Project, Restricted Project
harsh added a comment to D143298: [mlir][gpu] Allow distributing to different level of IDs without failing.

Looks good! Thanks!

Feb 3 2023, 3:24 PM · Restricted Project, Restricted Project

Feb 8 2022

harsh committed rG4a876b13fbba: Add case to handle 0-D vectors in FlattenContiguousRowMajorTransferWritePattern… (authored by harsh).
Add case to handle 0-D vectors in FlattenContiguousRowMajorTransferWritePattern…
Feb 8 2022, 12:01 PM
harsh closed D119202: Add case to handle 0-D vectors in FlattenContiguousRowMajorTransferWritePattern and FlattenContiguousRowMajorTransferReadPattern..
Feb 8 2022, 12:00 PM · Restricted Project
harsh added a comment to D119202: Add case to handle 0-D vectors in FlattenContiguousRowMajorTransferWritePattern and FlattenContiguousRowMajorTransferReadPattern..

Thank you! :)

Feb 8 2022, 11:44 AM · Restricted Project
harsh updated the diff for D119202: Add case to handle 0-D vectors in FlattenContiguousRowMajorTransferWritePattern and FlattenContiguousRowMajorTransferReadPattern..

Updated based on Thomas' comments

Feb 8 2022, 11:14 AM · Restricted Project
harsh added a comment to D119202: Add case to handle 0-D vectors in FlattenContiguousRowMajorTransferWritePattern and FlattenContiguousRowMajorTransferReadPattern..

Sounds good. I will change the condition to vectorType.getRank() <=1

Feb 8 2022, 10:42 AM · Restricted Project
harsh added inline comments to D119202: Add case to handle 0-D vectors in FlattenContiguousRowMajorTransferWritePattern and FlattenContiguousRowMajorTransferReadPattern..
Feb 8 2022, 10:02 AM · Restricted Project
harsh added inline comments to D119202: Add case to handle 0-D vectors in FlattenContiguousRowMajorTransferWritePattern and FlattenContiguousRowMajorTransferReadPattern..
Feb 8 2022, 9:58 AM · Restricted Project

Feb 7 2022

harsh updated the diff for D119202: Add case to handle 0-D vectors in FlattenContiguousRowMajorTransferWritePattern and FlattenContiguousRowMajorTransferReadPattern..

Added unit test

Feb 7 2022, 4:37 PM · Restricted Project
harsh requested review of D119202: Add case to handle 0-D vectors in FlattenContiguousRowMajorTransferWritePattern and FlattenContiguousRowMajorTransferReadPattern..
Feb 7 2022, 4:09 PM · Restricted Project

Jan 28 2022

harsh committed rG80e0bf1af11c: Add vector.scan op (authored by harsh).
Add vector.scan op
Jan 28 2022, 12:09 PM
harsh closed D117171: Add vector.scan op.
Jan 28 2022, 12:08 PM · Restricted Project
harsh updated the diff for D117171: Add vector.scan op.

Updated based on second round of comments

Jan 28 2022, 10:07 AM · Restricted Project
harsh added inline comments to D117171: Add vector.scan op.
Jan 28 2022, 10:06 AM · Restricted Project

Jan 27 2022

harsh updated the diff for D117171: Add vector.scan op.

Updated based on Thomas' comments

Jan 27 2022, 4:33 PM · Restricted Project
harsh added inline comments to D117171: Add vector.scan op.
Jan 27 2022, 4:33 PM · Restricted Project
harsh updated subscribers of D117171: Add vector.scan op.

@aartbik - based on discussions with @ThomasRaoux , we felt it made more sense to do a vector to vector conversion instead of going directly to llvm. I have added the patch here along with some tests. Please take a look and let me know what you think. Thanks!

Jan 27 2022, 12:01 AM · Restricted Project

Jan 26 2022

harsh updated the diff for D117171: Add vector.scan op.

Added lowering to arith ops, tests and integration tests.

Jan 26 2022, 11:59 PM · Restricted Project

Jan 24 2022

harsh committed rGe01e4c9115ad: Fix bugs in GPUToNVVM lowering (authored by harsh).
Fix bugs in GPUToNVVM lowering
Jan 24 2022, 7:26 PM
harsh closed D118086: Fix bugs in GPUToNVVM lowering.
Jan 24 2022, 7:25 PM · Restricted Project
harsh updated the diff for D118086: Fix bugs in GPUToNVVM lowering.

Updated patch based on Thomas' comments.

Jan 24 2022, 6:23 PM · Restricted Project
harsh added inline comments to D118086: Fix bugs in GPUToNVVM lowering.
Jan 24 2022, 6:15 PM · Restricted Project
harsh requested review of D118086: Fix bugs in GPUToNVVM lowering.
Jan 24 2022, 4:02 PM · Restricted Project

Jan 20 2022

harsh added a comment to D117171: Add vector.scan op.

Having defined this op, we needed to find a way to lower this to the gpu dialect and thought that the jump
from the linalg_ext abstraction to the gpu abstraction would be too large. Thus, we decided on creating a vector.scan op which would provide a more progressive lowering. The plan is to
first add a lowering to the gpu dialect (where the scan would be lowered to gpu.shuffle ops) that is performant and then provide a cpu lowering. Would love to hear any thoughts
you have on this and any ideas on how we could do this better.

For most vector ops, we have an actual lowering to LLVM IR, just so we can run integration test on the new functionality. This also acts as extra "documentation" on what the op does.
This first lowering does not need to be super efficient, but if you see chance to add the lowering to this or a follow up CL, that would make the intended use of this op more clear to me.

Jan 20 2022, 10:36 AM · Restricted Project

Jan 14 2022

harsh added a comment to D117171: Add vector.scan op.

Hi Aart,

Jan 14 2022, 3:32 PM · Restricted Project

Jan 12 2022

harsh requested review of D117171: Add vector.scan op.
Jan 12 2022, 4:02 PM · Restricted Project

Aug 13 2021

harsh updated the diff for D107675: Add support for moving reductions to outer most dimensions in vector.multi_reduction.

Added explicit type annotations as per comments.

Aug 13 2021, 11:41 AM · Restricted Project

Aug 6 2021

harsh requested review of D107675: Add support for moving reductions to outer most dimensions in vector.multi_reduction.
Aug 6 2021, 3:44 PM · Restricted Project

Jun 28 2021

harsh added a comment to D104884: Order parallel indices before transposing the input in multireductions.

Thanks and feel free to merge because I don't have merge priveleges.

Jun 28 2021, 5:09 PM · Restricted Project
harsh updated the diff for D104884: Order parallel indices before transposing the input in multireductions.

Address comments and linting errors

Jun 28 2021, 4:11 PM · Restricted Project
harsh added inline comments to D104884: Order parallel indices before transposing the input in multireductions.
Jun 28 2021, 4:10 PM · Restricted Project
harsh added a comment to D104884: Order parallel indices before transposing the input in multireductions.

@ThomasRaoux - yes I just uploaded it.

Jun 28 2021, 3:02 PM · Restricted Project
harsh updated the diff for D104884: Order parallel indices before transposing the input in multireductions.

Fixed as per comments

Jun 28 2021, 2:59 PM · Restricted Project
harsh added a comment to D104884: Order parallel indices before transposing the input in multireductions.

Thanks @ThomasRaoux , @asaadaldien , @nicolasvasilache for the comments. @nicolasvasilache I have modified the patch as per your changes but kept the current patch to just handle moving reductions to the inner most dimensions. I will put up another patch to handle moving reductions to the outermost dimensions and based on the performance of inner vs outer, we can decide which path we want to take.

Jun 28 2021, 2:44 PM · Restricted Project

Jun 24 2021

harsh updated the diff for D104884: Order parallel indices before transposing the input in multireductions.

Fixed lint changes

Jun 24 2021, 6:19 PM · Restricted Project
harsh requested review of D104884: Order parallel indices before transposing the input in multireductions.
Jun 24 2021, 4:33 PM · Restricted Project

May 26 2021

harsh updated the diff for D103207: Add n-D vector lowering to LLVM for cast ops.

Add support for fpext, fptrunc and trunci

May 26 2021, 3:11 PM · Restricted Project
harsh updated the diff for D103207: Add n-D vector lowering to LLVM for cast ops.

Updated commit message

May 26 2021, 2:53 PM · Restricted Project
harsh updated the diff for D103207: Add n-D vector lowering to LLVM for cast ops.

Added support for more casting ops

May 26 2021, 2:52 PM · Restricted Project
harsh requested review of D103207: Add n-D vector lowering to LLVM for cast ops.
May 26 2021, 2:29 PM · Restricted Project

Jan 27 2021

harsh abandoned D95549: [X86][AVX] Handle vperm2x128 shuffling of a subvector splat..

Apologies I was just attempting to cherry pick someone else's change and am new to arcanist.

Jan 27 2021, 11:08 AM · Restricted Project
harsh requested review of D95549: [X86][AVX] Handle vperm2x128 shuffling of a subvector splat..
Jan 27 2021, 11:05 AM · Restricted Project