Page MenuHomePhabricator

haonanya (Yang Haonan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2021, 10:21 PM (14 w, 16 h)

Recent Activity

Fri, Oct 8

haonanya added a comment to D109740: [OpenCL] Add atomic_half type builtins.

Hi, svenvh. Thanks for your review.
Could you please help to submit the patch if there are no more inputs?

Fri, Oct 8, 7:20 PM · Restricted Project

Fri, Oct 1

haonanya updated the diff for D109740: [OpenCL] Add atomic_half type builtins.

Fix format issue

Fri, Oct 1, 3:53 AM · Restricted Project

Sep 23 2021

haonanya added inline comments to D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.
Sep 23 2021, 1:19 AM · Restricted Project

Sep 13 2021

haonanya requested review of D109740: [OpenCL] Add atomic_half type builtins.
Sep 13 2021, 10:47 PM · Restricted Project
haonanya added a comment to D106343: [OpenCL] Support cl_ext_float_atomics.

Hi, svenvh.
I am ok with the patch. Thanks very much.
I'd appreciate it if you help review https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/1116 as well.

Sep 13 2021, 6:53 PM · Restricted Project

Sep 3 2021

haonanya added a comment to D106343: [OpenCL] Support cl_ext_float_atomics.

Kindly ping

Sep 3 2021, 5:37 AM · Restricted Project

Sep 1 2021

haonanya added a comment to D106343: [OpenCL] Support cl_ext_float_atomics.

Hi, svenvh.
Should we use cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics to guard the functions using atomic_double type?
Thanks very much.

#if defined(__opencl_c_ext_fp64_local_atomic_min_max)
double __ovld atomic_fetch_min(volatile __local atomic_double *object,
                               double operand);
#endif

Hi, svenvh and Anastasia. Do you have any comments for adding cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics to guard atomic_double type? I'd appreciate it if you have time to answer it.
And if there is no any comment, please commit the patch.
Thanks very much.

Sep 1 2021, 6:52 PM · Restricted Project

Aug 31 2021

haonanya added a comment to D106343: [OpenCL] Support cl_ext_float_atomics.

Hi, svenvh and Anastasia. If you approve the patch, could you please submit it?
I don't have permission to do it.

Aug 31 2021, 12:07 AM · Restricted Project

Aug 26 2021

haonanya added a comment to D106343: [OpenCL] Support cl_ext_float_atomics.

Hi, svenvh.
Should we use cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics to guard the functions using atomic_double type?
Thanks very much.

Aug 26 2021, 6:36 AM · Restricted Project

Aug 25 2021

haonanya added a comment to D106343: [OpenCL] Support cl_ext_float_atomics.

The extension spec seems to also mention atomic_half. Are planning to add it too?

Aug 25 2021, 4:41 AM · Restricted Project

Aug 23 2021

haonanya updated the diff for D106343: [OpenCL] Support cl_ext_float_atomics.

Fix formatting issues

Aug 23 2021, 7:10 PM · Restricted Project
haonanya updated the diff for D106343: [OpenCL] Support cl_ext_float_atomics.

Unify formatting and fix some errors on OpenCLBuiltins.td

Aug 23 2021, 8:43 AM · Restricted Project

Aug 22 2021

haonanya updated the diff for D106343: [OpenCL] Support cl_ext_float_atomics.

Let builtins are guarded by related macro

Aug 22 2021, 3:02 AM · Restricted Project

Aug 18 2021

haonanya updated the diff for D106343: [OpenCL] Support cl_ext_float_atomics.

Remove OpenCL3.0 macro guards on opencl-c.h and OpenCLBuiltins.td.
Add missing feature macro.
simplify test.

Aug 18 2021, 4:36 AM · Restricted Project

Aug 17 2021

haonanya added a comment to D106343: [OpenCL] Support cl_ext_float_atomics.

Hi, Anastasia and svenvh.
Sorry for late reply. I have updated patch per your comments.
Many thanks for your comments.

Aug 17 2021, 1:39 AM · Restricted Project
haonanya updated the diff for D106343: [OpenCL] Support cl_ext_float_atomics.

Add the new builtins to clang/lib/Sema/OpenCLBuiltins.td.

Aug 17 2021, 1:36 AM · Restricted Project

Jul 22 2021

haonanya added a comment to D106343: [OpenCL] Support cl_ext_float_atomics.

FYI this revision has not been added to cfe-commits, is this intensional?

Jul 22 2021, 8:53 PM · Restricted Project
haonanya updated the diff for D106343: [OpenCL] Support cl_ext_float_atomics.

Add extension and all the feature macros to internal header.

Jul 22 2021, 12:13 AM · Restricted Project

Jul 19 2021

haonanya requested review of D106343: [OpenCL] Support cl_ext_float_atomics.
Jul 19 2021, 11:01 PM · Restricted Project