Page MenuHomePhabricator

guitard0g (Josh Learn)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 27 2021, 3:30 PM (8 w, 6 d)

Recent Activity

Wed, Sep 22

guitard0g added a comment to D109951: [clang-format] Constructor initializer lists format with pp directives.

@MyDeveloperDay @HazardyKnusperkeks I don't have commit access, could one of you commit this for me? Thanks so much for your review!

Wed, Sep 22, 10:35 AM · Restricted Project, Restricted Project

Tue, Sep 21

guitard0g updated the summary of D109951: [clang-format] Constructor initializer lists format with pp directives.
Tue, Sep 21, 1:26 PM · Restricted Project, Restricted Project
guitard0g updated the diff for D109951: [clang-format] Constructor initializer lists format with pp directives.

Add test case for space between directives.

Tue, Sep 21, 10:14 AM · Restricted Project, Restricted Project

Fri, Sep 17

guitard0g updated the diff for D109951: [clang-format] Constructor initializer lists format with pp directives.

Fix failing tests.

Fri, Sep 17, 4:34 PM · Restricted Project, Restricted Project
guitard0g added a comment to D109951: [clang-format] Constructor initializer lists format with pp directives.

When looking at test case suggestions, I happened upon another problem that occurs when handling preprocessor directives. The following code is properly formatted (following llvm style, with ColumnLimit=0):

Fri, Sep 17, 3:14 PM · Restricted Project, Restricted Project
guitard0g updated the diff for D109951: [clang-format] Constructor initializer lists format with pp directives.

Add test case suggestions from reviewers.

Fri, Sep 17, 3:07 PM · Restricted Project, Restricted Project
guitard0g updated the diff for D109951: [clang-format] Constructor initializer lists format with pp directives.

Fix failing tests.

Fri, Sep 17, 1:40 AM · Restricted Project, Restricted Project
guitard0g updated the diff for D109951: [clang-format] Constructor initializer lists format with pp directives.

Removing useless line from test.

Fri, Sep 17, 12:44 AM · Restricted Project, Restricted Project
guitard0g added a comment to D109951: [clang-format] Constructor initializer lists format with pp directives.

@MyDeveloperDay This is an issue a coworker pointed out to me. Previously this code:

Fri, Sep 17, 12:42 AM · Restricted Project, Restricted Project
guitard0g requested review of D109951: [clang-format] Constructor initializer lists format with pp directives.
Fri, Sep 17, 12:25 AM · Restricted Project, Restricted Project

Jul 29 2021

guitard0g added a comment to D107026: [Clang] Add support for attribute 'escape'.

@vsavchenko

I see that the "applies to pointer arguments only" warning is not tested for noescape, but I still find it to be a good practice to write a test with a bunch of cases with attributes applied in wrong places.

Updated with some tests for this!

Jul 29 2021, 12:40 PM · Restricted Project
guitard0g updated the diff for D107026: [Clang] Add support for attribute 'escape'.

Add tests for diagnostics of incorrect usage. Diagnose when escape and noescape are used on the same parameter.

Jul 29 2021, 12:36 PM · Restricted Project
guitard0g added a reviewer for D107026: [Clang] Add support for attribute 'escape': ravikandhadai.
Jul 29 2021, 12:17 PM · Restricted Project

Jul 28 2021

guitard0g added inline comments to D107026: [Clang] Add support for attribute 'escape'.
Jul 28 2021, 10:39 PM · Restricted Project
guitard0g updated the diff for D107026: [Clang] Add support for attribute 'escape'.

Change Escape/NoEscape to use InheritableAttr and update an attribute test to fix test failure.

Jul 28 2021, 10:38 PM · Restricted Project
guitard0g added inline comments to D107026: [Clang] Add support for attribute 'escape'.
Jul 28 2021, 9:38 PM · Restricted Project
guitard0g requested review of D107026: [Clang] Add support for attribute 'escape'.
Jul 28 2021, 8:55 PM · Restricted Project