Page MenuHomePhabricator

graham-yiu-huawei (Graham Yiu)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 19 2017, 1:32 PM (90 w, 6 d)

Recent Activity

Mar 20 2018

graham-yiu-huawei added a comment to D43219: [PartialInlining] Fix Crash from holding a reference to a destructed ORE.

@sfertile Sorry for the late response. AFAIK there shouldn't be a downside to creating the ORE objects at the point of use, I only did it the original way to conform to the style I saw in other passes and to avoid passing the ORE object from function to function. However, my knowledge in the ORE area is limited so someone else may contradict what I just said. Good luck!

Mar 20 2018, 10:49 AM