Page MenuHomePhabricator

gracicot (Guillaume Racicot)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 11 2019, 7:53 AM (128 w, 4 d)

Recent Activity

Oct 5 2021

gracicot added a comment to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.

FYI, this is a very aggressive change, I highly recommend you run this over a large code base before landing. to double check, here is one slight oddity which I cannot determine if its correct or not.

void foo() {
    if (quitelongarg != (alsolongarg - 1)) { // ABC is a very longgggggggggggg comment
      return;
    }
}

becomes

void foo() {
  if (quitelongarg != (alsolongarg - 1)
  ) { // ABC is a very longgggggggggggg comment
    return;
  }
}
BasedOnStyle: LLVM
BreakBeforeClosingParen: true

That might be what you expect but I wasn't quite sure

That is at least not what is covered in the tests or documentation. I would think it only applies to function declarations and invocations.
So either adapt documentation and test coverage, or fix behavior (in which case the tests should be extended as well).

Oct 5 2021, 12:23 PM · Restricted Project, Restricted Project

Jun 11 2019

gracicot added a comment to D33029: [clang-format] add option for dangling parenthesis.

Will this option also work with dangling braces from initializers?

Jun 11 2019, 7:59 AM · Restricted Project, Restricted Project