Page MenuHomePhabricator
People gpetters94

gpetters94 (George Petterson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 2 2022, 12:10 AM (10 w, 3 d)

Recent Activity
View All

Thu, Jul 21

gpetters94 committed rGa935a0bf5070: Adding a new variant of DepthwiseConv2D (authored by gpetters94).
Adding a new variant of DepthwiseConv2D
Thu, Jul 21, 11:37 AM · Restricted Project, Restricted Project
gpetters94 closed D128575: Adding a new variant of DepthwiseConv2D.
Thu, Jul 21, 11:37 AM · Restricted Project, Restricted Project

Jul 13 2022

gpetters94 added a comment to D128575: Adding a new variant of DepthwiseConv2D.

@silvas @mravishankar Do you think this is good to go then?

Jul 13 2022, 1:53 PM · Restricted Project, Restricted Project

Jul 6 2022

gpetters94 added a comment to D128880: Bugfix for grouped convolution op.

Can do. Is this better?

Jul 6 2022, 4:47 PM · Restricted Project, Restricted Project
gpetters94 updated the summary of D128880: Bugfix for grouped convolution op.
Jul 6 2022, 4:46 PM · Restricted Project, Restricted Project
gpetters94 added a comment to D128880: Bugfix for grouped convolution op.
In D128880#3633757, @silvas wrote:

What is the bug, and how does this fix it?

Jul 6 2022, 3:54 PM · Restricted Project, Restricted Project

Jun 29 2022

gpetters94 requested review of D128880: Bugfix for grouped convolution op.
Jun 29 2022, 11:15 PM · Restricted Project, Restricted Project

Jun 26 2022

gpetters94 updated the diff for D128575: Adding a new variant of DepthwiseConv2D.

Added tests for this op, as well as for my previous op (grouped conv) that has already landed.

Jun 26 2022, 10:49 PM · Restricted Project, Restricted Project
gpetters94 added a comment to D128575: Adding a new variant of DepthwiseConv2D.
In D128575#3611126, @bondhugula wrote:
In D128575#3611124, @bondhugula wrote:

Please add a test case as well for the new op.

I noticed the previous update to this yaml file also missed adding a test case: bc07634b5a762686b818932eb350b4fc84217e67

Jun 26 2022, 8:48 PM · Restricted Project, Restricted Project

Jun 24 2022

gpetters94 requested review of D128575: Adding a new variant of DepthwiseConv2D.
Jun 24 2022, 10:30 PM · Restricted Project, Restricted Project

Jun 17 2022

gpetters94 updated the diff for D127225: Adding a named op for grouped convolutions.

Finally finished the bugfixing, with a lot of help from Mahesh. Should be ready to be merged unless anyone has any more requests.

Jun 17 2022, 10:27 PM · Restricted Project, Restricted Project

Jun 9 2022

gpetters94 updated the diff for D127225: Adding a named op for grouped convolutions.

Updated indexing maps.

Jun 9 2022, 11:59 PM · Restricted Project, Restricted Project
gpetters94 updated the diff for D127225: Adding a named op for grouped convolutions.

Addressed comments.

Jun 9 2022, 11:36 PM · Restricted Project, Restricted Project

Jun 8 2022

gpetters94 added a comment to D127225: Adding a named op for grouped convolutions.
In D127225#3567554, @silvas wrote:
In D127225#3565062, @gpetters94 wrote:

I think it makes more sense for it to be major, if only for legibility's sake.

It's not really something we get to choose -- the op definition in frontends determines whether the groups are major or minor to the "real channels" -- I think it is major but please verify that. If we don't get this right then we have to transpose before calling this op which is wasteful.

Jun 8 2022, 10:21 PM · Restricted Project, Restricted Project

Jun 7 2022

gpetters94 added a comment to D127225: Adding a named op for grouped convolutions.

I think it makes more sense for it to be major, if only for legibility's sake.

Jun 7 2022, 4:31 PM · Restricted Project, Restricted Project
gpetters94 requested review of D127225: Adding a named op for grouped convolutions.
Jun 7 2022, 9:12 AM · Restricted Project, Restricted Project