Page MenuHomePhabricator

glotchimo (Elliott Maguire)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2021, 10:23 PM (30 w, 1 d)

Recent Activity

Jan 18 2022

glotchimo added a comment to D117421: [clang-format] Fix incorrect alignment of operator= overloads..

Amazing, thank you. This is my first patch so I will need help landing, but I will also apply for commit access as I intend to keep contributing. Here is my name and email for this commit: Elliott Maguire <glotchimo@pm.me>

Jan 18 2022, 7:29 AM · Restricted Project, Restricted Project

Jan 17 2022

glotchimo updated the summary of D117421: [clang-format] Fix incorrect alignment of operator= overloads..
Jan 17 2022, 9:19 PM · Restricted Project, Restricted Project
glotchimo updated the diff for D117421: [clang-format] Fix incorrect alignment of operator= overloads..

Simplify by removing look-ahead (unnecessary b/c of difference between ident and operator tokens).

Jan 17 2022, 7:34 PM · Restricted Project, Restricted Project
glotchimo added inline comments to D117421: [clang-format] Fix incorrect alignment of operator= overloads..
Jan 17 2022, 2:39 PM · Restricted Project, Restricted Project
glotchimo updated the diff for D117421: [clang-format] Fix incorrect alignment of operator= overloads..

Use getPreviousNonComment to account for inline comments.

Jan 17 2022, 12:46 PM · Restricted Project, Restricted Project
glotchimo added a comment to D117421: [clang-format] Fix incorrect alignment of operator= overloads..

Could you check if your patch fixes https://github.com/llvm/llvm-project/issues/33044 as well?
If so, please add tests.

Jan 17 2022, 11:13 AM · Restricted Project, Restricted Project
glotchimo added a comment to D117421: [clang-format] Fix incorrect alignment of operator= overloads..

I was tinkering with the use of getPreviousNonComment last night before signing off and the problem that I noticed was that, though it stops the operator= from being split and aligned with previous lines, it adds a single space:

Jan 17 2022, 10:32 AM · Restricted Project, Restricted Project
glotchimo updated the diff for D117421: [clang-format] Fix incorrect alignment of operator= overloads..

Add overload declaration look-ahead.

Jan 17 2022, 10:30 AM · Restricted Project, Restricted Project
glotchimo updated the diff for D117421: [clang-format] Fix incorrect alignment of operator= overloads..

Add equality operator tests.

Jan 17 2022, 12:20 AM · Restricted Project, Restricted Project

Jan 16 2022

glotchimo updated the diff for D117421: [clang-format] Fix incorrect alignment of operator= overloads..

Explicitly declare FormatToken type instead of using auto.

Jan 16 2022, 10:30 PM · Restricted Project, Restricted Project
glotchimo added a comment to D117421: [clang-format] Fix incorrect alignment of operator= overloads..

Excellent, thank you! I'll get right on these edits.

Jan 16 2022, 10:29 AM · Restricted Project, Restricted Project
glotchimo published D117421: [clang-format] Fix incorrect alignment of operator= overloads. for review.
Jan 16 2022, 9:19 AM · Restricted Project, Restricted Project