Page MenuHomePhabricator

glenjofe (Glen Fernandes)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 4:23 PM (101 w, 3 d)

Recent Activity

Feb 20 2019

glenjofe added a comment to D58088: [adt] Add raw_pointer_iterator to iterate over std::unique_ptr<> collections.

That looks simple enough. I haven't gone through the spec but something as simple as:

namespace llvm {
template<class Ptr>
auto to_address(const Ptr &P) noexcept { return P.operator->(); }
template<class T>
constexpr T* to_address(T* P) noexcept { return P; }
}

seems to cover the majority of it (and definitely the bits I need). It's just the std::pointer_traits<Ptr>::to_address(p) based implementation of the fancy pointer overload that's missing.

Feb 20 2019, 5:29 PM · Restricted Project
glenjofe added inline comments to D58421: Add partial implementation of std::to_address() as llvm::to_address().
Feb 20 2019, 5:03 PM · Restricted Project
glenjofe added inline comments to D58421: Add partial implementation of std::to_address() as llvm::to_address().
Feb 20 2019, 4:57 PM · Restricted Project

Nov 23 2017

glenjofe added a reviewer for D40379: [libcxx] Update C++2a status page and Credits: mclow.lists.
Nov 23 2017, 4:34 AM

Nov 22 2017

glenjofe created D40379: [libcxx] Update C++2a status page and Credits.
Nov 22 2017, 7:52 PM

Nov 21 2017

glenjofe added a comment to D35470: [libcxx] Implement std::to_address for C++20.

Thanks Eric. Can you commit on my behalf?

Nov 21 2017, 8:00 PM

Nov 20 2017

glenjofe added inline comments to D35470: [libcxx] Implement std::to_address for C++20.
Nov 20 2017, 1:48 PM

Nov 19 2017

glenjofe updated the diff for D35470: [libcxx] Implement std::to_address for C++20.

Address Eric's review comments.

Nov 19 2017, 9:31 PM
glenjofe updated the diff for D35470: [libcxx] Implement std::to_address for C++20.

Now implements P0653R2 which was accepted in Albuquerque.

Nov 19 2017, 4:48 PM
glenjofe retitled D35470: [libcxx] Implement std::to_address for C++20 from [libcxx] Implement pointer_traits::to_address as in P0653R0 to [libcxx] Implement std::to_address for C++20.
Nov 19 2017, 4:45 PM

Jul 17 2017

glenjofe updated the diff for D35470: [libcxx] Implement std::to_address for C++20.

Include full context in the diff.

Jul 17 2017, 3:10 PM

Jul 16 2017

glenjofe changed the edit policy for D35470: [libcxx] Implement std::to_address for C++20.
Jul 16 2017, 6:47 PM
glenjofe created D35470: [libcxx] Implement std::to_address for C++20.
Jul 16 2017, 6:46 PM