Page MenuHomePhabricator

gkll (Georg Kotheimer)
User

Projects

User does not belong to any projects.

User Details

User Since
May 26 2022, 12:46 PM (27 w, 1 d)

Recent Activity

Aug 30 2022

gkll requested review of D126498: [clangd] Fix hover crashing on integral or enumeral casts.

Mhm, I think the change here has gone under the radar 🙈

Aug 30 2022, 2:21 AM · Restricted Project, Restricted Project

Jun 1 2022

gkll added a comment to D126498: [clangd] Fix hover crashing on integral or enumeral casts.

Thank you, and sorry for the chaos, this is my first submission to llvm :D

Jun 1 2022, 12:56 AM · Restricted Project, Restricted Project
gkll updated the diff for D126498: [clangd] Fix hover crashing on integral or enumeral casts.

Avoid double negation.

Jun 1 2022, 12:34 AM · Restricted Project, Restricted Project

May 31 2022

gkll updated the diff for D126498: [clangd] Fix hover crashing on integral or enumeral casts.

Fixed formatting of Argv array.

May 31 2022, 3:56 PM · Restricted Project, Restricted Project
gkll updated the diff for D126498: [clangd] Fix hover crashing on integral or enumeral casts.

Use uintptr_t instead of unsigned long for the casts, to ensure the pointer always fits into the integer type.
For example on Windows x64 that was previously not the case, because there unsigned long is only 32-bits wide.
Thus the pointer got truncated during the cast, which resulted in getHover() returning None instead of &global_var.

May 31 2022, 3:44 PM · Restricted Project, Restricted Project
gkll updated the diff for D126498: [clangd] Fix hover crashing on integral or enumeral casts.

Changed return type of non-returning function in test code to void.

May 31 2022, 1:47 PM · Restricted Project, Restricted Project
gkll added a comment to D126498: [clangd] Fix hover crashing on integral or enumeral casts.

Oh wow, my mental model of these was all wrong.

Thank you! Do you want me to land this for you?

Yeah, that would be great, thank you!

Sorry, can you provide an email address for attribution?

(Normally I can pick this up with arc patch, but not this time apparently)

May 31 2022, 12:56 PM · Restricted Project, Restricted Project
gkll added a comment to D126498: [clangd] Fix hover crashing on integral or enumeral casts.

Oh wow, my mental model of these was all wrong.

Thank you! Do you want me to land this for you?

May 31 2022, 12:21 PM · Restricted Project, Restricted Project

May 26 2022

gkll requested review of D126498: [clangd] Fix hover crashing on integral or enumeral casts.
May 26 2022, 1:24 PM · Restricted Project, Restricted Project