I will update the patch with the suggestions and send them again.

@aaron.ballman Ping

Incorporate some of Aron suggestions:

Hi. See inline answers. I will send the new version in a few minutes.

Update patch with the agreements of last discussion.

Just to make myself clear: What I need to do is that the clang dumps for C files are also accepted by GCC as input.

Hi, Alan. Thanks for your review again!

Update to dump attributes right after the type specification, also
fixing the __declspec case.

The way Clang handles this is to mostly go back to the original source code (through the source manager and source location information) to grab what the user actually wrote. The pretty printing functionality loses information like whether something was expanded from a macro, etc and so, if the goal is to show what the user wrote, it's likely to be a really big uphill battle to get that through the pretty printer.

In D141714#4077204, @aaron.ballman wrote:

In D141714#4077199, @giulianobelinassi wrote:

In D141714#4077150, @aaron.ballman wrote:

Thank you for the fix!

It looks like precommit CI found a related failure that needs to be addressed: https://buildkite.com/llvm-project/premerge-checks/builds/130589#0185ac99-1158-46b3-b6d1-52fcf5310a59

Can you also add a release note about the fix as well?

Thank you for your review!

I will update this patch once I get spare cycles to this. There is also an additonal case regarding __declspec and K&R functions that needs to be addressed as well in this patch which it currently doesn't do.

You don't have to worry about the additional cases (unless you want to, but then they can be handled in separate patches); ast pretty printing is wrong, broken, and totally incorrect in a whole lot of places; we maintain it as a best effort as a debugging aid.

In D141714#4077150, @aaron.ballman wrote:

Thank you for the fix!

It looks like precommit CI found a related failure that needs to be addressed: https://buildkite.com/llvm-project/premerge-checks/builds/130589#0185ac99-1158-46b3-b6d1-52fcf5310a59

Can you also add a release note about the fix as well?