Page MenuHomePhabricator
People ghvg1313

ghvg1313 (Kanglei Fang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 2 2019, 1:52 PM (6 w, 5 d)

Recent Activity
View All

Wed, Jan 15

ghvg1313 added a comment to D70926: [clang-format] Add option for not breaking line before ObjC params.

@MyDeveloperDay gentle ping for help merging

Wed, Jan 15, 2:15 PM · Restricted Project

Mon, Jan 6

ghvg1313 added a comment to D70926: [clang-format] Add option for not breaking line before ObjC params.
In D70926#1790848, @MyDeveloperDay wrote:

Thanks for the patch.

Mon, Jan 6, 11:45 AM · Restricted Project

Dec 18 2019

ghvg1313 added inline comments to D70926: [clang-format] Add option for not breaking line before ObjC params.
Dec 18 2019, 2:38 PM · Restricted Project
ghvg1313 updated the diff for D70926: [clang-format] Add option for not breaking line before ObjC params.
  • Handle parameter break between blocks
  • Fix test cases and move them to objcTest
  • rebase
Dec 18 2019, 2:29 PM · Restricted Project

Dec 5 2019

ghvg1313 added a comment to D70926: [clang-format] Add option for not breaking line before ObjC params.

@MyDeveloperDay Anything I'll need to do on my end to start the landing process?

Dec 5 2019, 4:51 PM · Restricted Project

Dec 4 2019

ghvg1313 added a comment to D70926: [clang-format] Add option for not breaking line before ObjC params.
In D70926#1769437, @MyDeveloperDay wrote:

LGTM

A little advice as you fix each comment check the "Done" button.

I notice you are a new user, will you need help landing it?

Dec 4 2019, 11:37 AM · Restricted Project
ghvg1313 updated the diff for D70926: [clang-format] Add option for not breaking line before ObjC params.
  • Move documents from release notes to header and proper rst, register test
Dec 4 2019, 10:28 AM · Restricted Project

Dec 3 2019

ghvg1313 updated the diff for D70926: [clang-format] Add option for not breaking line before ObjC params.
  • rename option, remove handlers for nested block itself
Dec 3 2019, 1:21 PM · Restricted Project
ghvg1313 added inline comments to D70926: [clang-format] Add option for not breaking line before ObjC params.
Dec 3 2019, 1:21 PM · Restricted Project

Dec 2 2019

ghvg1313 updated the diff for D70926: [clang-format] Add option for not breaking line before ObjC params.
  • Update documents
Dec 2 2019, 3:30 PM · Restricted Project
ghvg1313 retitled D70926: [clang-format] Add option for not breaking line before ObjC params from Add option for not breaking line before ObjC params to [clang-format] Add option for not breaking line before ObjC params.
Dec 2 2019, 2:25 PM · Restricted Project
ghvg1313 removed a reviewer for D70926: [clang-format] Add option for not breaking line before ObjC params: klimek.
Dec 2 2019, 2:25 PM · Restricted Project
ghvg1313 created D70926: [clang-format] Add option for not breaking line before ObjC params.
Dec 2 2019, 2:20 PM · Restricted Project