Page MenuHomePhabricator
People ghvg1313

ghvg1313 (Kanglei Fang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 2 2019, 1:52 PM (140 w, 2 d)

Recent Activity
View All

May 15 2020

ghvg1313 accepted D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors.

Thanks for the fix!

May 15 2020, 2:09 PM · Restricted Project, Restricted Project

Apr 7 2020

ghvg1313 added a comment to D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam.
In D77039#1967224, @MyDeveloperDay wrote:

what is changing in clang/docs/ClangFormatStyleOptions.rst? if nothing then remove from the diff

Apr 7 2020, 10:50 AM · Restricted Project, Restricted Project

Apr 6 2020

ghvg1313 edited reviewers for D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam, added: jinlin; removed: MyDeveloperDay.
Apr 6 2020, 10:50 AM · Restricted Project, Restricted Project

Mar 31 2020

ghvg1313 added a comment to D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam.

@jolesiak I don't yet have the commit access, do you mind help merging this diff? Thanks

Mar 31 2020, 3:27 PM · Restricted Project, Restricted Project
ghvg1313 updated the diff for D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam.

reset diff's base

Mar 31 2020, 3:27 PM · Restricted Project, Restricted Project
ghvg1313 updated the diff for D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam.
  • Fix documentation formatting
Mar 31 2020, 3:27 PM · Restricted Project, Restricted Project

Mar 30 2020

ghvg1313 added a reviewer for D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam: MyDeveloperDay.
Mar 30 2020, 1:38 PM · Restricted Project, Restricted Project
ghvg1313 created D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam.
Mar 30 2020, 1:02 AM · Restricted Project, Restricted Project

Jan 24 2020

ghvg1313 updated the diff for D70926: [clang-format] Add option for not breaking line before ObjC params.
  • rebase master
Jan 24 2020, 11:38 AM · Restricted Project, Restricted Project
ghvg1313 added inline comments to D70926: [clang-format] Add option for not breaking line before ObjC params.
Jan 24 2020, 11:38 AM · Restricted Project, Restricted Project

Jan 21 2020

ghvg1313 updated the diff for D70926: [clang-format] Add option for not breaking line before ObjC params.
  • rebase master
  • formatting code
Jan 21 2020, 4:48 PM · Restricted Project, Restricted Project

Jan 15 2020

ghvg1313 added a comment to D70926: [clang-format] Add option for not breaking line before ObjC params.

@MyDeveloperDay gentle ping for help merging

Jan 15 2020, 2:15 PM · Restricted Project, Restricted Project

Jan 6 2020

ghvg1313 added a comment to D70926: [clang-format] Add option for not breaking line before ObjC params.
In D70926#1790848, @MyDeveloperDay wrote:

Thanks for the patch.

Jan 6 2020, 11:45 AM · Restricted Project, Restricted Project

Dec 18 2019

ghvg1313 added inline comments to D70926: [clang-format] Add option for not breaking line before ObjC params.
Dec 18 2019, 2:38 PM · Restricted Project, Restricted Project
ghvg1313 updated the diff for D70926: [clang-format] Add option for not breaking line before ObjC params.
  • Handle parameter break between blocks
  • Fix test cases and move them to objcTest
  • rebase
Dec 18 2019, 2:29 PM · Restricted Project, Restricted Project

Dec 5 2019

ghvg1313 added a comment to D70926: [clang-format] Add option for not breaking line before ObjC params.

@MyDeveloperDay Anything I'll need to do on my end to start the landing process?

Dec 5 2019, 4:51 PM · Restricted Project, Restricted Project

Dec 4 2019

ghvg1313 added a comment to D70926: [clang-format] Add option for not breaking line before ObjC params.
In D70926#1769437, @MyDeveloperDay wrote:

LGTM

A little advice as you fix each comment check the "Done" button.

I notice you are a new user, will you need help landing it?

Dec 4 2019, 11:37 AM · Restricted Project, Restricted Project
ghvg1313 updated the diff for D70926: [clang-format] Add option for not breaking line before ObjC params.
  • Move documents from release notes to header and proper rst, register test
Dec 4 2019, 10:28 AM · Restricted Project, Restricted Project

Dec 3 2019

ghvg1313 updated the diff for D70926: [clang-format] Add option for not breaking line before ObjC params.
  • rename option, remove handlers for nested block itself
Dec 3 2019, 1:21 PM · Restricted Project, Restricted Project
ghvg1313 added inline comments to D70926: [clang-format] Add option for not breaking line before ObjC params.
Dec 3 2019, 1:21 PM · Restricted Project, Restricted Project

Dec 2 2019

ghvg1313 updated the diff for D70926: [clang-format] Add option for not breaking line before ObjC params.
  • Update documents
Dec 2 2019, 3:30 PM · Restricted Project, Restricted Project
ghvg1313 retitled D70926: [clang-format] Add option for not breaking line before ObjC params from Add option for not breaking line before ObjC params to [clang-format] Add option for not breaking line before ObjC params.
Dec 2 2019, 2:25 PM · Restricted Project, Restricted Project
ghvg1313 removed a reviewer for D70926: [clang-format] Add option for not breaking line before ObjC params: klimek.
Dec 2 2019, 2:25 PM · Restricted Project, Restricted Project
ghvg1313 created D70926: [clang-format] Add option for not breaking line before ObjC params.
Dec 2 2019, 2:20 PM · Restricted Project, Restricted Project