Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

gbossu (Gaëtan Bossu)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2022, 12:20 AM (51 w, 18 h)

Recent Activity

Jun 14 2023

gbossu added a comment to D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files.

This broke regenerating checks for tests like test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgcn.s.buffer.load.ll which use -simplify-mir and do not print the fixedStack info. Can you fix update_mir_test_checks to cope, or should we remove -simplify-mir from files with generated checks?

Jun 14 2023, 2:02 AM · Restricted Project, Restricted Project

May 8 2023

gbossu added inline comments to D145169: FastRegAlloc: Fix implicit operands not rewritten.
May 8 2023, 3:58 AM · Restricted Project, Restricted Project

Apr 14 2023

gbossu added inline comments to D145169: FastRegAlloc: Fix implicit operands not rewritten.
Apr 14 2023, 5:38 AM · Restricted Project, Restricted Project
gbossu updated the diff for D145169: FastRegAlloc: Fix implicit operands not rewritten.

Re-process MachineOperands when kill/dead flags are added. Adding those on implicit operands might re-arrange the whole list of MOs in a MachineInstr.

Apr 14 2023, 5:29 AM · Restricted Project, Restricted Project

Mar 22 2023

gbossu added a comment to D145169: FastRegAlloc: Fix implicit operands not rewritten.

Any additional feedback?

Mar 22 2023, 2:15 PM · Restricted Project, Restricted Project

Mar 3 2023

gbossu added inline comments to D145169: FastRegAlloc: Fix implicit operands not rewritten.
Mar 3 2023, 7:51 AM · Restricted Project, Restricted Project

Mar 2 2023

gbossu updated the summary of D145169: FastRegAlloc: Fix implicit operands not rewritten.
Mar 2 2023, 9:27 AM · Restricted Project, Restricted Project
gbossu requested review of D145169: FastRegAlloc: Fix implicit operands not rewritten.
Mar 2 2023, 9:26 AM · Restricted Project, Restricted Project

Jan 23 2023

gbossu added inline comments to D137653: [TableGen] More named sub-operands work..
Jan 23 2023, 6:55 AM · Restricted Project, Restricted Project

Jan 10 2023

gbossu added inline comments to D137653: [TableGen] More named sub-operands work..
Jan 10 2023, 8:27 AM · Restricted Project, Restricted Project

Dec 1 2022

gbossu added a comment to D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files.

@nhaehnle @arsenm Thank you for having a look at this patch. I unfortunately don't have commit "powers", would it be possible for one of you to commit on my behalf?
Here is the commit header I usually have: Gaëtan Bossu <gaetan.bossu@amd.com>, if you need it. Thank you in advance :)

Dec 1 2022, 1:07 AM · Restricted Project, Restricted Project
gbossu added a comment to D135580: utils/update_mir_test_checks.py: support UTC_ARGS.

Rebase on latest main, otherwise tests seem to timeout.

You can ignore the libfuzzer test failure - it's unrelated. I filed https://github.com/llvm/llvm-project/issues/59197 a few days ago since I noticed it failing on almost all reviews.

Dec 1 2022, 12:53 AM · Restricted Project, Restricted Project

Nov 30 2022

gbossu updated the diff for D135580: utils/update_mir_test_checks.py: support UTC_ARGS.

Rebase on latest main, otherwise tests seem to timeout.

Nov 30 2022, 8:45 AM · Restricted Project, Restricted Project
gbossu updated the diff for D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files.

Rebase on latest main, otherwise tests seem to timeout.

Nov 30 2022, 8:44 AM · Restricted Project, Restricted Project
gbossu added inline comments to D135580: utils/update_mir_test_checks.py: support UTC_ARGS.
Nov 30 2022, 2:02 AM · Restricted Project, Restricted Project
gbossu updated the diff for D135580: utils/update_mir_test_checks.py: support UTC_ARGS.

Remove print-stack-update.mir test input file and just re-run update_mir_test_checks on the existing file instead.

Nov 30 2022, 2:01 AM · Restricted Project, Restricted Project

Nov 23 2022

gbossu added inline comments to D135580: utils/update_mir_test_checks.py: support UTC_ARGS.
Nov 23 2022, 3:08 AM · Restricted Project, Restricted Project

Nov 16 2022

gbossu added a comment to D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files.

Thank you! Could someone commit the change on my behalf? I do not think I have write access, since it's my first patch here.

Nov 16 2022, 11:36 PM · Restricted Project, Restricted Project

Nov 11 2022

gbossu updated the diff for D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files.

Fix coding style & useless assignment

Nov 11 2022, 2:34 AM · Restricted Project, Restricted Project

Nov 3 2022

gbossu added a reviewer for D135580: utils/update_mir_test_checks.py: support UTC_ARGS: nhaehnle.
Nov 3 2022, 5:55 AM · Restricted Project, Restricted Project
gbossu added inline comments to D135580: utils/update_mir_test_checks.py: support UTC_ARGS.
Nov 3 2022, 5:55 AM · Restricted Project, Restricted Project
gbossu added inline comments to D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files.
Nov 3 2022, 5:51 AM · Restricted Project, Restricted Project
gbossu added reviewers for D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files: nhaehnle, arsenm.
Nov 3 2022, 3:07 AM · Restricted Project, Restricted Project

Oct 10 2022

gbossu updated the summary of D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files.
Oct 10 2022, 7:03 AM · Restricted Project, Restricted Project
gbossu requested review of D135580: utils/update_mir_test_checks.py: support UTC_ARGS.
Oct 10 2022, 6:54 AM · Restricted Project, Restricted Project
gbossu updated the diff for D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files.

Update email address in commit...

Oct 10 2022, 6:49 AM · Restricted Project, Restricted Project
gbossu requested review of D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files.
Oct 10 2022, 6:43 AM · Restricted Project, Restricted Project