garvitgupta08 (garvit gupta)
User

Projects

User does not belong to any projects.

User Details

User Since: Feb 7 2023, 12:07 PM (16 w, 2 d)

Recent Activity
View All

Today

garvitgupta08 added reviewers for D151898: [RISCV] Guard Advance Interrupt Architecture CSRs with Smaia and Ssaia extensions.: kito-cheng, 4vtomat.

Fri, Jun 2, 2:27 AM · Restricted Project, Restricted Project

garvitgupta08 added a comment to D151898: [RISCV] Guard Advance Interrupt Architecture CSRs with Smaia and Ssaia extensions..

In D151898#4388317, @jrtc27 wrote:

I don't think we want to do this. There's precedent for making all CSRs always visible, and it does little harm to expose them. Requiring OSes to specify -march=ssfoo_ssbar_ssbaz_... to do anything useful is just a waste of everyone's time IMO, and often wrong because OSes don't want to require those extensions, they just want to support them if present, so then you instead have to .option arch, +ssfoo all over the place. Or people will just use the numeric values instead of the names, which then makes the code less readable.

Fri, Jun 2, 2:19 AM · Restricted Project, Restricted Project

Yesterday

garvitgupta08 requested review of D151898: [RISCV] Guard Advance Interrupt Architecture CSRs with Smaia and Ssaia extensions..

Thu, Jun 1, 9:30 AM · Restricted Project, Restricted Project

Mon, May 29

garvitgupta08 added a comment to D150133: [RISCV] Support constant immediate for la pseudo instruction.

An update on the new changes will be appreciated!. Thanks

Mon, May 29, 10:09 AM · Restricted Project, Restricted Project

Wed, May 24

garvitgupta08 added a comment to D150133: [RISCV] Support constant immediate for la pseudo instruction.

Hi @jrtc27, I have pushed new changes per your comments. Please have a look.

Wed, May 24, 9:14 AM · Restricted Project, Restricted Project

Mon, May 22

garvitgupta08 updated the diff for D150133: [RISCV] Support constant immediate for la pseudo instruction.

Mon, May 22, 10:58 PM · Restricted Project, Restricted Project

garvitgupta08 updated the diff for D150133: [RISCV] Support constant immediate for la pseudo instruction.

Mon, May 22, 10:08 PM · Restricted Project, Restricted Project

garvitgupta08 added inline comments to D150133: [RISCV] Support constant immediate for la pseudo instruction.

Mon, May 22, 10:06 PM · Restricted Project, Restricted Project

garvitgupta08 added a comment to D150133: [RISCV] Support constant immediate for la pseudo instruction.

Hi @jrtc27 @asb, I have pushed new changes in accordance with your previous comments. Can you please check and provide an update on the same? Thanks

Mon, May 22, 9:10 AM · Restricted Project, Restricted Project

Thu, May 18

garvitgupta08 updated the diff for D150133: [RISCV] Support constant immediate for la pseudo instruction.

Thu, May 18, 11:48 PM · Restricted Project, Restricted Project

garvitgupta08 updated the summary of D150133: [RISCV] Support constant immediate for la pseudo instruction.

Thu, May 18, 10:21 AM · Restricted Project, Restricted Project

garvitgupta08 updated the summary of D150133: [RISCV] Support constant immediate for la pseudo instruction.

Thu, May 18, 9:19 AM · Restricted Project, Restricted Project

garvitgupta08 updated the diff for D150133: [RISCV] Support constant immediate for la pseudo instruction.

Change la with constant immediate expand to lui + addi - same as what GNU assembler do.

Thu, May 18, 9:15 AM · Restricted Project, Restricted Project

Thu, May 11

garvitgupta08 added a comment to D150133: [RISCV] Support constant immediate for la pseudo instruction.

In D150133#4334850, @jrtc27 wrote:

Using AUIPC to generate an absolute address (which is how GNU people seem to justify this ugly ability) sounds wrong

Thu, May 11, 7:32 AM · Restricted Project, Restricted Project

garvitgupta08 updated the diff for D150133: [RISCV] Support constant immediate for la pseudo instruction.

Thu, May 11, 7:31 AM · Restricted Project, Restricted Project

garvitgupta08 updated the diff for D150133: [RISCV] Support constant immediate for la pseudo instruction.

Fixing Premerge checks

Thu, May 11, 6:27 AM · Restricted Project, Restricted Project

Tue, May 9

garvitgupta08 updated the diff for D150133: [RISCV] Support constant immediate for la pseudo instruction.

Fixing premerge checks

Tue, May 9, 3:27 AM · Restricted Project, Restricted Project

garvitgupta08 updated the diff for D150133: [RISCV] Support constant immediate for la pseudo instruction.

Tue, May 9, 2:57 AM · Restricted Project, Restricted Project

Mon, May 8

garvitgupta08 updated the summary of D150133: [RISCV] Support constant immediate for la pseudo instruction.

Mon, May 8, 11:51 AM · Restricted Project, Restricted Project

garvitgupta08 retitled D150133: [RISCV] Support constant immediate for la pseudo instruction from [RISCV] Support constant immediate for la pseudoinstruction to [RISCV] Support constant immediate for la pseudo instruction.

Mon, May 8, 11:51 AM · Restricted Project, Restricted Project

garvitgupta08 updated the summary of D150133: [RISCV] Support constant immediate for la pseudo instruction.

Mon, May 8, 11:46 AM · Restricted Project, Restricted Project

garvitgupta08 requested review of D150133: [RISCV] Support constant immediate for la pseudo instruction.

Mon, May 8, 11:44 AM · Restricted Project, Restricted Project

Mar 28 2023

garvitgupta08 added inline comments to D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

Mar 28 2023, 8:29 PM · Restricted Project, Restricted Project

garvitgupta08 added a comment to D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

In D145726#4228406, @MaskRay wrote:

Please update the commit message and comment about what binutils versions reject the construct.

Mar 28 2023, 8:28 PM · Restricted Project, Restricted Project

garvitgupta08 added a comment to D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

In D145726#4228216, @nickdesaulniers wrote:

@garvitgupta08 what's your email address so that I may attribute your authorship correctly when committing on your behalf?

Mar 28 2023, 12:03 PM · Restricted Project, Restricted Project

Mar 27 2023

garvitgupta08 added a comment to D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

I do not have the commit access, can you commit on my behalf @nickdesaulniers

Mar 27 2023, 11:22 AM · Restricted Project, Restricted Project

garvitgupta08 added inline comments to D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

Mar 27 2023, 11:07 AM · Restricted Project, Restricted Project

Mar 25 2023

garvitgupta08 added inline comments to D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

Mar 25 2023, 11:31 AM · Restricted Project, Restricted Project

garvitgupta08 updated the diff for D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

Mar 25 2023, 11:31 AM · Restricted Project, Restricted Project

Mar 21 2023

garvitgupta08 added inline comments to D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

Mar 21 2023, 3:10 PM · Restricted Project, Restricted Project

garvitgupta08 added a comment to D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

In D145726#4194142, @nickdesaulniers wrote:

The description needs to be rewritten to elucidate that this is purely to support old versions of the GNU assembler still in use by various Linux LTS distros. This problem does not exist for folks using up to date tooling. I would like to see specific GNU assembler version details in the commit description as well.

Mar 21 2023, 3:08 PM · Restricted Project, Restricted Project

garvitgupta08 updated the summary of D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

Mar 21 2023, 3:07 PM · Restricted Project, Restricted Project

garvitgupta08 updated the diff for D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

Mar 21 2023, 3:06 PM · Restricted Project, Restricted Project