Page MenuHomePhabricator

fweimer (Florian Weimer)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 14 2018, 1:53 AM (211 w, 4 d)

Recent Activity

Feb 28 2022

fweimer added a comment to D120243: allow for contention free exception unwinding.

On glibc 2.35 and later, you can use _dl_find_object. It's also fully lock-free.

Feb 28 2022, 4:16 AM · Restricted Project, Restricted Project

Feb 8 2022

fweimer requested review of D119293: [sanitizer] Avoid dlsym reference for SANITIZER_GO builds.
Feb 8 2022, 2:41 PM · Restricted Project, Restricted Project

Feb 7 2022

fweimer added a comment to D119007: [sanitizer] Use _thread_db_sizeof_pthread to obtain struct pthread size.

Would someone please commit this patch for me? Thanks.

I'd like a sanitizer maintainer (e.g. @vitalybuka) to have a look.

Feb 7 2022, 3:04 AM · Restricted Project

Feb 4 2022

fweimer added a comment to D119007: [sanitizer] Use _thread_db_sizeof_pthread to obtain struct pthread size.

Would someone please commit this patch for me? Thanks.

Feb 4 2022, 2:09 PM · Restricted Project
fweimer updated the summary of D119007: [sanitizer] Use _thread_db_sizeof_pthread to obtain struct pthread size.
Feb 4 2022, 10:12 AM · Restricted Project
fweimer updated the diff for D119007: [sanitizer] Use _thread_db_sizeof_pthread to obtain struct pthread size.
Feb 4 2022, 10:01 AM · Restricted Project
fweimer requested review of D119007: [sanitizer] Use _thread_db_sizeof_pthread to obtain struct pthread size.
Feb 4 2022, 8:38 AM · Restricted Project

Nov 29 2021

fweimer added a comment to D40319: [libcxx] Support getentropy as a source of randomness for std::random_device.

getentropy comes from OpenBSD (among others), and it's in <unistd.h> there: https://man.openbsd.org/getentropy.2

Nov 29 2021, 12:06 PM

Jun 29 2021

fweimer added inline comments to D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64.
Jun 29 2021, 11:02 AM · Restricted Project

Feb 26 2019

fweimer added a comment to D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD.

I don't think you added a new command line option. My suggestion was this:

  1. Add a new command line option, say, --intel-cet (that's perhaps not the final name of the option, I chose it tentatively to move things forward.)
  2. If --intel-cet is given, verify that each input file contains a .note section with an appropriate bit, and discard .note section after reading it (so we don't merge them or copy them to the output file). If there's a file that doesn't contain a proper .note, report an error and stop.
  3. When creating an input file, create a .note section with appropriate contents when --intel-cet was given.

Specifically, I don't think you should add a new member X86Feature1AND to Config because with the above scheme you are no longer merging .note section so you don't need to collect bits. mergeAggregateMetadata should also be deleted from the patch.

What do you think?

Feb 26 2019, 10:32 PM · Restricted Project, lld