Page MenuHomePhabricator

ftingaud (Frederic Tingaud)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 26 2018, 7:52 AM (103 w, 4 d)

Recent Activity

Mar 20 2018

ftingaud added a comment to D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique.

Hi,
Yes please!

Mar 20 2018, 1:08 PM · Restricted Project

Mar 14 2018

ftingaud updated the diff for D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique.

Clean code along code review recommendations.

Mar 14 2018, 10:11 AM · Restricted Project
ftingaud added a comment to D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique.

I think all requested modifications were done.

Mar 14 2018, 8:05 AM · Restricted Project

Mar 1 2018

ftingaud added inline comments to D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique.
Mar 1 2018, 10:51 AM · Restricted Project
ftingaud updated the diff for D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique.

Remove customizable c++ version that added no real value.

Mar 1 2018, 10:47 AM · Restricted Project
ftingaud added inline comments to D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique.
Mar 1 2018, 12:44 AM · Restricted Project

Feb 28 2018

ftingaud updated the diff for D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique.

Correct case of custom make_unique functions that should still work in c++11.

Feb 28 2018, 5:53 AM · Restricted Project
ftingaud updated the diff for D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique.

Apply clang-format on changelist.

Feb 28 2018, 1:29 AM · Restricted Project

Feb 27 2018

ftingaud updated the diff for D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique.

Remove two useless namespaces

Feb 27 2018, 9:47 AM · Restricted Project
ftingaud updated the diff for D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique.

Update with tests and cleaning as indicated by reviewers.

Feb 27 2018, 9:44 AM · Restricted Project

Feb 26 2018

ftingaud created D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique.
Feb 26 2018, 9:02 AM · Restricted Project