- User Since
- Nov 5 2014, 11:06 AM (394 w, 3 d)
Feb 7 2015
Thanks for doing the LLVM tutorial, but this code clearly needs more work :)
Nov 10 2014
Nov 7 2014
[Responding to feedback]
Updated the test case to be better directed (specifically testing externally_initialized and appending attributes). Moved the fix to be in GlobalVariable::copyAttributesFrom instead of at the copy site.
Nov 6 2014
Fair enough. I'll go ahead & update the diff with the fix moved into copyAttributesFrom, and fix up handful of missing attributes in GlobalObject and GlobalValue, too.
The reason I wasn't sure which was correct is because isExternallyIntialized is a default ctor parameter, so if someone's specifying a different value, then calling the copyAttributesFrom to fill in everything else, it's a bug. From a design perspective, having an API like copyAttributesFrom for a type with a ctor that has default parameters seems incredibly confusing. Perhaps I should eliminate the default parameter? And maybe this discussion should move over to llvmdev?
Nov 5 2014
@rnk: I considered both, and am new to the codebase, so the 'correct' place to fix this wasn't apparent. Does anyone else have an opinion, here? Either way is effective, and pretty straightforward as well.
Missed the new test file...