User Details
- User Since
- Jul 4 2017, 6:15 AM (308 w, 3 d)
Nov 15 2021
I found this problem (PR49022) when running some regression test for an out of tree target.
So, what is the status of patch?
Any reason this hasn't been committed?
Jan 12 2021
This works for me
Jan 11 2021
Thanks, adding the !cast<int> remove the problem. But it would be nice to be able to convert from bit to string automatically otherwise I would need to add the !cast<int> at dozen of places.
The identifier come from tablegen class parameter:
I had to add 'field' for something like: ( out of tree target)
field string BaseOpcodeSTSrcKind;
...
let BaseOpcodeSTSrcKind = asmstr # opVal # DataSize # PtrMode #
OffsetMode # isSub # isDS # "_ri7";
The llvm tablegen reference guide says the keyword *field* is deprecated.
Is this still valid?
Oct 23 2020
What is the status of this patch?
Can it be committed?
It helps for our out of tree fork of lldb.
Sep 8 2020
Another thing: I noticed that SelectionDAG::computeKnownBits doesn't deal with ISD::FREEZE.
Would it be ok to just call computeKnownBits (Op.getOperand(0)) to make it work.
(Since Select_FREEZE just lower to a copy)
Sep 7 2020
What is the status of this patch?
I've seen cases in a out of tree target where an optimization dependent on ValueTracking was not performed because there was a freeze in the way.
May 29 2020
I am working on an out of tree target and this would be useful.
So what is the status of this patch?
Jan 15 2019
I tried your patch and the bug is gone. Thanks.
Jan 14 2019
For example:
Jan 13 2019
I recently resynced an out of tree backend and I got a miscompile because of this commit.
My target is Big Endian.
The C code is :
void swap(unsigned *ptr) { *ptr = (*ptr & 0x0000ff00 ) << 8; }
Jul 25 2017
Jul 17 2017
is it ok to commit now?
Jul 11 2017
Update patch with fix for endianness bug in visitEXTRACT_VECTOR_ELT.
Update patch taking into account vector size > 2
Also reuse existing isLE variable.
Jul 5 2017
Added test case