Page MenuHomePhabricator

foutrelis (Evangelos Foutras)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2015, 2:26 AM (167 w, 6 d)

Recent Activity

Aug 16 2018

foutrelis added a comment to D50416: [cmake] Prevent LLVMgold.so from being unloaded on Linux.

This proposed change might avoid triggering the reloading issue with the LLVM gold plugin. (At least the simple ar r ab.a a.o b.o from my previous comment doesn't trigger it.)

Aug 16 2018, 7:39 AM
foutrelis added a comment to D50416: [cmake] Prevent LLVMgold.so from being unloaded on Linux.

Yes, someone please commit this for me.

Aug 16 2018, 7:05 AM

Aug 8 2018

foutrelis added a comment to D50416: [cmake] Prevent LLVMgold.so from being unloaded on Linux.

Also, are you maybe aware of how soon is this going to hit binutils users? It kinda looks like a ticking time bomb, so maybe it would be worth fixing it for LLVM 7 release as well.

Aug 8 2018, 6:38 AM
foutrelis added a comment to D50416: [cmake] Prevent LLVMgold.so from being unloaded on Linux.

I don't really know BFD plugin API, so I don't know if this could have any implications (I suppose upstream's answer may be helpful there). However, I don't think it likely to cause any real trouble.

Aug 8 2018, 6:11 AM

Aug 7 2018

foutrelis added a comment to D50416: [cmake] Prevent LLVMgold.so from being unloaded on Linux.

Does this make sense or could it cause issues with other modules? I haven't thought of possible implications, but it seems to work OK when tested on top of LLVM 6.0.1.

Aug 7 2018, 4:01 PM
foutrelis created D50416: [cmake] Prevent LLVMgold.so from being unloaded on Linux.
Aug 7 2018, 3:54 PM

May 10 2018

foutrelis added a comment to D30997: CMake: Add LLVM_DYLIB_SYMBOL_VERSIONING option.

I think this option should be dropped. When I added it, I was unaware of D31524, which was being developed at the same time.

May 10 2018, 7:35 PM
foutrelis added a comment to D30997: CMake: Add LLVM_DYLIB_SYMBOL_VERSIONING option.

Apologies for the random a-year-later comment, but how does this relate to D31524 (which already seems to version libLLVM.so's symbols)?

May 10 2018, 6:51 PM

Mar 13 2018

foutrelis added a comment to D44391: Export LLVM_DYLIB_COMPONENTS in LLVMConfig.cmake.

You have a point that any further tweaks to llvm_config should be created and reviewed separately. What I described above is not too great either; it shouldn't be required to specify USE_SHARED.

Mar 13 2018, 9:44 AM
foutrelis added a comment to D44420: [cmake] fix a typo in llvm_config macro.

+1 from me; it fixes llvm_config(foo USE_SHARED ...) for out-of-tree builds.

Mar 13 2018, 5:43 AM

Mar 12 2018

foutrelis added a comment to D44391: Export LLVM_DYLIB_COMPONENTS in LLVMConfig.cmake.

One more observation: It might be preferable to avoid defining set(LLVM_DYLIB_COMPONENTS all) in non-DYLIB builds. It prevents llvm_config(foo USE_SHARED ...) from opportunistically linking to the DYLIB while still having the static libraries as a fallback.

Mar 12 2018, 3:40 PM
foutrelis added a comment to D44391: Export LLVM_DYLIB_COMPONENTS in LLVMConfig.cmake.

Scratch that, I see what's going on! The body of the llvm_config macro needs to check if(ARG_USE_SHARED) instead of if(USE_SHARED).

Mar 12 2018, 2:57 PM
foutrelis added a comment to D44391: Export LLVM_DYLIB_COMPONENTS in LLVMConfig.cmake.

This change seems to make llvm_config() usable for out-of-tree builds, neat! I tried a standalone build of LLDB and it works fine after having rebuilt llvm with this change.

Mar 12 2018, 2:44 PM

May 7 2016

foutrelis added inline comments to D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support.
May 7 2016, 8:17 AM

Jan 15 2016

foutrelis added a comment to D12834: add gcc abi_tag support.

The latest patch still applies (relatively cleanly) to Clang 3.7.x which is nice. The infinite recursion segfaults appear to be gone, thanks!

Jan 15 2016, 5:40 AM

Dec 26 2015

foutrelis added a comment to D12834: add gcc abi_tag support.

We have received a few reports of clang crashes after applying the abi_tag support patch to our llvm/clang package in Arch Linux.

Why would you put a patch clearly marked as "needs review" into a distribution?!?!?!?!

Dec 26 2015, 8:46 AM

Dec 16 2015

foutrelis added a comment to D12834: add gcc abi_tag support.

We have received a few reports of clang crashes after applying the abi_tag support patch to our llvm/clang package in Arch Linux.

Dec 16 2015, 6:03 AM

Oct 1 2015

foutrelis updated subscribers of D12834: add gcc abi_tag support.
Oct 1 2015, 12:48 AM

Sep 28 2015

foutrelis added a comment to D13206: Add clang-query tool to installation targets.

Thanks for the review.

Sep 28 2015, 6:24 AM
foutrelis added a comment to D13206: Add clang-query tool to installation targets.

Just a note that this change is specific to CMake since autotools already installs clang-query (along with some other tools).

Sep 28 2015, 2:55 AM
foutrelis retitled D13206: Add clang-query tool to installation targets from to Add clang-query tool to installation targets.
Sep 28 2015, 2:50 AM