Page MenuHomePhabricator

flip1995 (Philipp Krones)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 26 2021, 9:04 AM (21 w, 4 d)

Recent Activity

Fri, Jul 16

flip1995 added a comment to D105976: [Inliner] Make the CallPenalty configurable.

Is there anything for me to do on the CI failures? I can't reproduce them locally and I can't really tell how they could be caused by this revision, since it doesn't change anything about the default behavior.

Fri, Jul 16, 6:23 AM · Restricted Project

Thu, Jul 15

flip1995 added a comment to D102052: [MC][RISCV] Add RISCV MCObjectFileInfo.

ping

Thu, Jul 15, 12:51 AM · Restricted Project

Wed, Jul 14

flip1995 published D105976: [Inliner] Make the CallPenalty configurable for review.
Wed, Jul 14, 6:42 AM · Restricted Project

Mon, Jun 28

flip1995 added a comment to D102052: [MC][RISCV] Add RISCV MCObjectFileInfo.

I just cannot find sufficient justification for such a change.

Mon, Jun 28, 6:46 AM · Restricted Project

Jun 1 2021

flip1995 updated the diff for D102052: [MC][RISCV] Add RISCV MCObjectFileInfo.

Fixed clang-tidy error

Jun 1 2021, 4:01 AM · Restricted Project
flip1995 updated the diff for D102052: [MC][RISCV] Add RISCV MCObjectFileInfo.

addressed review comments and rebased

Jun 1 2021, 3:58 AM · Restricted Project

May 26 2021

flip1995 added inline comments to D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo.
May 26 2021, 3:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
flip1995 added inline comments to D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo.
May 26 2021, 2:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 25 2021

flip1995 published D102052: [MC][RISCV] Add RISCV MCObjectFileInfo for review.
May 25 2021, 5:05 AM · Restricted Project

May 14 2021

flip1995 updated the diff for D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo.
  • [MC] Don't check if constructed MOFI is a nullptr
May 14 2021, 7:06 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 13 2021

flip1995 added a comment to D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo.

Can createMCObjectFileInfo return MCObjectFileInfo instead of std::unique_ptr<MCObjectFileInfo>?

May 13 2021, 1:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 12 2021

flip1995 updated the diff for D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo.

rebased and addressed review comments:

May 12 2021, 9:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
flip1995 added inline comments to D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo.
May 12 2021, 7:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 7 2021

flip1995 updated the diff for D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo.

Remove redundant item names in doc comments

May 7 2021, 1:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
flip1995 added a comment to D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo.

Can you post the RISCV patch depending on this one?

May 7 2021, 1:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
flip1995 added inline comments to D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo.
May 7 2021, 1:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
flip1995 added a comment to D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo.
May 7 2021, 1:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 6 2021

flip1995 published D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo for review.
May 6 2021, 7:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 5 2021

flip1995 updated the diff for D101462: [MC] Untangle MCContext and MCObjectFileInfo.

rebased

May 5 2021, 8:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 3 2021

flip1995 added a comment to D101462: [MC] Untangle MCContext and MCObjectFileInfo.

I'll keep this open for a few days as it touches too many things.

May 3 2021, 10:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
flip1995 added a comment to D101462: [MC] Untangle MCContext and MCObjectFileInfo.

Not sure how the process from here on out is. I think it is important to note, that I don't have push rights and someone else will have to land this for me (I guess?).

May 3 2021, 9:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
flip1995 updated the diff for D101462: [MC] Untangle MCContext and MCObjectFileInfo.

Fix arc mistake...

May 3 2021, 4:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
flip1995 updated the diff for D101462: [MC] Untangle MCContext and MCObjectFileInfo.

Rename InitMCObjectFileInfo and reorder arguments

May 3 2021, 4:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
flip1995 retitled D101462: [MC] Untangle MCContext and MCObjectFileInfo from Make it possible for targets to define their own MCObjectFileInfo to [MC] Untangle MCContext and MCObjectFileInfo.
May 3 2021, 3:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
flip1995 updated the diff for D101462: [MC] Untangle MCContext and MCObjectFileInfo.

[MC] Untangle MCContext and MCObjectFileInfo

May 3 2021, 3:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 30 2021

flip1995 added a comment to D101462: [MC] Untangle MCContext and MCObjectFileInfo.

The refactoring adding Triple to MCContext::MCContext [...] should be separate.

Apr 30 2021, 2:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 29 2021

flip1995 added a comment to D101462: [MC] Untangle MCContext and MCObjectFileInfo.

Thanks for the review! I already thought that I will have to split this up, so I made the commits self contained so I'll do that. One question before I start:

Apr 29 2021, 5:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 28 2021

flip1995 requested review of D101462: [MC] Untangle MCContext and MCObjectFileInfo.
Apr 28 2021, 7:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project