User Details
User Details
- User Since
- Nov 10 2022, 5:31 AM (20 w, 4 h)
Mon, Mar 27
Mon, Mar 27
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.
Some additional thoughts I had a while ago about something I have raised before:
I think the warnings which can only be fixed with c++14 should either only be issued if that standard was specified or be behind an option. We have lots of lambda captures which could be moved with c++14 and having those warnings would lead to lots of suppressions within the code since we only target c++11.
Nov 19 2022
Nov 19 2022
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.
Nov 18 2022
Nov 18 2022
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.
The crash is gone.
Nov 10 2022
Nov 10 2022
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.
I am also experiencing a crash:
#include <string> #include <list>
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.
Another false positive:
#include <unordered_map>
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.
Getting this false positive:
#include <string>