Page MenuHomePhabricator

firewave (Oliver Stöneberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 10 2022, 5:31 AM (20 w, 4 h)

Recent Activity

Mon, Mar 27

firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.

Yes, I agree, while I can't understand, why someone still wants to use only c++11 I can totally understand, that a single Software Engineer can't do anything about this, when the corporation does not permit it.
But it should not be removed, since this warning can still show some pitfalls in performance critical code. A way in c++11 to fix the warning, is to create a functor, instead of a lambda.

Mon, Mar 27, 11:24 AM · Restricted Project, Restricted Project
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.

Some additional thoughts I had a while ago about something I have raised before:
I think the warnings which can only be fixed with c++14 should either only be issued if that standard was specified or be behind an option. We have lots of lambda captures which could be moved with c++14 and having those warnings would lead to lots of suppressions within the code since we only target c++11.

Mon, Mar 27, 7:28 AM · Restricted Project, Restricted Project

Nov 19 2022

firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.

I still have another false positive with static variables but have not gotten around reducing it yet.

Nov 19 2022, 1:07 PM · Restricted Project, Restricted Project

Nov 18 2022

firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.

Does only a warning appear? Or also a fix? Currently, only a warning should appear, but this is not fixable in c++11.

Nov 18 2022, 9:14 AM · Restricted Project, Restricted Project
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.

The crash is gone.

Nov 18 2022, 6:48 AM · Restricted Project, Restricted Project

Nov 10 2022

firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.

I am also experiencing a crash:

#include <string>
#include <list>
Nov 10 2022, 12:30 PM · Restricted Project, Restricted Project
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.

Another false positive:

#include <unordered_map>
Nov 10 2022, 12:15 PM · Restricted Project, Restricted Project
firewave added a comment to D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.

Getting this false positive:

#include <string>
Nov 10 2022, 12:03 PM · Restricted Project, Restricted Project