Page MenuHomePhabricator

fez (Pietro Fezzardi)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2019, 9:31 AM (73 w, 6 d)

Recent Activity

Jun 8 2020

fez added a comment to D81269: Fix null pointer dereference in `ProfileSummaryInfo::getPSI()`.

Ok then. I'll drop this patch. Is there a way to close the diff?

Jun 8 2020, 9:32 PM · Restricted Project

Jun 5 2020

fez added a comment to D81269: Fix null pointer dereference in `ProfileSummaryInfo::getPSI()`.

Can you revert D54669 and remove the pointer to reference change and recommit?

Jun 5 2020, 4:50 PM · Restricted Project
fez added a comment to D81269: Fix null pointer dereference in `ProfileSummaryInfo::getPSI()`.
In D81269#2077071, @vsk wrote:

When is a null PSI accessed? It's not clear to me how this happens (based on ProfileSummaryInfoWrapperPass::doInitialization).

Could you share a reduced regression test that reproduces the crash without this patch applied?

Jun 5 2020, 4:48 PM · Restricted Project
fez updated the summary of D81269: Fix null pointer dereference in `ProfileSummaryInfo::getPSI()`.
Jun 5 2020, 10:35 AM · Restricted Project
fez updated the summary of D81269: Fix null pointer dereference in `ProfileSummaryInfo::getPSI()`.
Jun 5 2020, 10:35 AM · Restricted Project
fez updated the diff for D81269: Fix null pointer dereference in `ProfileSummaryInfo::getPSI()`.

Updated the patch to build on master. The previous one did not apply cleanly to trunk.

Jun 5 2020, 10:35 AM · Restricted Project
fez added a comment to D81269: Fix null pointer dereference in `ProfileSummaryInfo::getPSI()`.

I added @vsk as a reviewer, because he's the one who accepted the patch set that introduced the code that causes the bug.

Jun 5 2020, 9:25 AM · Restricted Project
fez added a reviewer for D81269: Fix null pointer dereference in `ProfileSummaryInfo::getPSI()`: vsk.
Jun 5 2020, 9:25 AM · Restricted Project
fez created D81269: Fix null pointer dereference in `ProfileSummaryInfo::getPSI()`.
Jun 5 2020, 9:25 AM · Restricted Project

Mar 6 2019

fez added inline comments to D59005: Fix memory leak in CreateSigAltStack.
Mar 6 2019, 4:38 PM · Restricted Project
fez added inline comments to D59005: Fix memory leak in CreateSigAltStack.
Mar 6 2019, 4:18 PM · Restricted Project
fez added a comment to D59005: Fix memory leak in CreateSigAltStack.

if you deliver another signal after unregistering all of them, you get the behavior you observed? I'm not sure whether we care about clang-as-a-library being loaded / unloaded in the same program. If not, we could limit signal registration to be a one-time thing.

Mar 6 2019, 2:50 PM · Restricted Project
fez added a comment to D59005: Fix memory leak in CreateSigAltStack.

But now I'm puzzled by this check.

// If the handlers are already registered, we're done.
if (NumRegisteredSignals.load() != 0)
  return;
Mar 6 2019, 1:29 PM · Restricted Project
fez added a comment to D59005: Fix memory leak in CreateSigAltStack.

Is the mutex wrong? It should ensure that the alt stack is only ever set up once.

Mar 6 2019, 1:12 PM · Restricted Project

Mar 5 2019

fez added inline comments to D59005: Fix memory leak in CreateSigAltStack.
Mar 5 2019, 4:08 PM · Restricted Project
fez created D59005: Fix memory leak in CreateSigAltStack.
Mar 5 2019, 4:01 PM · Restricted Project