Page MenuHomePhabricator

fcloutier (Félix Cloutier)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 29 2021, 10:57 AM (68 w, 2 d)

Recent Activity

Thu, May 12

fcloutier committed rG91ed7e194181: [clang] Allow all string types for all attribute(format) styles (authored by fcloutier).
[clang] Allow all string types for all attribute(format) styles
Thu, May 12, 11:13 AM · Restricted Project, Restricted Project
fcloutier closed D125254: [clang] Allow all string types for all attribute(format) styles.
Thu, May 12, 11:13 AM · Restricted Project, Restricted Project

Mon, May 9

fcloutier requested review of D125254: [clang] Allow all string types for all attribute(format) styles.
Mon, May 9, 11:55 AM · Restricted Project, Restricted Project

Jan 5 2022

fcloutier accepted D116635: Add warning to detect when calls passing arguments are made to functions without prototypes..

I think that this is a good warning and I'll defer to the experts for what has to happen when prototypes merge with K&R definitions :)

Jan 5 2022, 8:35 AM · Restricted Project, Restricted Project

Nov 12 2021

fcloutier committed rG12ab3e6c8402: format_arg attribute does not support nullable instancetype return type (authored by fcloutier).
format_arg attribute does not support nullable instancetype return type
Nov 12 2021, 1:41 PM
fcloutier closed D113636: format_arg attribute does not support nullable instancetype return type.
Nov 12 2021, 1:41 PM · Restricted Project

Nov 10 2021

fcloutier requested review of D113636: format_arg attribute does not support nullable instancetype return type.
Nov 10 2021, 6:10 PM · Restricted Project

Oct 29 2021

fcloutier added a comment to D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`.

Thanks Arthur for your feedback.

Oct 29 2021, 5:25 PM · Restricted Project
fcloutier added a comment to D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`.

Thanks for looking, Aaron. You're right that the main utility of the aggregation of format warnings is to extend C's type checking because there is no other good way, or good place, to do it. I have built hundreds of millions of shipping lines of C, C++ and Objective-C, and this change seems like it would be an effective fix in several places where we don't currently have anywhere else to go.

Oct 29 2021, 3:34 PM · Restricted Project

Oct 28 2021

fcloutier committed rG6a5f7437720e: format_arg attribute should allow instancetype in NSString definition (authored by fcloutier).
format_arg attribute should allow instancetype in NSString definition
Oct 28 2021, 8:33 PM
fcloutier closed D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface.
Oct 28 2021, 8:32 PM · Restricted Project
fcloutier updated the diff for D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface.

Add test for a protocol method with format_arg, second NSString method accepting a NSString instead of a C string

Oct 28 2021, 8:20 PM · Restricted Project
fcloutier updated the diff for D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface.
Oct 28 2021, 8:02 PM · Restricted Project
fcloutier added a comment to D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface.

Apologies, Phabricator showed the comment below line 197 in the diff, but the email showed it to be below line 3404. I can check if the return type is instancetype in handleFormatArgAttr and use that instead.

Oct 28 2021, 7:37 PM · Restricted Project
fcloutier added inline comments to D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface.
Oct 28 2021, 7:35 PM · Restricted Project
fcloutier updated the diff for D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface.

Forgot to run clang-format.

Oct 28 2021, 3:29 PM · Restricted Project

Oct 27 2021

fcloutier committed rGd378a0febc7e: [Sema] Recognize format argument indicated by format attribute inside blocks (authored by fcloutier).
[Sema] Recognize format argument indicated by format attribute inside blocks
Oct 27 2021, 3:49 PM
fcloutier closed D112569: -Wformat-nonliteral should not trigger for format strings passed to blocks with __attribute__((format)).
Oct 27 2021, 3:48 PM · Restricted Project
fcloutier requested review of D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface.
Oct 27 2021, 3:32 PM · Restricted Project
fcloutier updated the diff for D112569: -Wformat-nonliteral should not trigger for format strings passed to blocks with __attribute__((format)).
Oct 27 2021, 2:13 PM · Restricted Project

Oct 26 2021

fcloutier requested review of D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`.
Oct 26 2021, 3:35 PM · Restricted Project
fcloutier updated the diff for D112569: -Wformat-nonliteral should not trigger for format strings passed to blocks with __attribute__((format)).

Thanks Artem for pointing out that I was completely misusing getFunctionScopeIndex. This should be better. I added a test that you can pick a non-1 value for the format parameter in blocks.

Oct 26 2021, 2:16 PM · Restricted Project
fcloutier requested review of D112569: -Wformat-nonliteral should not trigger for format strings passed to blocks with __attribute__((format)).
Oct 26 2021, 12:14 PM · Restricted Project

Feb 5 2021

fcloutier updated the summary of D96196: [Sema][NFC] Create Sema::BuildImplicitCast.
Feb 5 2021, 8:28 PM · Restricted Project
fcloutier requested review of D96196: [Sema][NFC] Create Sema::BuildImplicitCast.
Feb 5 2021, 8:19 PM · Restricted Project

Feb 3 2021

fcloutier committed rG554cf3729e65: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic… (authored by fcloutier).
[clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic…
Feb 3 2021, 11:43 AM
fcloutier closed D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified.
Feb 3 2021, 11:43 AM · Restricted Project

Feb 2 2021

fcloutier added inline comments to D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified.
Feb 2 2021, 2:22 PM · Restricted Project
fcloutier updated the diff for D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified.

Address Aaron's feedback

Feb 2 2021, 2:20 PM · Restricted Project

Jan 29 2021

fcloutier updated the diff for D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified.

Updating the diff using arcanist, which I'm told produces better results. Sorry for the churn!

Jan 29 2021, 1:24 PM · Restricted Project
fcloutier updated the summary of D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified.
Jan 29 2021, 12:57 PM · Restricted Project
fcloutier requested review of D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified.
Jan 29 2021, 12:51 PM · Restricted Project