Page MenuHomePhabricator

falstaff84 (Stefan Agner)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 20 2018, 12:23 PM (124 w, 5 d)

Recent Activity

Jun 26 2020

falstaff84 created D82692: [ARM] do not consider sp as deprecated for ldm/stm.
Jun 26 2020, 4:48 PM · Restricted Project

Jun 24 2020

falstaff84 committed rGb7d41a11cd31: [ARM] Make cp10 and cp11 usage a warning (authored by falstaff84).
[ARM] Make cp10 and cp11 usage a warning
Jun 24 2020, 2:41 PM
falstaff84 closed D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.
Jun 24 2020, 2:41 PM · Restricted Project

Jun 23 2020

falstaff84 updated the diff for D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.
  • Added comment why allowing cp10/cp11 make sense
  • Use check prefixes in coprocessors.s in a sensible mannor
Jun 23 2020, 4:11 PM · Restricted Project

Jun 22 2020

falstaff84 added a comment to D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.

for ARMv7 we only disallowed this pair, and this change removes that restriction. So now, all of them are allowed...

Yes, for Arm v7.

What I'm getting at is: should we turn the whole of isValidCoprocessorNumber into warnings of this kind, on the same principle (that it's OK to write any CDP instruction if it's in the context of code that will dynamically decide at run time which instructions to actually execute)? If not, what makes this v7 constraint different from the v8 ones?

Jun 22 2020, 2:00 PM · Restricted Project
falstaff84 added a comment to D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.

@simon_tatham not sure what you exactly mean, for ARMv7 we only disallowed this pair, and this change removes that restriction. So now, all of them are allowed...

Jun 22 2020, 3:10 AM · Restricted Project

Jun 20 2020

falstaff84 added a comment to D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.

From what I can see the mrc in venum_read_pmresr() is not a VFP/Neon instruction. It hails from arch/arm/kernel/perf_event_v7.c and is specific to Qualcomm's Scorpion and Krait CPUs. My understanding is that CP15 is used for the PMU in v7, it is possible that the use of p10 there is a mistake but I'm not knowledgeable enough about Scorpion and Krait to know whether this is the case.

Jun 20 2020, 2:17 PM · Restricted Project
falstaff84 updated the diff for D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.
Jun 20 2020, 1:46 PM · Restricted Project

Mar 19 2020

falstaff84 added a comment to D75428: [MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht.

Thanks for the hint! Did pretty much all of that, but used git am instead of arc, thought it does not really make a difference. Will use arc next time!

Mar 19 2020, 11:57 PM · Restricted Project
falstaff84 committed rGf87563661d66: [MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht (authored by falstaff84).
[MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht
Mar 19 2020, 3:23 PM
falstaff84 added a comment to D75428: [MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht.

Committed on master: https://github.com/llvm/llvm-project/commit/f87563661d6661fd4843beb8f391acd077b08dbe

Mar 19 2020, 3:22 PM · Restricted Project

Mar 17 2020

falstaff84 added a comment to D75428: [MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht.

@nickdesaulniers I actually tired to get commit access myself but haven't heard back from Chris yet. So yes would be good if somebody could commit this already.

Mar 17 2020, 1:34 AM · Restricted Project

Mar 9 2020

falstaff84 updated the diff for D75428: [MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht.
Mar 9 2020, 5:17 PM · Restricted Project
falstaff84 added a comment to D75428: [MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht.

@efriedma, @jcai19, thanks for feedback, updated the patch accordingly. This now assembles and disassembles to the same encoding as binutils does (#0).

Mar 9 2020, 5:17 PM · Restricted Project

Mar 2 2020

falstaff84 added a comment to D75428: [MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht.

@efriedma I tried the InstAlias approach at first, but it did not work for reasons I don't exactly recall.

Mar 2 2020, 2:56 PM · Restricted Project
falstaff84 added a comment to D75428: [MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht.

This indeed looks much nicer. I was somehow under the assumption that this was not an option since we moved away from using separate instructions for {ld,st}r{,b}t:
https://github.com/llvm/llvm-project/commit/fb3950ec6312dfa4317d8cbf83a1db4aae7428ce

Mar 2 2020, 12:43 AM · Restricted Project

Mar 1 2020

falstaff84 created D75428: [MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht.
Mar 1 2020, 2:46 PM · Restricted Project

Feb 27 2020

falstaff84 added a comment to D75144: [ARM][Thumb2] Support .w assembler qualifier for pld/pldw/pli.

Thanks for the review. I do not have commit access, so I would be glad if somebody could merge that for me.

Feb 27 2020, 2:41 PM · Restricted Project
falstaff84 updated the diff for D75143: [ARM][Thumb2] support .w assembler qualifier for dmb/dsb/isb.
  • add .w alias for dmb/dsb/isb with argument
Feb 27 2020, 2:29 PM · Restricted Project
falstaff84 added a comment to D74927: [MC][ARM] make Thumb function also if type attribute is set.

[..]
Apologies for all the details, there may be a simpler way of doing this.

Feb 27 2020, 2:28 PM · Restricted Project

Feb 25 2020

falstaff84 added a comment to D74927: [MC][ARM] make Thumb function also if type attribute is set.

[...]
On the Linux kernel side, it'd be nice to make a change anyway if that moves us away from an edge case.

Feb 25 2020, 3:14 PM · Restricted Project
falstaff84 created D75144: [ARM][Thumb2] Support .w assembler qualifier for pld/pldw/pli.
Feb 25 2020, 2:55 PM · Restricted Project
falstaff84 created D75143: [ARM][Thumb2] support .w assembler qualifier for dmb/dsb/isb.
Feb 25 2020, 2:55 PM · Restricted Project
falstaff84 retitled D75143: [ARM][Thumb2] support .w assembler qualifier for dmb/dsb/isb from [ARM][Thumb2] support .w assembler qualifier for to [ARM][Thumb2] support .w assembler qualifier for dmb/dsb/isb.
Feb 25 2020, 2:55 PM · Restricted Project

Feb 23 2020

falstaff84 updated the diff for D74927: [MC][ARM] make Thumb function also if type attribute is set.
  • Check if Symbol has previously been defined
  • Remove unnecessary cast
  • Mark function as override
Feb 23 2020, 4:19 PM · Restricted Project
falstaff84 added inline comments to D74927: [MC][ARM] make Thumb function also if type attribute is set.
Feb 23 2020, 4:15 PM · Restricted Project

Feb 20 2020

falstaff84 created D74927: [MC][ARM] make Thumb function also if type attribute is set.
Feb 20 2020, 1:25 PM · Restricted Project

Mar 23 2019

falstaff84 created D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.
Mar 23 2019, 3:01 AM · Restricted Project

Dec 29 2018

falstaff84 added a comment to D55505: [LLD][ELF] Implement option to force PIC compatible Thunks.

In my test case using Linux compiled for Arm using allyesconfig and ld.lld with these changes applied linking fails as follows:

Dec 29 2018, 4:34 AM

Sep 27 2018

falstaff84 accepted D52594: [ARM] Remove non-existent cpu arm1176j-s and use mpcore for v6k.

With that building CONFIG_ARCH_MULTI_V6=y seems to work. Also LLVM emits the correct CPU:

Sep 27 2018, 7:47 AM

Mar 20 2018

falstaff84 added a comment to D18086: Fix default processor name for armv6k..

I seem to have a related issue: I am using -march=armv6k and -no-integrated-as, this generates the following output:

Mar 20 2018, 12:37 PM
falstaff84 requested changes to D18086: Fix default processor name for armv6k..
Mar 20 2018, 12:34 PM