Page MenuHomePhabricator
People exv

exv (Eliza Velasquez)
User

Projects

User does not belong to any projects.

User Details

User Since
May 1 2021, 2:59 PM (60 w, 6 d)

Recent Activity
View All

Jun 30 2021

exv accepted D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect.
Jun 30 2021, 10:47 AM · Restricted Project, Restricted Project

Jun 29 2021

exv updated subscribers of D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect.

Sorry, been away from my setup lately. I'll approve once I'm back at my PC
hopefully by EOD.

Jun 29 2021, 5:35 PM · Restricted Project, Restricted Project

Jun 23 2021

exv requested changes to D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect.

Oops, didn't mean to accept, see my other comment.

Jun 23 2021, 11:54 AM · Restricted Project, Restricted Project
exv accepted D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect.

I have a few concerns about this implementation:

Jun 23 2021, 11:53 AM · Restricted Project, Restricted Project

May 5 2021

exv updated the diff for D101862: [clang-format] Rename common types between C#/JS.

Rebase again in an attempt to fix CI

May 5 2021, 1:55 PM · Restricted Project, Restricted Project
exv updated the diff for D101860: [clang-format] Fix C# nullable-related errors.

Rebase again in an attempt to fix CI

May 5 2021, 1:54 PM · Restricted Project, Restricted Project
exv updated the diff for D101702: [clang-format] Add more support for C# 8 nullables.

Rebase again in an attempt to fix CI

May 5 2021, 1:53 PM · Restricted Project, Restricted Project
exv updated the diff for D101862: [clang-format] Rename common types between C#/JS.

Rebase

May 5 2021, 12:35 PM · Restricted Project, Restricted Project
exv updated the diff for D101860: [clang-format] Fix C# nullable-related errors.
  • Incorporate curdeius's feedback
May 5 2021, 12:30 PM · Restricted Project, Restricted Project
exv updated the summary of D101862: [clang-format] Rename common types between C#/JS.
May 5 2021, 12:28 PM · Restricted Project, Restricted Project
exv updated the summary of D101702: [clang-format] Add more support for C# 8 nullables.
May 5 2021, 12:28 PM · Restricted Project, Restricted Project
exv updated the summary of D101860: [clang-format] Fix C# nullable-related errors.
May 5 2021, 12:28 PM · Restricted Project, Restricted Project
exv added a comment to D101702: [clang-format] Add more support for C# 8 nullables.

Rebased and comments addressed!

May 5 2021, 12:27 PM · Restricted Project, Restricted Project
exv updated the diff for D101702: [clang-format] Add more support for C# 8 nullables.
  • Incorporate krasimir's feedback
May 5 2021, 12:26 PM · Restricted Project, Restricted Project

May 4 2021

exv added a project to D101862: [clang-format] Rename common types between C#/JS: Restricted Project.
May 4 2021, 2:31 PM · Restricted Project, Restricted Project
exv requested review of D101862: [clang-format] Rename common types between C#/JS.
May 4 2021, 2:30 PM · Restricted Project, Restricted Project
exv added reviewers for D101860: [clang-format] Fix C# nullable-related errors: MyDeveloperDay, curdeius.
May 4 2021, 2:27 PM · Restricted Project, Restricted Project
exv requested review of D101860: [clang-format] Fix C# nullable-related errors.
May 4 2021, 2:25 PM · Restricted Project, Restricted Project
exv added a comment to D101702: [clang-format] Add more support for C# 8 nullables.

I have completed two other formatting fixes related to C# 8 nullables since my last commit. Should I create a new review request for those or update this one?

May 4 2021, 2:04 PM · Restricted Project, Restricted Project
exv updated exv.
May 4 2021, 12:19 PM
exv added a comment to D101702: [clang-format] Add more support for C# 8 nullables.

Eliza Velasquez <exv@google.com>

May 4 2021, 12:18 PM · Restricted Project, Restricted Project
exv added a comment to D101702: [clang-format] Add more support for C# 8 nullables.

According to the wiki, it seems like someone who has commit access must now submit this change.

May 4 2021, 11:53 AM · Restricted Project, Restricted Project
exv updated the diff for D101702: [clang-format] Add more support for C# 8 nullables.
  • Remove obsolete comment
May 4 2021, 11:52 AM · Restricted Project, Restricted Project

May 3 2021

exv added inline comments to D101702: [clang-format] Add more support for C# 8 nullables.
May 3 2021, 4:47 PM · Restricted Project, Restricted Project
exv updated the diff for D101702: [clang-format] Add more support for C# 8 nullables.
  • [clang-format] Add more support for C# 8 nullables
  • Fix null-coalescing assignment whitespace behavior
  • Incorporate feedback from curdeius
  • Combine JS and CS types/parsing
May 3 2021, 4:46 PM · Restricted Project, Restricted Project
exv added inline comments to D101702: [clang-format] Add more support for C# 8 nullables.
May 3 2021, 1:34 PM · Restricted Project, Restricted Project
exv removed reviewers for D101702: [clang-format] Add more support for C# 8 nullables: andreadb, rriddle, aartbik, Restricted Project.
May 3 2021, 1:17 PM · Restricted Project, Restricted Project
exv added a comment to D101702: [clang-format] Add more support for C# 8 nullables.

Hey all, I'm really sorry for the noise, I screwed up my arc command to revise the submission.

May 3 2021, 1:11 PM · Restricted Project, Restricted Project
exv updated the diff for D101702: [clang-format] Add more support for C# 8 nullables.

Fixing arc, hopefully?

May 3 2021, 1:09 PM · Restricted Project, Restricted Project
exv updated the diff for D101702: [clang-format] Add more support for C# 8 nullables.

Fix incorrect arc usage

May 3 2021, 1:06 PM · Restricted Project, Restricted Project
exv added inline comments to D101702: [clang-format] Add more support for C# 8 nullables.
May 3 2021, 12:09 PM · Restricted Project, Restricted Project
exv updated the diff for D101702: [clang-format] Add more support for C# 8 nullables.

Remove special whitespace handling for ??=

May 3 2021, 12:09 PM · Restricted Project, Restricted Project

May 1 2021

exv requested review of D101702: [clang-format] Add more support for C# 8 nullables.
May 1 2021, 3:11 PM · Restricted Project, Restricted Project