Page MenuHomePhabricator

evstupac (Evgeny Stupachenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2015, 3:41 PM (177 w, 3 d)

Recent Activity

Aug 1 2018

evstupac added a comment to D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution.

PING

Aug 1 2018, 1:02 PM

Jul 13 2018

evstupac added a comment to D38611: Fix X86 regression on linpack .

PING.

Jul 13 2018, 9:21 AM
evstupac added a comment to D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution.

PING

Jul 13 2018, 9:20 AM

Jun 26 2018

evstupac added inline comments to D48599: SCEVExpander::expandAddRecExprLiterally(): check before casting as Instruction.
Jun 26 2018, 10:48 AM

Jun 8 2018

evstupac added a comment to D38611: Fix X86 regression on linpack .

PING.

Jun 8 2018, 1:08 PM

Jun 7 2018

evstupac updated the summary of D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution.
Jun 7 2018, 2:05 PM
evstupac added a comment to D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution.

I think it might help if the motivational part would be specified in the differential's description.

Why is this wanted?

It was requested by Quentin in https://reviews.llvm.org/D29862

Jun 7 2018, 2:01 PM
evstupac added a comment to D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution.

PING.

Jun 7 2018, 12:59 PM

Jun 1 2018

evstupac added inline comments to D38611: Fix X86 regression on linpack .
Jun 1 2018, 11:59 AM

May 31 2018

evstupac added a comment to D38611: Fix X86 regression on linpack .

PING

May 31 2018, 12:14 PM
evstupac added a comment to D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution.

PING

May 31 2018, 12:13 PM

May 24 2018

evstupac added a comment to D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution.

PING

May 24 2018, 10:31 AM
evstupac added a comment to D38611: Fix X86 regression on linpack .

PING.

May 24 2018, 10:30 AM

May 16 2018

evstupac added a comment to D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution.

PING.

May 16 2018, 10:07 AM
evstupac added a comment to D38611: Fix X86 regression on linpack .

PING.

May 16 2018, 10:05 AM

May 15 2018

evstupac committed rL332426: Fix LSR compile time hang..
Fix LSR compile time hang.
May 15 2018, 7:53 PM
evstupac closed D46039: Fix compile time hang in LSR.
May 15 2018, 7:52 PM

May 2 2018

evstupac abandoned D34117: PR32632 Add a case to remove loop compare.
May 2 2018, 12:27 PM
evstupac abandoned D20847: BitCast infinite loop fix.
May 2 2018, 12:25 PM
evstupac abandoned D29965: PR18606 fix hang in GetMinTrailingZeros.
May 2 2018, 12:18 PM
evstupac added reviewers for D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution: gottesmm, scanon.
May 2 2018, 12:11 PM
evstupac abandoned D39467: PR34603 Fix by Early-CSE extension.
May 2 2018, 12:08 PM
evstupac abandoned D27321: Fix LSR ImmCost calculation for profitable chains.
May 2 2018, 12:03 PM
evstupac abandoned D27695: Add Instruction number to LSR cost model (PR23384).
May 2 2018, 12:01 PM
evstupac abandoned D24593: Standford/Bubble sort code restructure.
May 2 2018, 12:00 PM
evstupac added a comment to D46039: Fix compile time hang in LSR.

PING. The change does not change code in spec2000/spec2006. However, it prevents compile time hangs in some corner cases.

May 2 2018, 11:57 AM

Apr 30 2018

evstupac added a reviewer for D46039: Fix compile time hang in LSR: junbuml.
Apr 30 2018, 1:15 PM

Apr 26 2018

evstupac updated the diff for D38611: Fix X86 regression on linpack .

Addressed comments. Made heuristic more precise.

Apr 26 2018, 12:17 PM

Apr 25 2018

evstupac added inline comments to D46039: Fix compile time hang in LSR.
Apr 25 2018, 12:02 PM
evstupac added a comment to D46039: Fix compile time hang in LSR.

Did you intend to limit the number of reassociations to 16 at each level ?

A kind of. However the patch allows >16 and < 256 on the first level.

Apr 25 2018, 8:05 AM

Apr 24 2018

evstupac added a comment to D46039: Fix compile time hang in LSR.

Could you please explain what is the problem? I cannot make it out from the test, it's too big. Can it be reduced?

Apr 24 2018, 7:55 PM
evstupac updated the diff for D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution.

Use APFloat instead of new class.

Apr 24 2018, 7:08 PM
evstupac created D46039: Fix compile time hang in LSR.
Apr 24 2018, 6:58 PM

Mar 22 2018

evstupac committed rL328257: Revert r325687 (workaround for PR36032)..
Revert r325687 (workaround for PR36032).
Mar 22 2018, 3:08 PM
evstupac closed D44768: revert 325687.
Mar 22 2018, 3:07 PM

Mar 21 2018

evstupac added inline comments to D44766: Extend peeling to help invariant motion.
Mar 21 2018, 6:59 PM
evstupac created D44768: revert 325687.
Mar 21 2018, 6:18 PM
evstupac created D44766: Extend peeling to help invariant motion.
Mar 21 2018, 5:52 PM

Mar 14 2018

evstupac accepted D43931: [LoopUnroll] Ignore ephemeral values when checking full unroll profitability..

LGTM.

Mar 14 2018, 12:04 PM

Mar 6 2018

evstupac committed rL326861: Add early exit on reassociation of 0 expression..
Add early exit on reassociation of 0 expression.
Mar 6 2018, 6:20 PM
evstupac closed D41467: PR35710: Nary reassociation falls into infinite loop.
Mar 6 2018, 6:20 PM

Mar 2 2018

evstupac added reviewers for D41467: PR35710: Nary reassociation falls into infinite loop: pankajchawla, craig.topper.
Mar 2 2018, 2:17 PM

Feb 26 2018

evstupac committed rL326158: Fix r326154 buildbots test fail.
Fix r326154 buildbots test fail
Feb 26 2018, 5:35 PM
evstupac committed rL326154: Fix PR36032, PR35432.
Fix PR36032, PR35432
Feb 26 2018, 4:19 PM
evstupac closed D42604: PR36032 fix assert cause by not computed SCEV PredicatedBackEdgeCount.
Feb 26 2018, 4:19 PM
evstupac added a comment to D41467: PR35710: Nary reassociation falls into infinite loop.

PING

Feb 26 2018, 12:17 PM

Feb 12 2018

evstupac updated the diff for D42604: PR36032 fix assert cause by not computed SCEV PredicatedBackEdgeCount.
Feb 12 2018, 3:04 PM

Feb 9 2018

evstupac updated the diff for D42604: PR36032 fix assert cause by not computed SCEV PredicatedBackEdgeCount.
Feb 9 2018, 4:00 PM
evstupac added inline comments to D42604: PR36032 fix assert cause by not computed SCEV PredicatedBackEdgeCount.
Feb 9 2018, 4:00 PM
evstupac updated the diff for D41467: PR35710: Nary reassociation falls into infinite loop.

Leave only zero check and move it to an earlier stage.

Feb 9 2018, 12:58 PM

Jan 29 2018

evstupac added a comment to D42607: [LoopStrengthReduce, x86] don't add cost for a cmp that will be macro-fused (PR35681).

It is not obvious that constants in address can somehow hurt performance.
I'll run the patch on the benchmarks I have. However I believe performance issue in PR35861 is about complicated addresses which limit execution ports for stores.

Jan 29 2018, 11:34 AM

Jan 26 2018

evstupac created D42604: PR36032 fix assert cause by not computed SCEV PredicatedBackEdgeCount.
Jan 26 2018, 3:00 PM

Jan 10 2018

evstupac added inline comments to D41467: PR35710: Nary reassociation falls into infinite loop.
Jan 10 2018, 4:19 PM

Jan 4 2018

evstupac added inline comments to D41467: PR35710: Nary reassociation falls into infinite loop.
Jan 4 2018, 10:33 PM
evstupac committed rC321854: NFC..
NFC.
Jan 4 2018, 6:24 PM
evstupac committed rL321854: NFC..
NFC.
Jan 4 2018, 6:23 PM
evstupac added inline comments to rL321395: [ODRHash] Support ODR violation detection in functions..
Jan 4 2018, 5:02 PM
evstupac added a comment to D41467: PR35710: Nary reassociation falls into infinite loop.

PING2

Jan 4 2018, 3:39 PM

Dec 28 2017

evstupac added a comment to D41467: PR35710: Nary reassociation falls into infinite loop.

PING

Dec 28 2017, 11:08 AM

Dec 26 2017

evstupac accepted D41466: [Unroll][DebugInfo] Propagate loop body's debug location to epilog preheader.
Dec 26 2017, 12:38 PM · debug-info

Dec 21 2017

evstupac added inline comments to D41466: [Unroll][DebugInfo] Propagate loop body's debug location to epilog preheader.
Dec 21 2017, 5:47 PM · debug-info
evstupac added a comment to D41467: PR35710: Nary reassociation falls into infinite loop.

To be more precise NaryReassociation works that way:
r0 = v * 16
r1= r0 * 0
r2 = r1 * 1

Dec 21 2017, 1:50 PM
evstupac added inline comments to D41466: [Unroll][DebugInfo] Propagate loop body's debug location to epilog preheader.
Dec 21 2017, 12:54 PM · debug-info

Dec 20 2017

evstupac created D41467: PR35710: Nary reassociation falls into infinite loop.
Dec 20 2017, 2:50 PM

Nov 3 2017

evstupac committed rL317348: The patch fixes PR35131.
The patch fixes PR35131
Nov 3 2017, 11:50 AM
evstupac closed D39585: PR35131 Fix a misprint in CTLZ recognition by committing rL317348: The patch fixes PR35131.
Nov 3 2017, 11:50 AM

Nov 2 2017

evstupac created D39585: PR35131 Fix a misprint in CTLZ recognition.
Nov 2 2017, 6:09 PM
evstupac added a comment to D38611: Fix X86 regression on linpack .

Hi Quentin,

Nov 2 2017, 2:42 PM

Nov 1 2017

evstupac added a comment to D38611: Fix X86 regression on linpack .

PING.

Nov 1 2017, 1:44 AM

Oct 31 2017

evstupac created D39467: PR34603 Fix by Early-CSE extension.
Oct 31 2017, 11:56 AM

Oct 5 2017

evstupac created D38611: Fix X86 regression on linpack .
Oct 5 2017, 7:37 PM

Sep 26 2017

evstupac added inline comments to rL313955: Give external linkage and mangling to lambdas inside inline variables and….
Sep 26 2017, 6:48 PM
evstupac added inline comments to rL313955: Give external linkage and mangling to lambdas inside inline variables and….
Sep 26 2017, 6:25 PM

Sep 1 2017

evstupac added a comment to D36895: Add a class for fixed point arithmetic.

PING2

Sep 1 2017, 8:08 AM

Aug 28 2017

evstupac added a comment to D37209: [LSR] Fix Shadow IV in case of integer overflow.

Hi Max,

Aug 28 2017, 9:31 AM

Aug 25 2017

evstupac added a comment to D36895: Add a class for fixed point arithmetic.

PING.

Aug 25 2017, 8:42 AM

Aug 18 2017

evstupac created D36895: Add a class for fixed point arithmetic.
Aug 18 2017, 1:42 PM

Aug 7 2017

evstupac committed rL310289: Reapply fix PR23384 (part 3 of 3) r304824 (was reverted in r305720)..
Reapply fix PR23384 (part 3 of 3) r304824 (was reverted in r305720).
Aug 7 2017, 12:57 PM

Aug 4 2017

evstupac committed rL310092: Fix PR33514.
Fix PR33514
Aug 4 2017, 11:47 AM
evstupac closed D36170: LSR: Fix PR33514 by committing rL310092: Fix PR33514.
Aug 4 2017, 11:47 AM

Aug 2 2017

evstupac added a comment to D36170: LSR: Fix PR33514.

Other tests that have difference in binaries got the same performance.

Interesting, given we were generating invalid code, what changed there?

Aug 2 2017, 3:11 PM

Aug 1 2017

evstupac added a comment to D36170: LSR: Fix PR33514.

Hi Quentin,

Aug 1 2017, 3:03 PM
evstupac created D36170: LSR: Fix PR33514.
Aug 1 2017, 12:56 PM

Jun 12 2017

evstupac added a comment to D34117: PR32632 Add a case to remove loop compare.

Scalar evolution can already analyze the given testcase on trunk. Output of "opt -analyze -scalar-evolution":

Jun 12 2017, 2:41 PM
evstupac created D34117: PR32632 Add a case to remove loop compare.
Jun 12 2017, 12:40 PM

Jun 6 2017

evstupac committed rL304834: Added tests for X86InterleavedStore..
Added tests for X86InterleavedStore.
Jun 6 2017, 2:08 PM
evstupac closed D33684: Added tests for lowerInterleavedStore. by committing rL304834: Added tests for X86InterleavedStore..
Jun 6 2017, 2:08 PM
evstupac committed rL304824: Fix PR23384 (part 3 of 3).
Fix PR23384 (part 3 of 3)
Jun 6 2017, 1:05 PM
evstupac closed D30562: Add Instruction number to LSR cost model (PR23384) part 3 of 3 by committing rL304824: Fix PR23384 (part 3 of 3).
Jun 6 2017, 1:04 PM

Jun 5 2017

evstupac committed rL304750: Fix PR23384 (part 2 of 3) NFC.
Fix PR23384 (part 2 of 3) NFC
Jun 5 2017, 4:37 PM
evstupac closed D30561: Add Instruction number to LSR cost model (PR23384) part 2 of 3 by committing rL304750: Fix PR23384 (part 2 of 3) NFC.
Jun 5 2017, 4:37 PM
evstupac committed rL304746: LSR: Calculate instruction cost only if InsnsCost is set to true (NFC).
LSR: Calculate instruction cost only if InsnsCost is set to true (NFC)
Jun 5 2017, 3:44 PM
evstupac closed D33914: LSR: Calculate instruction cost only if InsnsCost is set to true (NFC) by committing rL304746: LSR: Calculate instruction cost only if InsnsCost is set to true (NFC).
Jun 5 2017, 3:44 PM
evstupac created D33914: LSR: Calculate instruction cost only if InsnsCost is set to true (NFC).
Jun 5 2017, 2:52 PM

Jun 2 2017

evstupac added a comment to D21720: Unroll for uncountable loops.

PING.

Jun 2 2017, 2:45 PM

May 31 2017

evstupac added a comment to D30562: Add Instruction number to LSR cost model (PR23384) part 3 of 3.

PING

May 31 2017, 11:52 AM

May 26 2017

evstupac added a comment to D21720: Unroll for uncountable loops.

The use of the "Force" bit here is still really confusing... we need a better way of expressing the profitability of unrolling.

May 26 2017, 3:15 PM
evstupac added a comment to D30552: Fix regressions cased by D29862.

How do you think which way we should follow?
Or we can leave regression as is as Solution Cost is better and therefore it is not a problem of newly implemented NarrowSearchSpaceByDeletingCostlyFormulas()?

May 26 2017, 1:18 PM
evstupac added a comment to D21720: Unroll for uncountable loops.

PING

May 26 2017, 1:11 PM

May 23 2017

evstupac added a comment to D30562: Add Instruction number to LSR cost model (PR23384) part 3 of 3.

Code size numbers for x86 spec2000 O2, 32 bit:
Overall code size (sum of all spec text section binary sizes) -0.2%, overall instruction count -0.3%

May 23 2017, 7:04 PM