Page MenuHomePhabricator

euhlmann (Erik Uhlmann)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2017, 8:23 AM (112 w, 5 d)

Recent Activity

Aug 24 2017

euhlmann added a comment to D35955: clang-format: Add preprocessor directive indentation.

I'm glad this is finally in a state to land. Thanks for the helpful reviews!

Aug 24 2017, 8:39 AM · Restricted Project

Aug 23 2017

euhlmann updated the summary of D35955: clang-format: Add preprocessor directive indentation.
Aug 23 2017, 2:27 PM · Restricted Project
euhlmann added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 23 2017, 1:51 PM · Restricted Project
euhlmann updated the diff for D35955: clang-format: Add preprocessor directive indentation.
  • Swapped checks in ContinuationIndenter
  • Renamed PPMaybeIncludeGuard to IfNdefCondition and added comment
  • Added another bool member that tracks if include guard detection was rejected once. If the bool gets set, the loop checking previous lines doesn't run again.
  • Set lower ColumnLimit in tests
  • Fixed incorrect column for \ in multi-line macros
  • Resolved comment in FormatTestUtils
Aug 23 2017, 1:51 PM · Restricted Project

Aug 22 2017

euhlmann added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 22 2017, 3:03 PM · Restricted Project

Aug 17 2017

euhlmann updated the diff for D35955: clang-format: Add preprocessor directive indentation.

Eliminated redundancy in tests by fixing test::messUp which was incorrectly merging lines.

Aug 17 2017, 7:38 PM · Restricted Project

Aug 16 2017

euhlmann updated the diff for D35955: clang-format: Add preprocessor directive indentation.

Allows comments before the include guard opens. However, if there's a single non-comment line before an include-guard-like structure that meets all the other conditions then it will be treated as an include guard because Lines does not yet contain the line before the #ifndef. This looks difficult to fix and I believe it's a rare enough situation to ignore.

Aug 16 2017, 4:36 PM · Restricted Project

Aug 15 2017

euhlmann added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 15 2017, 2:32 PM · Restricted Project

Aug 10 2017

euhlmann updated the diff for D35955: clang-format: Add preprocessor directive indentation.

The patch now uses PPBranchLevel to track indent level. It allows PPBranchLevel to go back down to -1. The existing PPBranchLevel >= 0 checks appear to prevent indexing into structures when PPBranchLevel is -1.

Aug 10 2017, 9:59 AM · Restricted Project

Aug 9 2017

euhlmann updated the summary of D35955: clang-format: Add preprocessor directive indentation.
Aug 9 2017, 10:36 AM · Restricted Project
euhlmann updated the diff for D35955: clang-format: Add preprocessor directive indentation.

This addresses Daniel's previous concerns. The option is now an enum, the heuristic for detecting include guards is expanded and has corresponding unit tests, and style issues are resolved.
This does not yet use PPBranchLevel to track indent; I'm updating this review with my current work before addressing that point.

Aug 9 2017, 10:22 AM · Restricted Project

Aug 8 2017

euhlmann added a comment to D35955: clang-format: Add preprocessor directive indentation.

I think if we need this info, we can just make it count down to -1 again (or, but that's isomorphic, let it run from 0 and make sure we never index into the data structures at 0 :)

Aug 8 2017, 3:11 PM · Restricted Project

Aug 7 2017

euhlmann added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 7 2017, 2:23 PM · Restricted Project
euhlmann added a comment to D35847: clang-format: Fix left pointer alignment after delctype/typeof.

I resolved the formatting issues. I apologize for not paying closer attention to formatting earlier.

Aug 7 2017, 11:18 AM · Restricted Project
euhlmann updated the diff for D35847: clang-format: Fix left pointer alignment after delctype/typeof.

Ran clang-format over changes and corrected formatting

Aug 7 2017, 11:11 AM · Restricted Project

Aug 4 2017

euhlmann updated the diff for D35847: clang-format: Fix left pointer alignment after delctype/typeof.

Fix bad formatting

Aug 4 2017, 12:59 PM · Restricted Project
euhlmann updated the diff for D35847: clang-format: Fix left pointer alignment after delctype/typeof.

Pulled out getPreviousNonComment() into local variable to avoid calling twice.

Aug 4 2017, 11:32 AM · Restricted Project

Aug 3 2017

euhlmann updated the diff for D35847: clang-format: Fix left pointer alignment after delctype/typeof.

This uses FormatToken::getPreviousNonComment and adds a test. This also fixes a bug in token annotation that was breaking the test (by also using getPreviousNonComment instead of Previous)

Aug 3 2017, 12:17 PM · Restricted Project
euhlmann added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 3 2017, 11:09 AM · Restricted Project

Aug 2 2017

euhlmann added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 2 2017, 12:23 PM · Restricted Project

Jul 27 2017

euhlmann created D35955: clang-format: Add preprocessor directive indentation.
Jul 27 2017, 12:54 PM · Restricted Project

Jul 25 2017

euhlmann created D35847: clang-format: Fix left pointer alignment after delctype/typeof.
Jul 25 2017, 10:35 AM · Restricted Project