- User Since
- Jul 16 2019, 12:59 PM (100 w, 1 d)
May 7 2021
LGTM as a temporary workaround until SPMD properly assigns team private variables.
May 5 2021
May 4 2021
Apr 29 2021
In reference to https://bugs.llvm.org/show_bug.cgi?id=48851, I do not see how this helps SPMD mode with team privatization of declarations in-between target teams and parallel regions.
Feb 7 2020
- Added FIXME comment to describe change in omp_get_max_threads behavior.
Feb 6 2020
- Update max_threads.c api test to match the change for omp_get_max_threads().
Feb 5 2020
I can definitely add the change to max_threads.c to this review. The CHECK would become 64 due to the fact we are counting all threads now with this proposed change 32 thread_limit + 32 master warp.
// CHECK: Non-SPMD MaxThreadsL1 = 64
Yes, the test I proposed would be for nvptx only due to the fact that the other tests reside in the nvptx directory and the original max_threads test was checking nvptx values as well. Is the plan to convert all tests so that they support different architectures in the future and move them to common?